Existing HTML 5 fullscreen does not work with fullscreen webapps |
||||
Issue descriptionRepro steps: 1) Add https://tests.peter.sh/notification-generator to the homescreen via the app menu (Not a WebAPK) 2) Launch the homescreen shortcut 3) Using the inspector, navigate to http://blogs.sitepointstatic.com/examples/tech/full-screen/index.html Notice that the minibar is now visible 4) Tap on the squirrel to enter fullscreen 5) Tap the back button Expected: The Webapp is navigated at http://blogs.sitepointstatic.com/examples/tech/full-screen/index.html Actual: The Webapp is navigated at https://tests.peter.sh/notification-generator Perhaps fixing this bug is unimportant because we will soon use a "Chrome Custom Tab" when a user navigates to a different origin Currently a minibar is shown if a user launches a fullscreen Webapp and navigates to a different origin. I was experimenting whether the minibar is hidden if a the page at the different origin calls document.body.webkitRequestFullscreen() (It is) and found this bug
,
Jan 12 2017
,
Jan 12 2017
Thanks for the report - we should also look into what would happen if the same origin calls requestFullscreen() too.
,
Feb 15 2017
Leo: I think your in-progress fullscreen CL will address this. Feel free to add this bug number to your CL.
,
Feb 16 2017
Thanks, Dominick. Will add it after check whether my CL fixes this.
,
Feb 16 2017
Added it in my CL. It worked as expected in my testing.
,
Feb 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0f67bb9cea082b6e8b1fdf0e392e2fdea524eda commit f0f67bb9cea082b6e8b1fdf0e392e2fdea524eda Author: googleo <googleo@chromium.org> Date: Sun Feb 19 23:59:00 2017 Implement the immersive mode for the FullscreenActivity on Android K+. A web app in immersive mode will hide the Android system navigation and status bars. It will be used to support fullscreen mode for sites added to the home screen. Currently even the "display" mode in web app manifest was configured to fullscreen, it's still launched to a standalone mode. BUG=581522, 680385 Review-Url: https://codereview.chromium.org/2636833003 Cr-Commit-Position: refs/heads/master@{#451533} [modify] https://crrev.com/f0f67bb9cea082b6e8b1fdf0e392e2fdea524eda/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java [modify] https://crrev.com/f0f67bb9cea082b6e8b1fdf0e392e2fdea524eda/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
,
Feb 21 2017
Leo: I think you can mark this as fixed and close the bug now :)
,
Feb 21 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by pkotw...@chromium.org
, Jan 12 2017Labels: OS-Android