@Omri, these have already been revamp under the harmony flag. 
The only one that needs to be revamped is the bluetooth one. 

Seems like there's miscommunication there. 

Here is the spec:

https://improv.googleplex.com/projects/ahtzfmdvb2dsZS5jb206aW1wcm92LXNlcnZpY2VyEAsSB1Byb2plY3QY4Za9OQw

Thank you both for the super quick work!
xdai@ could you take implementation over?

Sure.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f121dba52f1410c0303990f943459dc5bf0011c2

commit f121dba52f1410c0303990f943459dc5bf0011c2
Author: xdai <xdai@chromium.org>
Date: Tue Jan 31 18:35:57 2017

[Harmony] Harmony Chrome OS Wifi dialog.

BUG= 680381 

Review-Url: https://codereview.chromium.org/2659973003
Cr-Commit-Position: refs/heads/master@{#447278}

[add] https://crrev.com/f121dba52f1410c0303990f943459dc5bf0011c2/chrome/browser/chromeos/options/DEPS
[modify] https://crrev.com/f121dba52f1410c0303990f943459dc5bf0011c2/chrome/browser/chromeos/options/network_config_view.cc
[modify] https://crrev.com/f121dba52f1410c0303990f943459dc5bf0011c2/chrome/browser/chromeos/options/network_config_view.h
[modify] https://crrev.com/f121dba52f1410c0303990f943459dc5bf0011c2/chrome/browser/chromeos/options/wifi_config_view.cc

Attached are screenshots of Harmonized Bluetooth dialogs (with this CL https://codereview.chromium.org/2684793004/ in place). Note they're not entire the same as seen in the SPEC, because these dialogs are going to be deprecated in M59 so we decide to do the least effort to harmonize Bluetooth dialogs (per offline discussion with stevenjb@ and zork@). 

Deleted: Screenshot 2017-02-08 at 17.20.14.png 4.2 MB

	Screenshot 2017-02-08 at 17.20.14.png 4.2 MB View Download

Deleted: Screenshot 2017-02-08 at 17.20.23.png 4.2 MB

	Screenshot 2017-02-08 at 17.20.23.png 4.2 MB View Download

Deleted: Screenshot 2017-02-08 at 17.21.59.png 4.2 MB

	Screenshot 2017-02-08 at 17.21.59.png 4.2 MB View Download

Deleted: Screenshot 2017-02-08 at 17.22.35.png 4.2 MB

	Screenshot 2017-02-08 at 17.22.35.png 4.2 MB View Download

Just to double-check - in the spec the Wi-Fi connect dialog for enterprise networks looks awfully tall. Does it fit on the 768-pixel tall screen?

Also, for the bluetooth dialog, we're just adding blue buttons and a window caption, right?

Discussed offline, but the plan for 59 is to integrate network configuration into Settings and make Internet and Bluetooth Settings available in a dedicated WebUI window from the login screen so that we can deprecate these dialogs. As such, we should put minimal effort into this and focus on the Settings UI.

As long as the wifi config dialog does not get any taller than it already is, I am pretty certain that it (just) fits on a 768 tall screen... I haven't seen any bugs filed for it anyway... :)

Re#10: The Wifi config dialog gets a little bit taller than it was before but not as tall as seen in the mock. The vertical spacing between rows should be 8dp accroding to Harmony default SPEC, not 16dp as in the mock. Compared with the old design, the only thing changed is the height of the input textfield area (increased to 28px according to Harmony default SPEC). See attached screenshot of the Wifi config dialog.

For bluetooth dialog, We don't add any new buttons or window caption. The thing we display is exactly the same as before, but with different layout/style. 

Deleted: Screenshot 2017-02-09 at 12.12.18 PM.png 790 KB

	Screenshot 2017-02-09 at 12.12.18 PM.png 790 KB View Download

If the wifi config dialog may have increased in height at all then please
confirm that it fits on a 768 pixel tall screen (-e.g
--ash-host-window-bounds=1365x768)

Re#13: Thanks! Confirmed it fits on a 768 pixel tall screen. See screenshots.

Deleted: Screenshot - 02092017 - 04:04:12 PM.png 110 KB

	Screenshot - 02092017 - 04:04:12 PM.png 110 KB View Download

Quick glances: It looks like there's a lot of space between the bottom of the dialog main content and the final button row.  I didn't measure it or check the spec but by eye it seems large.

Also looks like 2-3 DIP too much padding to the left of the "eye" button and about 16 DIP too much to its right.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6cbe1f5574a8ff23a4a1a3570d971679832c017

commit d6cbe1f5574a8ff23a4a1a3570d971679832c017
Author: xdai <xdai@chromium.org>
Date: Fri Feb 10 19:43:08 2017

[Harmony] Harmony Chrome OS VPN/Wimax dialogs.

No change to the non-Harmony look.

BUG= 680381 

Review-Url: https://codereview.chromium.org/2685663003
Cr-Commit-Position: refs/heads/master@{#449697}

[modify] https://crrev.com/d6cbe1f5574a8ff23a4a1a3570d971679832c017/chrome/browser/chromeos/options/vpn_config_view.cc
[modify] https://crrev.com/d6cbe1f5574a8ff23a4a1a3570d971679832c017/chrome/browser/chromeos/options/wimax_config_view.cc

Re#15: The width of the Wifi config dialog as seen in #14 is pre-determined by IDS_JOIN_WIFI_NETWORK_DIALOG_ADVANCED_WIDTH_CHARS (as it might have different value for different languages, e.g, French). The width is the same as non-Harmony width. I think the width was selected to be wide enough to ensure it can hold the content for most languages. As such all the columns are up-scaled a little bit to fit the full width, and that explains the 2-3 DIP more padding to the left of the 'eye' button. And the 16dp padding to the right of the 'eye' button was added intentionally since the padding was also seen in the mock. 

The height of the content area of the dialog is dynamically calculated by the layout manager so the increased height is mostly due to the increased height of the text input filed (note the spacing between rows should keep the same as before, i.e., 8dp). I don't know why the space between the main content and the final button row was increased.. 

I attached a comparison screenshot of Before(with secondary-ui-md flag on)/After/Mock. 

Since these network connectivity dialogs will be deprecated in M59, I think we probably can revert all the design changes (Harmony work will still be preserved) if it's necessary. 

Deleted: wifi_dialog_comparison.png 105 KB

	wifi_dialog_comparison.png 105 KB View Download

Bluetooth dialogs harmonization CL has been landed in https://codereview.chromium.org/2684793004/. (not sure why it doesn't update here.) For screenshots, see #9.

@17: Harmony dialogs should never be sized based on l10n width values.  That's a pre-Harmony-only method.  I don't know precisely what you mean regarding up-scaling columns, but that sort of thing should not be happening in Harmony either.

I don't think the padding right of the eye was an intentional thing in the mock (it's not called out in your comparison shot), and I would remove it, or verify with the designer that it should be removed or kept -- it doesn't match the general Harmony specs to keep it.

I would also check the date on that mock.  Some of the padding values look outdated based on the specs I've been reading and you wouldn't want to be working towards an incorrect mock.

All that said, why are we spending any time at all on dialogs that are deprecated in M59?  Harmony will not ship before M59, so there's no reason to Harmonize anything that won't be meaningful in that.  (Maybe I don't know what "deprecated" means here.)

Re#19: I didn't know these dialogs will be deprecated in M59 and Harmony's launch schedule when I started work on this issue. I can revert all the visual changes of wifi-dialogs. 

pkasting@ not sure what you mean here by deprecated? What xdai@ have been doing is adjusting the things that were missing for harmonizing for these dialogs. 

It's still staying the "same" dialog, at least until something new comes, like embedding the one from settings :-P

omrilio@, The dialogs shown here are all from system tray. They are different with the ones from settings. 'Embedding the one from settings to system tray' (plan for M59) is exactly the reason why we deprecate these dialogs. (see comment#11). But Harmony will not ship before M59.

Per offline chat - no need to revert your changes as you've already made something good that works in-case the embedding part doesn't reach M59.
Let's just make sure that we invest in things that are going to move to embed. 

To be more explicit - we should first take care of dialogs that are not moving to embed system tray. But not revert the changes xdai@ has already made.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b403d81b96c9dd5a244bae996dc65ca22ee9df4d

commit b403d81b96c9dd5a244bae996dc65ca22ee9df4d
Author: xdai <xdai@chromium.org>
Date: Wed Feb 15 18:50:54 2017

Put the new harmonized dialog implementation behind flag.

This CL does the following:
1) Put the harmony work behind the flag --secondary-ui-md so
   nothing is changed for pre-harmony dialogs.
2) Remove the padding to its right "eye" button.
3) For harmonized dialog, the size of the dialog is calculated by its
client view, not from the pre-determined values (as for pre-harmonized dialogs).

BUG= 680381 

Review-Url: https://codereview.chromium.org/2692403002
Cr-Commit-Position: refs/heads/master@{#450746}

[modify] https://crrev.com/b403d81b96c9dd5a244bae996dc65ca22ee9df4d/chrome/browser/chromeos/options/network_config_view.cc
[modify] https://crrev.com/b403d81b96c9dd5a244bae996dc65ca22ee9df4d/chrome/browser/chromeos/options/wifi_config_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b403d81b96c9dd5a244bae996dc65ca22ee9df4d

commit b403d81b96c9dd5a244bae996dc65ca22ee9df4d
Author: xdai <xdai@chromium.org>
Date: Wed Feb 15 18:50:54 2017

Put the new harmonized dialog implementation behind flag.

This CL does the following:
1) Put the harmony work behind the flag --secondary-ui-md so
   nothing is changed for pre-harmony dialogs.
2) Remove the padding to its right "eye" button.
3) For harmonized dialog, the size of the dialog is calculated by its
client view, not from the pre-determined values (as for pre-harmonized dialogs).

BUG= 680381 

Review-Url: https://codereview.chromium.org/2692403002
Cr-Commit-Position: refs/heads/master@{#450746}

[modify] https://crrev.com/b403d81b96c9dd5a244bae996dc65ca22ee9df4d/chrome/browser/chromeos/options/network_config_view.cc
[modify] https://crrev.com/b403d81b96c9dd5a244bae996dc65ca22ee9df4d/chrome/browser/chromeos/options/wifi_config_view.cc

It's been a while since this bug was updated.  Can we get a status update/quick re-summary of what this is about?  This bug isn't linked in my tracking spreadsheet, so I'm not 100% sure what it's tracking.

FWIW I am actively working on replacing these dialogs with Web UI (which will be harmonized with the rest of Settings when that occurs). I expect that to land in 62 so I would mark this as 'Fixed' or 'WontFix'.

Thanks Steven! I'll make it as 'WontFix' then.