New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 680363 link

Starred by 1 user
Status: Fixed
Owner:
█ romax@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 679822



Sign in to add a comment

Snapshotting on Timeout of Last Retry

Project Member Reported by romax@chromium.org, Jan 12 2017 
As is done currently, if we experience our RMD condition, complete the request. But if we do not experience that condition, then for the final attempt, if we get a timeout, instead of failing the request, try to snapshot/archive the current WebContents if we have seen a low bar RMD signal (e.g., DomContentLoaded or better) for that attempt.

Comment 1 by romax@chromium.org, Jan 26 2017

Blocking: 679822
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/250c4a05efdb4ec893d99ed7fe63236686caec4d

commit 250c4a05efdb4ec893d99ed7fe63236686caec4d
Author: romax <romax@chromium.org>
Date: Sat Feb 25 03:08:14 2017

[Offline Pages] Snapshotting on timeout of last retry.

Added the logic which would do a snapshot when the offliner times out
on the last retry, also it must meet the low bar for quality control.
As for now the low bar is to get DOMContentLoaded callback.

BUG= 680363 

Review-Url: https://codereview.chromium.org/2637563002
Cr-Commit-Position: refs/heads/master@{#453053}

[modify] https://crrev.com/250c4a05efdb4ec893d99ed7fe63236686caec4d/chrome/browser/android/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/250c4a05efdb4ec893d99ed7fe63236686caec4d/chrome/browser/android/offline_pages/background_loader_offliner.h
[modify] https://crrev.com/250c4a05efdb4ec893d99ed7fe63236686caec4d/chrome/browser/android/offline_pages/prerendering_loader.cc
[modify] https://crrev.com/250c4a05efdb4ec893d99ed7fe63236686caec4d/chrome/browser/android/offline_pages/prerendering_loader.h
[modify] https://crrev.com/250c4a05efdb4ec893d99ed7fe63236686caec4d/chrome/browser/android/offline_pages/prerendering_offliner.cc
[modify] https://crrev.com/250c4a05efdb4ec893d99ed7fe63236686caec4d/chrome/browser/android/offline_pages/prerendering_offliner.h
[modify] https://crrev.com/250c4a05efdb4ec893d99ed7fe63236686caec4d/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
[modify] https://crrev.com/250c4a05efdb4ec893d99ed7fe63236686caec4d/components/offline_pages/core/background/offliner.h
[modify] https://crrev.com/250c4a05efdb4ec893d99ed7fe63236686caec4d/components/offline_pages/core/background/offliner_stub.cc
[modify] https://crrev.com/250c4a05efdb4ec893d99ed7fe63236686caec4d/components/offline_pages/core/background/offliner_stub.h
[modify] https://crrev.com/250c4a05efdb4ec893d99ed7fe63236686caec4d/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/250c4a05efdb4ec893d99ed7fe63236686caec4d/components/offline_pages/core/background/request_coordinator_unittest.cc

Comment 3 by romax@chromium.org, Feb 28 2017

Status: Fixed (was: Started)
►

Sign in to add a comment