paygen stage tests modify the source tree. |
||
Issue descriptionThis unittest creates files in the chromite source tree when run: chromite/cbuildbot/stages/release_stages_unittest $git status On branch clean Your branch is up-to-date with 'cros/master'. Untracked files: (use "git add <file>..." to include in what will be committed) foo-finished_uri nothing added to commit but untracked files present (use "git add" to track)
,
Jan 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/127be91353563d705812a608ec7e344c443eed49 commit 127be91353563d705812a608ec7e344c443eed49 Author: Aseda Aboagye <aaboagye@google.com> Date: Thu Jan 12 19:01:24 2017 release_stages: Fixup PaygenTest stage naming. Recently, the Paygen stage was split up into substages: PaygenBuild and PaygenTest. In order to make things clearer on the waterfall, the channel of the payloads being generated was added to the stage name, however, for the PaygenTest stage, it had an extra suffix of '-channel'. This commit fixes that. The stage names should now be PaygenBuildFoo and PaygenTestFoo. Additionally, this commit also fixes the unit tests to prevent polluting the source directory with 'foo-build_uri' files as well as 'archive_build_uri' directory. BUG= chromium:680357 BUG= chromium:679225 BRANCH=None TEST=python cbuildbot/stages/release_stages_unittest TEST=python lib/paygen/paygen_build_lib_unittest TEST=python lib/paygen/paygen_build_lib_unittest --network Change-Id: I5513321bd056bf99bae10958dc2a67861127e443 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/427958 Commit-Ready: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/127be91353563d705812a608ec7e344c443eed49/cbuildbot/stages/release_stages_unittest.py [modify] https://crrev.com/127be91353563d705812a608ec7e344c443eed49/lib/paygen/paygen_build_lib_unittest.py [modify] https://crrev.com/127be91353563d705812a608ec7e344c443eed49/cbuildbot/stages/release_stages.py
,
Jan 17 2017
With that CL, there should be no more stale artifacts left in the source tree. Verified locally in CL. Feel free to re-open if you see this again. |
||
►
Sign in to add a comment |
||
Comment 1 by aaboagye@chromium.org
, Jan 12 2017