Issue metadata
Sign in to add a comment
|
Non-closable ARC notification is closable |
||||||||||||||||||
Issue descriptionOn ToT, non-closable ARC notification is closable. It should be non-closable. Note that the issue happens only on ARC notification and non-closable non-ARC notification is non-closable correctly.
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0993bc30936c72dfdd60ec7c15aacc1579756704 commit 0993bc30936c72dfdd60ec7c15aacc1579756704 Author: yoshiki <yoshiki@chromium.org> Date: Wed Jan 18 04:39:07 2017 Set slide_out_enabled property for CustomNotification The "slide_out_enabled" property of SlideOutView should be set according to the "pinned" property of notification. It was set for both CustomNotificationView and NotificationView correctly, but now the code has been moved to NotificationView after recent refactoring. This patch moves the code NotificationView to MessageView and fixes the regression. BUG= 680353 TEST=manually Review-Url: https://codereview.chromium.org/2620133003 Cr-Commit-Position: refs/heads/master@{#444275} [modify] https://crrev.com/0993bc30936c72dfdd60ec7c15aacc1579756704/ui/message_center/views/custom_notification_view_unittest.cc [modify] https://crrev.com/0993bc30936c72dfdd60ec7c15aacc1579756704/ui/message_center/views/message_view.cc [modify] https://crrev.com/0993bc30936c72dfdd60ec7c15aacc1579756704/ui/message_center/views/notification_view.cc
,
Jan 19 2017
,
Apr 6 2017
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by yoshiki@chromium.org
, Jan 12 2017