New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680347 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Clicking "XGB available" in Files apps should open the storage settings

Project Member Reported by weifangsun@chromium.org, Jan 12 2017

Issue description

In the Files App Settings menu, the storage indicator should be clickable and link to the Settings -> Device -> "Storage management" UI.
 

Comment 1 by fukino@chromium.org, Jan 12 2017

I like this feature!
I'm going to make it clickable when the active volume is Downloads.
For other volumes (e.g. Google Drive, SD card, etc..), I'll keep it unclickable.
pada666@live.ca

Comment 3 by fukino@chromium.org, Jan 17 2017

Cc: oka@chromium.org

Comment 4 by sashab@chromium.org, Feb 23 2018

Labels: CrOS-FilesApp-LowStorage
Owner: ----
Status: Unconfirmed (was: Assigned)

Comment 6 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-LowStorage CrOSFilesFeature-LowStorage

Comment 7 by noel@chromium.org, Mar 17 2018

Status: Available (was: Unconfirmed)
A feature request.

Comment 8 by loyso@chromium.org, Mar 28 2018

Labels: CrOSFilesCategory-UI
Status: Untriaged (was: Available)
Just a link to Storage page required - pure UI request.

Comment 9 by loyso@chromium.org, Mar 28 2018

Labels: Hotlist-GoodFirstBug

Comment 10 by loyso@chromium.org, Mar 29 2018

Owner: loyso@chromium.org
Status: Started (was: Untriaged)

Comment 11 by noel@chromium.org, Apr 4 2018

Is it a good first bug?
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bbcab8d9171a230449b76638c7f8bfe6771197e

commit 6bbcab8d9171a230449b76638c7f8bfe6771197e
Author: Alexey Baskakov <loyso@chromium.org>
Date: Tue Apr 10 05:55:33 2018

FilesApp: Open storage settings on "GB available" click in gear menu.

In the Files App Settings menu, the storage indicator should be clickable
and link to the Settings -> Device -> "Storage management" UI.

Bug:  680347 
Test: Manually tested
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3703b2d94852a3011e7e6d91b2afe010400795b5
Reviewed-on: https://chromium-review.googlesource.com/999240
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549431}
[modify] https://crrev.com/6bbcab8d9171a230449b76638c7f8bfe6771197e/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/6bbcab8d9171a230449b76638c7f8bfe6771197e/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h
[modify] https://crrev.com/6bbcab8d9171a230449b76638c7f8bfe6771197e/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/6bbcab8d9171a230449b76638c7f8bfe6771197e/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/6bbcab8d9171a230449b76638c7f8bfe6771197e/third_party/closure_compiler/externs/file_manager_private.js
[modify] https://crrev.com/6bbcab8d9171a230449b76638c7f8bfe6771197e/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/6bbcab8d9171a230449b76638c7f8bfe6771197e/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/6bbcab8d9171a230449b76638c7f8bfe6771197e/ui/file_manager/file_manager/foreground/js/gear_menu_controller.js
[modify] https://crrev.com/6bbcab8d9171a230449b76638c7f8bfe6771197e/ui/file_manager/file_manager/foreground/js/ui/files_menu.js
[modify] https://crrev.com/6bbcab8d9171a230449b76638c7f8bfe6771197e/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/6bbcab8d9171a230449b76638c7f8bfe6771197e/ui/file_manager/file_manager/test/js/chrome_file_manager.js

Comment 13 by loyso@chromium.org, Apr 10 2018

Status: Fixed (was: Started)
Labels: M-67

Sign in to add a comment