Issue 680345 link

Starred by 13 users

Issue metadata

Status:	Fixed
Owner:	dmazz...@chromium.org
Closed:	Jul 2017
Cc:	aboxhall@chromium.org dmazz...@chromium.org
Components:	Blink>Accessibility
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Task

Team-Accessibility

Blocking:
issue 746523

Show other hotlists

Hotlists containing this issue:
Hotlist-1

Implement Accessibility Object Model Phase 1

Project Member Reported by aboxhall@chromium.org, Jan 12 2017

Issue description

This effort aims to create a JavaScript API to allow developers to modify (and eventually explore) the accessibility tree for an HTML page.

*Phase 1*

Add an `accessibleNode` property to `Node`, with the type `AccessibleNode`.
The `AccessibleNode` interface allows accessible properties for a particular `Node` to be programmatically overridden.

See https://github.com/WICG/aom/blob/master/explainer.md for more detail.

Comment 1 by dmazz...@chromium.org, Mar 27 2017

Labels: NewComponent-Accessibility-Blink NewComponent-Accessibility

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59b48ec0a88a1716bd4b39b2ac2d3021458749f4

commit 59b48ec0a88a1716bd4b39b2ac2d3021458749f4
Author: dmazzoni <dmazzoni@chromium.org>
Date: Thu Mar 30 05:13:38 2017

Initial skeleton of Accessibility Object Model Phase 1

Explainer: https://github.com/WICG/aom/blob/master/explainer.md
Spec: https://wicg.github.io/aom/spec/

This change adds an accessibleNode getter on Element, and implements
the role and label properties of AccessibleNode, including a LayoutTest
of the supported functionality.

Properties on an AccessibleNode are stored in a map for efficiency
since there are dozens of possible properties and few will need to be
set on any one particular object.

In existing accessibility code, places where we previously retrieve an
ARIA attribute are replaced with a new wrapper that first checks the
ARIA attribute and then checks the equivalent AOM property.

Once this change lands it should be relatively straightforward to implement
the rest of the properties of AccessibleNode and complete Phase 1.

BUG= 680345 

Review-Url: https://codereview.chromium.org/2750533006
Cr-Commit-Position: refs/heads/master@{#460670}

[add] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/LayoutTests/accessibility/aom.html
[modify] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/core/core_idl_files.gni
[add] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/core/dom/AccessibleNode.cpp
[add] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/core/dom/AccessibleNode.h
[add] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/core/dom/AccessibleNode.idl
[modify] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/core/dom/Element.idl
[modify] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/core/dom/ElementRareData.cpp
[modify] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/core/dom/ElementRareData.h
[modify] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/59b48ec0a88a1716bd4b39b2ac2d3021458749f4/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0

commit 71e44249f1bddfa5cfe90041b4b4cf497f39ecc0
Author: wfh <wfh@chromium.org>
Date: Sat Apr 01 23:32:36 2017

Revert of Initial skeleton of Accessibility Object Model Phase 1 (patchset #9 id:160001 of https://codereview.chromium.org/2750533006/ )

Reason for revert:
major renderer on Canary see crbug.com/707218

Original issue's description:
> Initial skeleton of Accessibility Object Model Phase 1
>
> Explainer: https://github.com/WICG/aom/blob/master/explainer.md
> Spec: https://wicg.github.io/aom/spec/
>
> This change adds an accessibleNode getter on Element, and implements
> the role and label properties of AccessibleNode, including a LayoutTest
> of the supported functionality.
>
> Properties on an AccessibleNode are stored in a map for efficiency
> since there are dozens of possible properties and few will need to be
> set on any one particular object.
>
> In existing accessibility code, places where we previously retrieve an
> ARIA attribute are replaced with a new wrapper that first checks the
> ARIA attribute and then checks the equivalent AOM property.
>
> Once this change lands it should be relatively straightforward to implement
> the rest of the properties of AccessibleNode and complete Phase 1.
>
> BUG= 680345 
>
> Review-Url: https://codereview.chromium.org/2750533006
> Cr-Commit-Position: refs/heads/master@{#460670}
> Committed: https://chromium.googlesource.com/chromium/src/+/59b48ec0a88a1716bd4b39b2ac2d3021458749f4

TBR=esprehn@chromium.org,aboxhall@chromium.org,haraken@chromium.org,dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 680345 ,707218

Review-Url: https://codereview.chromium.org/2796553002
Cr-Commit-Position: refs/heads/master@{#461332}

[delete] https://crrev.com/1bff079d86046751b67c4e45c7a85fa0df56bfc9/third_party/WebKit/LayoutTests/accessibility/aom.html
[modify] https://crrev.com/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0/third_party/WebKit/Source/core/core_idl_files.gni
[delete] https://crrev.com/1bff079d86046751b67c4e45c7a85fa0df56bfc9/third_party/WebKit/Source/core/dom/AccessibleNode.cpp
[delete] https://crrev.com/1bff079d86046751b67c4e45c7a85fa0df56bfc9/third_party/WebKit/Source/core/dom/AccessibleNode.h
[delete] https://crrev.com/1bff079d86046751b67c4e45c7a85fa0df56bfc9/third_party/WebKit/Source/core/dom/AccessibleNode.idl
[modify] https://crrev.com/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0/third_party/WebKit/Source/core/dom/Element.idl
[modify] https://crrev.com/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0/third_party/WebKit/Source/core/dom/ElementRareData.cpp
[modify] https://crrev.com/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0/third_party/WebKit/Source/core/dom/ElementRareData.h
[modify] https://crrev.com/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46fca1f2e467228e197bb0c792450ad54667bd5e

commit 46fca1f2e467228e197bb0c792450ad54667bd5e
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Apr 03 15:36:59 2017

Re-land: Initial skeleton of Accessibility Object Model Phase 1

Landed: r460670   - https://codereview.chromium.org/2750533006/
Reverted: r461332 - https://codereview.chromium.org/2796553002

See the diff between patch set 1 and patch set 2 for the fix to the crash
that the initial patch caused.

Explainer: https://github.com/WICG/aom/blob/master/explainer.md
Spec: https://wicg.github.io/aom/spec/

This change adds an accessibleNode getter on Element, and implements
the role and label properties of AccessibleNode, including a LayoutTest
of the supported functionality.

Properties on an AccessibleNode are stored in a map for efficiency
since there are dozens of possible properties and few will need to be
set on any one particular object.

In existing accessibility code, places where we previously retrieve an
ARIA attribute are replaced with a new wrapper that first checks the
ARIA attribute and then checks the equivalent AOM property.

Once this change lands it should be relatively straightforward to implement
the rest of the properties of AccessibleNode and complete Phase 1.

BUG= 680345 ,707218
TBR=haraken,aboxhall,esprehn

Review-Url: https://codereview.chromium.org/2791943002
Cr-Commit-Position: refs/heads/master@{#461438}

[add] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/LayoutTests/accessibility/aom.html
[add] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/LayoutTests/accessibility/document-element-display-none-crash.html
[modify] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/core/core_idl_files.gni
[add] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/core/dom/AccessibleNode.cpp
[add] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/core/dom/AccessibleNode.h
[add] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/core/dom/AccessibleNode.idl
[modify] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/core/dom/Element.idl
[modify] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/core/dom/ElementRareData.cpp
[modify] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/core/dom/ElementRareData.h
[modify] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/46fca1f2e467228e197bb0c792450ad54667bd5e/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2

commit e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Apr 04 20:38:06 2017

Finish all string attributes for Accessibility Object Model Phase 1.

This is a pretty mechanical change. Next will come attributes of different
types.

BUG= 680345 

Review-Url: https://codereview.chromium.org/2788523002
Cr-Commit-Position: refs/heads/master@{#461820}

[modify] https://crrev.com/e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2/content/shell/test_runner/web_ax_object_proxy.h
[add] https://crrev.com/e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html
[modify] https://crrev.com/e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2/third_party/WebKit/Source/core/dom/AccessibleNode.cpp
[modify] https://crrev.com/e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2/third_party/WebKit/Source/core/dom/AccessibleNode.h
[modify] https://crrev.com/e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2/third_party/WebKit/Source/core/dom/AccessibleNode.idl
[modify] https://crrev.com/e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp
[modify] https://crrev.com/e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2/third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43c5f09a24e0f27ffa1009917405123e2844d747

commit 43c5f09a24e0f27ffa1009917405123e2844d747
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Apr 05 04:41:38 2017

Add Accessibility Object Model to content features, and add a browser test.

More tests at the content layer will follow, this just sets up the
infrastructure for future tests.

BUG= 680345 
TEST=Run Chrome with --enable-features=AccessibilityObjectModel, print document.body.accessibleNode in Inspector

Review-Url: https://codereview.chromium.org/2787843003
Cr-Commit-Position: refs/heads/master@{#461978}

[modify] https://crrev.com/43c5f09a24e0f27ffa1009917405123e2844d747/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/43c5f09a24e0f27ffa1009917405123e2844d747/content/child/runtime_features.cc
[modify] https://crrev.com/43c5f09a24e0f27ffa1009917405123e2844d747/content/public/common/content_features.cc
[modify] https://crrev.com/43c5f09a24e0f27ffa1009917405123e2844d747/content/public/common/content_features.h
[add] https://crrev.com/43c5f09a24e0f27ffa1009917405123e2844d747/content/test/data/accessibility/aom/aom-checked-expected-android.txt
[add] https://crrev.com/43c5f09a24e0f27ffa1009917405123e2844d747/content/test/data/accessibility/aom/aom-checked-expected-blink.txt
[add] https://crrev.com/43c5f09a24e0f27ffa1009917405123e2844d747/content/test/data/accessibility/aom/aom-checked-expected-mac.txt
[add] https://crrev.com/43c5f09a24e0f27ffa1009917405123e2844d747/content/test/data/accessibility/aom/aom-checked-expected-win.txt
[add] https://crrev.com/43c5f09a24e0f27ffa1009917405123e2844d747/content/test/data/accessibility/aom/aom-checked.html
[modify] https://crrev.com/43c5f09a24e0f27ffa1009917405123e2844d747/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/43c5f09a24e0f27ffa1009917405123e2844d747/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/43c5f09a24e0f27ffa1009917405123e2844d747/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/43c5f09a24e0f27ffa1009917405123e2844d747/third_party/WebKit/public/web/WebRuntimeFeatures.h

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45494c0941e362c28b04b92f237c759f8c960794

commit 45494c0941e362c28b04b92f237c759f8c960794
Author: dmazzoni <dmazzoni@chromium.org>
Date: Fri Apr 21 06:36:30 2017

Port some AOM tests from LayoutTests to SimTests.

BUG= 680345 

Review-Url: https://codereview.chromium.org/2823163002
Cr-Commit-Position: refs/heads/master@{#466272}

[modify] https://crrev.com/45494c0941e362c28b04b92f237c759f8c960794/third_party/WebKit/Source/platform/testing/RuntimeEnabledFeaturesTestHelpers.h
[modify] https://crrev.com/45494c0941e362c28b04b92f237c759f8c960794/third_party/WebKit/Source/web/BUILD.gn
[add] https://crrev.com/45494c0941e362c28b04b92f237c759f8c960794/third_party/WebKit/Source/web/tests/AccessibilityObjectModelTest.cpp

Comment 8 by dmazz...@chromium.org, Apr 21 2017

Components: Blink>Accessibility

Comment 9 by dmazz...@chromium.org, Apr 21 2017

Components: -UI>Accessibility
Labels: -newcomponent-accessibility-blink -newcomponent-accessibility

Project Member

Comment 10 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08edc3874e15741c0fadbce986ae55b42db3161f

commit 08edc3874e15741c0fadbce986ae55b42db3161f
Author: dmazzoni <dmazzoni@chromium.org>
Date: Fri May 05 18:51:12 2017

Remove content flag for Accessibility Object Model

Use the blink-enabled-features command-line flag to enable it
instead, it's simpler.

BUG= 680345 

Review-Url: https://codereview.chromium.org/2859333002
Cr-Commit-Position: refs/heads/master@{#469737}

[modify] https://crrev.com/08edc3874e15741c0fadbce986ae55b42db3161f/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/08edc3874e15741c0fadbce986ae55b42db3161f/content/child/runtime_features.cc
[modify] https://crrev.com/08edc3874e15741c0fadbce986ae55b42db3161f/content/public/common/content_features.cc
[modify] https://crrev.com/08edc3874e15741c0fadbce986ae55b42db3161f/content/public/common/content_features.h
[modify] https://crrev.com/08edc3874e15741c0fadbce986ae55b42db3161f/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/08edc3874e15741c0fadbce986ae55b42db3161f/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/08edc3874e15741c0fadbce986ae55b42db3161f/third_party/WebKit/public/web/WebRuntimeFeatures.h

Project Member

Comment 11 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c140ef12a0591bc5b770c97b1b23d6c83a49fb20

commit c140ef12a0591bc5b770c97b1b23d6c83a49fb20
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed May 10 07:34:01 2017

Accessibility Object Model: remove reflection

Based on the latest consensus
(https://github.com/WICG/aom/pull/75),
AOM properties override ARIA attributes,
with no reflection.

BUG= 680345 

Review-Url: https://codereview.chromium.org/2864493005
Cr-Commit-Position: refs/heads/master@{#470513}

[modify] https://crrev.com/c140ef12a0591bc5b770c97b1b23d6c83a49fb20/third_party/WebKit/LayoutTests/accessibility/aom.html
[modify] https://crrev.com/c140ef12a0591bc5b770c97b1b23d6c83a49fb20/third_party/WebKit/Source/core/dom/AccessibleNode.cpp
[modify] https://crrev.com/c140ef12a0591bc5b770c97b1b23d6c83a49fb20/third_party/WebKit/Source/core/dom/AccessibleNode.h
[modify] https://crrev.com/c140ef12a0591bc5b770c97b1b23d6c83a49fb20/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/596baeaaa2a5632f606a226ebdf898272cd4284d

commit 596baeaaa2a5632f606a226ebdf898272cd4284d
Author: dmazzoni <dmazzoni@chromium.org>
Date: Thu May 18 03:28:32 2017

Boolean properties for Accessibility Object Model Phase 1

BUG= 680345 

Review-Url: https://codereview.chromium.org/2805493002
Cr-Commit-Position: refs/heads/master@{#472634}

[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/content/shell/test_runner/web_ax_object_proxy.h
[add] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/LayoutTests/accessibility/aom-boolean-properties.html
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/core/dom/AccessibleNode.cpp
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/core/dom/AccessibleNode.h
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/core/dom/AccessibleNode.idl
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.h
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/modules/accessibility/AXRadioInput.cpp
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/modules/accessibility/AXRadioInput.h
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/modules/accessibility/AXSlider.cpp
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/modules/accessibility/AXSlider.h
[modify] https://crrev.com/596baeaaa2a5632f606a226ebdf898272cd4284d/third_party/WebKit/Source/web/tests/AccessibilityObjectModelTest.cpp

Project Member

Comment 13 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a2243c09c7513d55bde53ceeae0ea89a8334e79

commit 0a2243c09c7513d55bde53ceeae0ea89a8334e79
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue May 23 18:43:39 2017

Int and Float properties for Accessibility Object Model phase 1

BUG= 680345 

Review-Url: https://codereview.chromium.org/2894103002
Cr-Commit-Position: refs/heads/master@{#473999}

[add] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/LayoutTests/accessibility/aom-float-properties.html
[add] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/LayoutTests/accessibility/aom-int-properties.html
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/Source/core/dom/AccessibleNode.cpp
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/Source/core/dom/AccessibleNode.h
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/Source/core/dom/AccessibleNode.idl
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/Source/modules/accessibility/AXRadioInput.cpp
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/Source/modules/accessibility/AXTable.cpp
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/Source/modules/accessibility/AXTableCell.h
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp
[modify] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/third_party/WebKit/Source/web/tests/AccessibilityObjectModelTest.cpp

Comment 14 by tkent@chromium.org, Jun 4 2017

Components: -Blink>DOM

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b

commit f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b
Author: dmazzoni <dmazzoni@chromium.org>
Date: Thu Jun 22 17:25:06 2017

Relation properties for Accessibility Object Model phase 1

This change implements AOM support for activeDescendant,
details, and errorMessage. The corresponding ARIA attributes
all take IDREFs, and the AOM properties all take references
to AccessibleNodes instead.

This patch finally creates a clean solution for sparse
attribute support: when asked to retrieve sparse attributes
for an AXObject, we first get all AOM properties, and we
also get a list of corresponding ARIA attributes. Then we
iterate over the Element attributes and check for ARIA
attributes, skipping any that were shadowed by AOM
attributes.

BUG= 680345 

Review-Url: https://codereview.chromium.org/2945773002
Cr-Commit-Position: refs/heads/master@{#481580}

[modify] https://crrev.com/f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b/content/shell/test_runner/web_ax_object_proxy.h
[add] https://crrev.com/f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b/third_party/WebKit/LayoutTests/accessibility/aom-relation-properties.html
[modify] https://crrev.com/f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b/third_party/WebKit/Source/core/dom/AccessibleNode.cpp
[modify] https://crrev.com/f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b/third_party/WebKit/Source/core/dom/AccessibleNode.h
[modify] https://crrev.com/f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b/third_party/WebKit/Source/core/dom/AccessibleNode.idl
[modify] https://crrev.com/f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b/third_party/WebKit/Source/web/tests/AccessibilityObjectModelTest.cpp

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ae8387e4e3efa43990288217ed2f042c78a8dd8

commit 0ae8387e4e3efa43990288217ed2f042c78a8dd8
Author: dmazzoni <dmazzoni@chromium.org>
Date: Fri Jul 07 16:32:26 2017

Relation list properties for Accessibility Object Model phase 1

This change implements AOM support for controls, describedBy,
flowTo, labeledBy, and owns. The corresponding ARIA attributes
all take lists of IDREFs, and the AOM properties all take references
to AccessibleNodeLists instead.

BUG= 680345 

Review-Url: https://codereview.chromium.org/2967193003
Cr-Commit-Position: refs/heads/master@{#484950}

[add] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/LayoutTests/accessibility/aom-relation-list-properties.html
[modify] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/Source/core/dom/AccessibleNode.cpp
[modify] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/Source/core/dom/AccessibleNode.h
[modify] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/Source/core/dom/AccessibleNode.idl
[add] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/Source/core/dom/AccessibleNodeList.cpp
[add] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/Source/core/dom/AccessibleNodeList.h
[add] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/Source/core/dom/AccessibleNodeList.idl
[modify] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[modify] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/0ae8387e4e3efa43990288217ed2f042c78a8dd8/third_party/WebKit/Source/web/tests/AccessibilityObjectModelTest.cpp

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb

commit fee38fe5d637a5f0ea3d06708ec12a9981fce6bb
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Jul 19 06:38:43 2017

Implement AccessibleNode.hasPopUp for Accessibility Object Model phase 1

This is the last AOM phase 1 property! I missed it earlier because it used
to be a boolean attribute but in ARIA 1.1 it was changed to a string.
This change just hooks up the AOM portion, but I filed  bug 740137  to
track plumbing through the string value of haspopup rahter than treating
it as a boolean elsewhere.

BUG= 680345 , 740137 

Review-Url: https://codereview.chromium.org/2973973002
Cr-Commit-Position: refs/heads/master@{#487773}

[modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html
[modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/Source/core/dom/AccessibleNode.cpp
[modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/Source/core/dom/AccessibleNode.h
[modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/Source/core/dom/AccessibleNode.idl
[modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

Comment 18 by dmazz...@chromium.org, Jul 19 2017

Labels: -Type-Launch-OWP Type-Task

Changing this to a Task rather than a Launch bug

Comment 19 by dmazz...@chromium.org, Jul 19 2017

Blocking: 746523

Comment 20 by dmazz...@chromium.org, Jul 19 2017

Status: Fixed (was: Started)

Initial implementation of Phase 1 is done.

Comment 21 by jakkapan...@gmail.com, Sep 16

btsnoop_hci.log
5.5 KB View Download

►

Issue 680345 link

Issue metadata

Implement Accessibility Object Model Phase 1

Issue description

Comment 1 by dmazz...@chromium.org, Mar 27 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Mar 30 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Apr 1 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Apr 3 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Apr 4 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Apr 5 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Apr 21 2017

Comment 7 Deleted

Comment 8 by dmazz...@chromium.org, Apr 21 2017

Comment 8 Deleted

Comment 9 by dmazz...@chromium.org, Apr 21 2017

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, May 5 2017

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, May 10 2017

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, May 18 2017

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, May 23 2017

Comment 13 Deleted

Comment 14 by tkent@chromium.org, Jun 4 2017

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Jun 22 2017

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Jul 7 2017

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Jul 19 2017

Comment 17 Deleted

Comment 18 by dmazz...@chromium.org, Jul 19 2017

Comment 18 Deleted

Comment 19 by dmazz...@chromium.org, Jul 19 2017

Comment 19 Deleted

Comment 20 by dmazz...@chromium.org, Jul 19 2017

Comment 20 Deleted

Comment 21 by jakkapan...@gmail.com, Sep 16

Comment 21 Deleted

Sign in to add a comment