New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 680343 link

Starred by 1 user
Status: Fixed
Owner:
lukasza@chromium.org
Closed: Jan 2017
Cc:
█ nasko@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 582312



Sign in to add a comment

rewrite_to_chrome_style: Don't rename anything under blink::protocol namespace

Project Member Reported by lukasza@chromium.org, Jan 12 2017 
We should be skipping generated files, so we should be skipping most of blink::protocol namespace (i.e.  https://crbug.com/677223#c6  is not applicable *yet*), but nasko@ found some cases where non-generated code should also be skipped.  Opening this bug to track this.

Comment 1 by lukasza@chromium.org, Jan 12 2017

Cc: -lukasza@chromium.org
Owner: lukasza@chromium.org
Status: Started (was: Available)
An example that nasko@ found is that the protocol code generator assumes that non-generated code in ...::protocol namespace will expose things with specific names (which shouldn't be changed).  Example:

gen/blink/core/inspector/protocol/Protocol.h will refer blink::protocol::StringUtil from third_party/WebKit/Source/core/inspector/V8InspectorString.h.  We cannot rename blink::protocol::StringUtil::fromInteger without also doing a similar rename in content::protocol::StringUtil and other ...::protocol namespaces.

Comment 2 by lukasza@chromium.org, Jan 13 2017

Status: Fixed (was: Started)
►

Sign in to add a comment