New issue
Advanced search Search tips

Issue 680330 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 7
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-01-31
OS: All
Pri: 2
Type: Bug

Blocked on: View detail
issue 717276
issue 736253



Sign in to add a comment

Use pointerActionSequence in pointer events web-platform tests

Project Member Reported by lanwei@chromium.org, Jan 12 2017

Issue description

Now we have a new API pointerActionSequence in GpuBenchmarking, which can simulate a sequence of low level pointer actions, such as press, move and release for mouse, touch and pen. We will replace the actions in pointer events web-platform tests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11b24cf16bcfe02c4d881af965330ddfe72e7a64

commit 11b24cf16bcfe02c4d881af965330ddfe72e7a64
Author: lanwei <lanwei@chromium.org>
Date: Tue Jan 17 18:31:02 2017

Replace touch actions in pointer event tests with pointerActionSequence

Replace touchScrollInTarget and pinchZoomInTarget in pointerevent_common_input.js
with pointerActionSequence.

BUG= 680330 

Review-Url: https://codereview.chromium.org/2627463002
Cr-Commit-Position: refs/heads/master@{#444096}

[modify] https://crrev.com/11b24cf16bcfe02c4d881af965330ddfe72e7a64/content/browser/renderer_host/input/synthetic_touch_driver.cc
[modify] https://crrev.com/11b24cf16bcfe02c4d881af965330ddfe72e7a64/content/renderer/gpu/actions_parser.cc
[modify] https://crrev.com/11b24cf16bcfe02c4d881af965330ddfe72e7a64/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/988a23455eeee97b2611a4400f6716db1cc5c9c1

commit 988a23455eeee97b2611a4400f6716db1cc5c9c1
Author: lanwei <lanwei@chromium.org>
Date: Wed Jan 18 21:42:14 2017

Support multi-button press for synthetic mouse events

SyntheticWebMouseEventBuilder::Build now only supports left button press. In order to
simulate multi-button press, we keep all the pressed buttons in SyntheticMouseDriver.

This is separated from https://codereview.chromium.org/2621353003, which will replace
mouse actions in pointer event tests with pointerActionSequence.

BUG= 680330 

Review-Url: https://codereview.chromium.org/2634183002
Cr-Commit-Position: refs/heads/master@{#444493}

[modify] https://crrev.com/988a23455eeee97b2611a4400f6716db1cc5c9c1/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc
[modify] https://crrev.com/988a23455eeee97b2611a4400f6716db1cc5c9c1/content/browser/renderer_host/input/synthetic_mouse_driver.cc
[modify] https://crrev.com/988a23455eeee97b2611a4400f6716db1cc5c9c1/content/browser/renderer_host/input/synthetic_mouse_driver.h
[modify] https://crrev.com/988a23455eeee97b2611a4400f6716db1cc5c9c1/content/browser/renderer_host/input/synthetic_pointer_action.cc
[modify] https://crrev.com/988a23455eeee97b2611a4400f6716db1cc5c9c1/content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
[modify] https://crrev.com/988a23455eeee97b2611a4400f6716db1cc5c9c1/content/browser/renderer_host/input/synthetic_pointer_driver.h
[modify] https://crrev.com/988a23455eeee97b2611a4400f6716db1cc5c9c1/content/browser/renderer_host/input/synthetic_touch_driver.cc
[modify] https://crrev.com/988a23455eeee97b2611a4400f6716db1cc5c9c1/content/browser/renderer_host/input/synthetic_touch_driver.h
[modify] https://crrev.com/988a23455eeee97b2611a4400f6716db1cc5c9c1/content/common/input/synthetic_pointer_action_params.cc
[modify] https://crrev.com/988a23455eeee97b2611a4400f6716db1cc5c9c1/content/common/input/synthetic_pointer_action_params.h
[modify] https://crrev.com/988a23455eeee97b2611a4400f6716db1cc5c9c1/content/common/input/synthetic_web_input_event_builders.cc
[modify] https://crrev.com/988a23455eeee97b2611a4400f6716db1cc5c9c1/content/common/input_messages.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7de40d188cb377011ad81c9b82b814752c9124a

commit d7de40d188cb377011ad81c9b82b814752c9124a
Author: lanwei <lanwei@chromium.org>
Date: Thu Jan 26 22:52:19 2017

Add the source type of pen to the synthetic WebMousEvent

SyntheticWebMouseEventBuilder::Build now only supports pointer type of mouse. In order to
simulate actions for pen devices, we will add the pointer type of pen to the synthetic WebMousEvent.

The next patch will replace pen actions in pointer event tests with pointerActionSequence API.

BUG= 680330 

Review-Url: https://codereview.chromium.org/2633233002
Cr-Commit-Position: refs/heads/master@{#446479}

[modify] https://crrev.com/d7de40d188cb377011ad81c9b82b814752c9124a/content/browser/BUILD.gn
[modify] https://crrev.com/d7de40d188cb377011ad81c9b82b814752c9124a/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc
[modify] https://crrev.com/d7de40d188cb377011ad81c9b82b814752c9124a/content/browser/renderer_host/input/synthetic_mouse_driver.cc
[modify] https://crrev.com/d7de40d188cb377011ad81c9b82b814752c9124a/content/browser/renderer_host/input/synthetic_mouse_driver.h
[add] https://crrev.com/d7de40d188cb377011ad81c9b82b814752c9124a/content/browser/renderer_host/input/synthetic_pen_driver.cc
[add] https://crrev.com/d7de40d188cb377011ad81c9b82b814752c9124a/content/browser/renderer_host/input/synthetic_pen_driver.h
[modify] https://crrev.com/d7de40d188cb377011ad81c9b82b814752c9124a/content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
[modify] https://crrev.com/d7de40d188cb377011ad81c9b82b814752c9124a/content/browser/renderer_host/input/synthetic_pointer_driver.cc
[modify] https://crrev.com/d7de40d188cb377011ad81c9b82b814752c9124a/content/common/input/synthetic_gesture_params.h
[modify] https://crrev.com/d7de40d188cb377011ad81c9b82b814752c9124a/content/common/input/synthetic_web_input_event_builders.cc
[modify] https://crrev.com/d7de40d188cb377011ad81c9b82b814752c9124a/content/common/input/synthetic_web_input_event_builders.h

Blockedon: 717276

Comment 7 by yosin@chromium.org, Jun 23 2017

Blockedon: 736253
Status: Fixed (was: Assigned)
I believe we don't need this meta bug anymore as we are also moving to use ChromeDriver and testdriver.

Sign in to add a comment