New issue
Advanced search Search tips

Issue 680325 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SPv2 applies control clip and svg viewport clip always, but spv1 does not.

Project Member Reported by chrishtr@chromium.org, Jan 12 2017

Issue description

See above.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4180b2e34325e450db3d4feb3c09b58ced38e98a

commit 4180b2e34325e450db3d4feb3c09b58ced38e98a
Author: chrishtr <chrishtr@chromium.org>
Date: Sat Jan 14 23:50:26 2017

Apply SVG viewport clips in PaintLayer; paint background of replaced like boxes.

This patch:

1. Starts painting the background of LayoutReplaced elements in the background
phase, rather than the foreground phase. This makes them behave like other boxes.

2. Because of 1, we can now treat overflow clips that apply to replaced elements
like other overflow clips; in particular this applies to SVG root viewport clips.
Now these clips are applied in PaintLayer for self-painting PaintLayer SVG
root elements, and BoxClipper otherwise clips them.

3. Replaced outlines already paint in the outline phase; removed unneeded
code in SVGRootPainter related to that.

BUG= 680325 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2624383002
Cr-Commit-Position: refs/heads/master@{#443804}

[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-inner-bleed-expected.png
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/linux/http/tests/misc/slow-loading-image-in-pattern-expected.txt
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/linux/svg/custom/mouse-move-on-svg-container-standalone-expected.txt
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/linux/svg/custom/mouse-move-on-svg-root-standalone-expected.txt
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/linux/svg/hixie/perf/007-expected.png
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/linux/svg/hixie/viewbox/preserveAspectRatio/001-expected.png
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-inner-bleed-expected.png
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.txt
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/mac/svg/hixie/perf/007-expected.png
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.png
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-inner-bleed-expected.png
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/win/http/tests/misc/slow-loading-image-in-pattern-expected.txt
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/win/svg/hixie/perf/007-expected.png
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/platform/win/svg/hixie/viewbox/preserveAspectRatio/001-expected.png
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/svg/custom/viewport-update2-expected.txt
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/svg/custom/width-full-percentage-expected.png
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/svg/filters/svg-filter-child-box-reflect.html
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/LayoutTests/svg/filters/svg-filter-root-box-reflect.html
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/Source/core/paint/BoxClipper.cpp
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/Source/core/paint/ReplacedPainter.cpp
[modify] https://crrev.com/4180b2e34325e450db3d4feb3c09b58ced38e98a/third_party/WebKit/Source/core/paint/SVGRootPainter.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c965b0a6c809d743226a8604329e76b28456526

commit 6c965b0a6c809d743226a8604329e76b28456526
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Sun Jan 15 00:37:32 2017

Auto-rebaseline for r443804

https://chromium.googlesource.com/chromium/src/+/4180b2e34325e

BUG= 680325 
TBR=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2632893003 .
Cr-Commit-Position: refs/heads/master@{#443806}

[modify] https://crrev.com/6c965b0a6c809d743226a8604329e76b28456526/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6c965b0a6c809d743226a8604329e76b28456526/third_party/WebKit/LayoutTests/platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt
[modify] https://crrev.com/6c965b0a6c809d743226a8604329e76b28456526/third_party/WebKit/LayoutTests/platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt
[modify] https://crrev.com/6c965b0a6c809d743226a8604329e76b28456526/third_party/WebKit/LayoutTests/platform/mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt
[modify] https://crrev.com/6c965b0a6c809d743226a8604329e76b28456526/third_party/WebKit/LayoutTests/platform/win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt
[modify] https://crrev.com/6c965b0a6c809d743226a8604329e76b28456526/third_party/WebKit/LayoutTests/platform/win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt
[modify] https://crrev.com/6c965b0a6c809d743226a8604329e76b28456526/third_party/WebKit/LayoutTests/platform/win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt

Sign in to add a comment