New issue
Advanced search Search tips

Issue 680307 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

http/tests/security/mixedContent/blob-url-in-iframe.html is failing on Site Isolation bots

Project Member Reported by alex...@chromium.org, Jan 11 2017

Issue description

This test has been failing fairly consistently on the Site Isolation bots since https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/13302.

There were also couple of flaky runs, according to
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=http%2Ftests%2Fsecurity%2FmixedContent%2Fblob-url-in-iframe.html

Text diff:
 --------
 Frame: '<!--framePath //<!--frame0-->-->'
 --------
-PASS (1/1)
+

None of the CLs in the blamelist look particularly suspicious, so not sure what caused this to regress, but looks like some sort of race in the test when OOPIFs are enabled.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96557bfa11c102628943935e7906cff4b3b04a74

commit 96557bfa11c102628943935e7906cff4b3b04a74
Author: alexmos <alexmos@chromium.org>
Date: Thu Jan 12 00:14:49 2017

Add expectations for three layout tests failing on Site Isolation bots.

This should hopefully get the bots back to green while individual bugs
are being investigated.

BUG= 680201 ,  661725 ,  680249 ,  680307 
NOTRY=true

Review-Url: https://codereview.chromium.org/2625233002
Cr-Commit-Position: refs/heads/master@{#443071}

[modify] https://crrev.com/96557bfa11c102628943935e7906cff4b3b04a74/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b51a81e48c43becbb456ff0f0820abd950ac2834

commit b51a81e48c43becbb456ff0f0820abd950ac2834
Author: Alex Moshchuk <alexmos@chromium.org>
Date: Thu Jul 20 17:46:53 2017

Re-enable --site-per-process layout tests that have healed themselves.

NOTRY=true

Bug:  710098 ,  623268 ,  623210 ,  680307 
Change-Id: I3b086fb6310ba8216cbade6cae6de08e689d460d
Reviewed-on: https://chromium-review.googlesource.com/579891
Reviewed-by: Lukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488295}
[modify] https://crrev.com/b51a81e48c43becbb456ff0f0820abd950ac2834/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Cc: -alex...@chromium.org
Owner: alex...@chromium.org
Status: Fixed (was: Available)
This test ended up healing, so I'll close this for now.  Let's reopen this if the test starts failing again.

Sign in to add a comment