New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680291 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 713335



Sign in to add a comment

Scrub dead code from MSE perf test utility startup_test.js

Project Member Reported by wolenetz@chromium.org, Jan 11 2017

Issue description

It looks like there's some dead code in startup_test.js (in usage, appendSize is constant, and there's no longer any implementation in Chrome of SourceBuffer.appendStream() or (really ancient spec's) SourceBuffer.append() -- just SourceBuffer.appendBuffer()). 

There's probably more lurking that could use cleanup.
 
crouleau@/watk@ : is it worth removing dead code piecemeal from these mse perf case files, or is there some larger test rework planned that would subsume these?

Comment 2 by w...@chromium.org, Jan 11 2017

We have no plans to change the actual test logic, so these wouldn't automatically roll into a separate change/refactor. But someone will be looking at the metrics recording part of startup_time.html at some point, to migrate it to chrome tracing instead of javascript timing.
As Chris is saying above, this will roll into "Migrate media.tough_media_cases and media.mse_cases legacy metrics to TBMv2"

I think this bug is useful to have around. If anyone wants to fix it before we get to that actual OKR, then that would be useful anyway as well.
Blocking: 713335
Owner: crouleau@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0456d30b6f06ddce8481401efaa6d98f59210780

commit 0456d30b6f06ddce8481401efaa6d98f59210780
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Mon Oct 09 20:06:58 2017

Media Telemetry: Remove dead code from mse_cases.

The appendStream test cases have not been producing any output
for some time
(Since appendStream() doesn't exist anymore). And append()
was deleted long
ago in favor of appendBuffer(), so this change should have
no impact on the
output. (And my tests show that it doesn't).

Bug:  680291 
Change-Id: If28221f87d6fe7dca37bfc34ac31755e40212131
Reviewed-on: https://chromium-review.googlesource.com/705927
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507465}
[modify] https://crrev.com/0456d30b6f06ddce8481401efaa6d98f59210780/tools/perf/page_sets/mse_cases.py
[modify] https://crrev.com/0456d30b6f06ddce8481401efaa6d98f59210780/tools/perf/page_sets/mse_cases/startup_test.html
[modify] https://crrev.com/0456d30b6f06ddce8481401efaa6d98f59210780/tools/perf/page_sets/mse_cases/startup_test.js

Status: Fixed (was: Assigned)

Sign in to add a comment