New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680251 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 621715



Sign in to add a comment

flashrom: Make new test script POSIX-compliant

Reported by dhend...@chromium.org, Jan 11 2017

Issue description

The new test scripts (test_v2.sh and friends) was developed on/for Goobuntu and CrOS SDK running bash and some POSIX-compliance details were overlooked. Now that the script has taken shape we can/should make some effort to improve this so the script is more universally useful, particularly for external developers.

For example, in CL:422945 Martin noted that 'local' is not specified by POSIX, but the scripts use 'local' for scoping variables. We could force bash to be used (#!/usr/bin/env bash), but bash itself has many dependencies that users might not want to pull in. Other ideas include converting the existing functions to use subshells, or just relying on naming convention to specify intent of variables (uppercase for global variable which is probably assigned once such as command-line switches, lowercase for local variables which should be initialized at the start of a function using it).
 
Blocking: 621715
Project Member

Comment 2 by sheriffbot@chromium.org, Feb 15 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment