xss-ALLOWED-top-navigation-after-postMessage.html failing on site isolation bots |
||
Issue descriptionhttp/tests/security/frameNavigation/xss-ALLOWED-top-navigation-after-postMessage.html has been failing on Site Isolation bots since https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/13311. Nate, looks like this was caused by your https://codereview.chromium.org/2617773002. Looks like we had a previous expectation for this in FlagExpectations/site-per-process, expecting the test to fail with a timeout, but now it fails with a text diff (the output has PASS but is missing the console log warning). Is there perhaps some sort of race in --site-per-process where the console warning doesn't get logged in time? To repro: $ third_party/WebKit/Tools/Scripts/run-webkit-tests \ --additional-drt-flag=--site-per-process \ -t gn -v http/tests/security/frameNavigation/xss-ALLOWED-top-navigation-after-postMessage.html We could probably just adjust the test's expectations for now in FlagExpectations/site-per-process, since you've got a CL in progress to switch the test back to expect that navigation to fail.
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23d0ec854822ed5b94d08c84a9db55270bdece43 commit 23d0ec854822ed5b94d08c84a9db55270bdece43 Author: japhet <japhet@chromium.org> Date: Thu Feb 09 00:47:21 2017 Mark http/tests/security/frameNavigation/xss-ALLOWED-top-navigation-after-postMessage.html un-flaky This was failing rather than timing out until https://chromium.googlesource.com/chromium/src/+/61835ae17fb417e72d42d7e4829c755c5abdb578, which returned it to its expected timeout state. BUG= 680249 Review-Url: https://codereview.chromium.org/2686953002 Cr-Commit-Position: refs/heads/master@{#449164} [modify] https://crrev.com/23d0ec854822ed5b94d08c84a9db55270bdece43/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
,
Feb 9 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jan 12 2017