New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680243 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Adjust ec ebuild/Makefiles to support quiet operation

Project Member Reported by sjg@chromium.org, Jan 11 2017

Issue description

The EC Makefile supports building with V=1 to get verbose output. But warnings are still masked by all the (mostly useless) output. At least for devs it is useful to see just the warnings/errors.

So, add:

USE=verbose which enables the current 'V=1' option
USE=quiet which shows warnings/errors only

 

Comment 1 by sjg@chromium.org, Jan 11 2017

Status: Started (was: Available)

Comment 3 by sjg@chromium.org, Jan 12 2017

Components: OS>Firmware>EC
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/70d4db19abefc169c7f5f087a80dca6f559527cf

commit 70d4db19abefc169c7f5f087a80dca6f559527cf
Author: Simon Glass <sjg@chromium.org>
Date: Thu Jan 12 00:15:08 2017

Makefile: Drop the extra whitespace in the 'export' line

Fix this little nit.

BUG= chromium:680243 
BRANCH=none
TEST=emerge-reef chromeos-ec
Signed-off-by: Simon Glass <sjg@chromium.org>

Change-Id: I932553a8b7f8e5519abc813c09caae8d8d3d2790
Reviewed-on: https://chromium-review.googlesource.com/427362
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[modify] https://crrev.com/70d4db19abefc169c7f5f087a80dca6f559527cf/Makefile

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/7d40fb380d1dd7a0720ef8f7e2f1bf052f826b4f

commit 7d40fb380d1dd7a0720ef8f7e2f1bf052f826b4f
Author: Simon Glass <sjg@chromium.org>
Date: Thu Jan 12 00:18:17 2017

Makefile: Support three levels of verbosity

At present the EC Makefile supports two levels of verbosity:

V unset: Show an abbreviated build log (operation and file only)
V=1: Show the full build log, including all commands

However, even the abbreviated build log includes a lot of output. It is
basically a long list of filenames and is of little use during
development. It is more useful to show just warnings and errors.

Add a new setting, V=0, which provides this.

BUG= chromium:680243 
BRANCH=none
TEST=emerge-reef chromeos-ec; test each of V=, V=0, V=1 and see that the
Makefile does the correct thing.
Change-Id: I85c0423c5299fa3ab624ed9f7f7b6b7f73236611
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/427363
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[modify] https://crrev.com/7d40fb380d1dd7a0720ef8f7e2f1bf052f826b4f/Makefile.rules

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/70ea50153fa8c47e5eb8175108d9c45668dad2ce

commit 70ea50153fa8c47e5eb8175108d9c45668dad2ce
Author: Simon Glass <sjg@chromium.org>
Date: Thu Jan 12 00:24:14 2017

Makefile: Suppress unwanted 'echo' output

Add a 'echo' command which can be called to generate output. If V=0 then
it is suppressed. This drops the unwanted output when V=0.

Signed-off-by: Simon Glass <sjg@chromium.org>
BUG= chromium:680243 
BRANCH=none
TEST=V=0 emerge-reef chromeos-ec; See that the BUILD lines are gone

Change-Id: Ie4474024c84345d427f4d95a9ff194dc740f860f
Reviewed-on: https://chromium-review.googlesource.com/427364
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[modify] https://crrev.com/70ea50153fa8c47e5eb8175108d9c45668dad2ce/Makefile.rules

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/9fd2736d90c598b335d689d8db5ad727194a1991

commit 9fd2736d90c598b335d689d8db5ad727194a1991
Author: Simon Glass <sjg@chromium.org>
Date: Wed Jan 11 19:50:36 2017

Makefile: Suppress unwanted tpm output

Use the 'echo' command to suppress unwanted build output when V=0.

Signed-off-by: Simon Glass <sjg@chromium.org>
BUG= chromium:680243 
BRANCH=none
TEST=V=0 emerge-reef chromeos-ec; See that the tpm output is gone

Change-Id: Ia742b0b5270b969ec4f51967810e616348e39dbd
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/427365
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[modify] https://crrev.com/9fd2736d90c598b335d689d8db5ad727194a1991/test/tpm_test/Makefile

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5e32af2ed966a700668284f31a834cdf4d3eb3ec

commit 5e32af2ed966a700668284f31a834cdf4d3eb3ec
Author: Simon Glass <sjg@chromium.org>
Date: Thu Jan 12 00:32:32 2017

chromeos-ec: Support normal, quiet and verbose output

Add USE=quiet to suppress all output except warnings and errors.
Add USE=verbose to enable all output.

Signed-off-by: Simon Glass <sjg@chromium.org>
BUG= chromium:680243 
BRANCH=none
TEST=emerge-reef chromeos-ec; see normal progress output
USE=quiet emerge-reef chromeos-ec; see almost no output
USE=verbose emerge-reef chromeos-ec; see all output

Change-Id: I88d334683d6842690a6e11847a1cae67838a72b0
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/427380
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/5e32af2ed966a700668284f31a834cdf4d3eb3ec/chromeos-base/chromeos-ec/chromeos-ec-9999.ebuild

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/b6c1d0d4907b0b2cd605c44a5024e7188c34a335

commit b6c1d0d4907b0b2cd605c44a5024e7188c34a335
Author: Simon Glass <sjg@chromium.org>
Date: Fri Jan 13 20:47:08 2017

Makefile: Suppress 'Not a git repository' errors

We get a lot of these errors when running the EC Makefile from an ebuild.
They are not useful since of course there is no git repo when the source
code is built from a copy. An empty date (as produced in this case) is
presumably good enough.

Suppress these errors by redirecting stderr.

BUG= chromium:680243 
BRANCH=none
TEST=V=0 emerge-reef chromeos-ec; See that the git output is gone

Change-Id: Ia3d1e2046c87e0ca88d0c18e432467f9d23b7e9f
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/428156
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[modify] https://crrev.com/b6c1d0d4907b0b2cd605c44a5024e7188c34a335/util/getversion.sh

Comment 10 by sjg@chromium.org, Jan 17 2017

Status: Fixed (was: Started)
It's much quieter now.

Sign in to add a comment