New issue
Advanced search Search tips

Issue 680241 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Two lint errors related to data_reduction_promo_summary string

Project Member Reported by mikec...@chromium.org, Jan 11 2017

Issue description

These lint errors are causing failures on some of the upstream builders.

Failure:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FAndroid_arm64_Builder__dbg_%2F13024%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

First failing build:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/13024

/tmp/tmpmA0HDm/out/Debug/gen/chrome/android/chrome_strings_grd.resources.zip/values-pt-rBR/android_chrome_strings.xml:242 Incorrect formatting string `data_reduction_promo_summary`; missing conversion character in '`% a`' ?: StringFormatInvalid [warning]
<string name="data_reduction_promo_summary">"Use até 60% a menos de dados e deixe a Web mais rápida. Os servidores do Google otimizarão as páginas que você visitar."</string>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/tmpmA0HDm/out/Debug/gen/chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml:244 Inconsistent number of arguments in formatting string `data_reduction_promo_summary`; found both 0 and 1: StringFormatCount [warning]
<string name="data_reduction_promo_summary">"Uspořte až 60 % dat a načítejte weby rychleji. Servery Google budou navštěvované stránky optimalizovat."</string>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Lint found 2 new issues.
 - For full explanation, please refer to out/Debug/gen/chrome/android/chrome_java__lint/result.xml
 - For more information about lint and how to fix lint issues, please refer to https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.md

Traceback (most recent call last):
  File "../../build/android/gyp/lint.py", line 375, in <module>
    sys.exit(main())
  File "../../build/android/gyp/lint.py", line 371, in main
    depfile_deps=classpath)
  File "/b/c/b/Android_arm64_Builder__dbg_/src/build/android/gyp/util/build_utils.py", line 578, in CallAndWriteDepfileIfStale
    pass_changes=True)
  File "/b/c/b/Android_arm64_Builder__dbg_/src/build/android/gyp/util/md5_check.py", line 87, in CallAndRecordIfStale
    function(*args)
  File "/b/c/b/Android_arm64_Builder__dbg_/src/build/android/gyp/util/build_utils.py", line 561, in on_stale_md5
    function(*args)
  File "../../build/android/gyp/lint.py", line 366, in <lambda>
    silent=args.silent),
  File "../../build/android/gyp/lint.py", line 238, in _OnStaleMd5
    raise Exception('Lint failed.')
Exception: Lint failed.
 
Status: Fixed (was: Untriaged)
Culprit CL reverted here

https://chromium.googlesource.com/chromium/src/+/957e153e766373fd1589dfaf2a07cf1929de6463

Sign in to add a comment