Safe Browsing Navigation Observer need to record all the server side redirection including intermediate ones |
||||||
Issue descriptionPer bineval team's request, we need to capture the entire distribution chain including intermediate server side redirects. This requires adding a repeated fields to ReferrerChainEntry message to record server redirect urls.
,
Feb 1 2017
,
Feb 7 2017
,
Feb 7 2017
Which OSs does this affect?
,
Feb 7 2017
This issue affects All desktop chrome + Clank. And this is referring to change https://chromium.googlesource.com/chromium/src/+/de82ac84d9c24e3910cfc4c20d81d94bfca48943 Somehow, this bug is not updated when my CL landed....
,
Feb 8 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07d6f63e7843d776ecdfc3b0ce645b0b8e080f8b commit 07d6f63e7843d776ecdfc3b0ce645b0b8e080f8b Author: Jialiu Lin <jialiul@chromium.org> Date: Wed Feb 08 01:47:45 2017 In previous implementation, if the server does the more than one server redirects, we only record the original request url and the final url (after all server-redirects). Per Bineval team's request, this CL adds all the server redirect urls (including intermediate ones) to download pings. This is because these intermediate server redirects might be used as signal to identify certain malware/UwS campaigns. Add two histograms to count # of NavigationEvents and the memory usage. Also, fix a bug that causes duplicating IP addresses. BUG= 680238 Review-Url: https://codereview.chromium.org/2644133005 Cr-Commit-Position: refs/heads/master@{#447382} (cherry picked from commit de82ac84d9c24e3910cfc4c20d81d94bfca48943) Review-Url: https://codereview.chromium.org/2686773002 . Cr-Commit-Position: refs/branch-heads/2987@{#376} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/07d6f63e7843d776ecdfc3b0ce645b0b8e080f8b/chrome/browser/safe_browsing/download_protection_service.cc [modify] https://crrev.com/07d6f63e7843d776ecdfc3b0ce645b0b8e080f8b/chrome/browser/safe_browsing/download_protection_service.h [modify] https://crrev.com/07d6f63e7843d776ecdfc3b0ce645b0b8e080f8b/chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc [modify] https://crrev.com/07d6f63e7843d776ecdfc3b0ce645b0b8e080f8b/chrome/browser/safe_browsing/safe_browsing_navigation_observer.h [modify] https://crrev.com/07d6f63e7843d776ecdfc3b0ce645b0b8e080f8b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc [modify] https://crrev.com/07d6f63e7843d776ecdfc3b0ce645b0b8e080f8b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc [modify] https://crrev.com/07d6f63e7843d776ecdfc3b0ce645b0b8e080f8b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h [modify] https://crrev.com/07d6f63e7843d776ecdfc3b0ce645b0b8e080f8b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_unittest.cc [modify] https://crrev.com/07d6f63e7843d776ecdfc3b0ce645b0b8e080f8b/chrome/common/safe_browsing/csd.proto [modify] https://crrev.com/07d6f63e7843d776ecdfc3b0ce645b0b8e080f8b/tools/metrics/histograms/histograms.xml |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jialiul@chromium.org
, Jan 20 2017