Triggered trybots do not sometimes show up on PolyGerrit CLs when there are many patchsets |
|||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Go to https://skia-review.googlesource.com/c/6352/12 (2) Dry run was triggered on patchset 12: https://skia-review.googlesource.com/c/6352/12#message-5dde0664ce475ded1e41276060e132ddad1ce678 What is the expected result? Bots show up. What happens instead? No bots show up. Note that it seems to work fine on some other Skia changes Eg: https://skia-review.googlesource.com/c/6881/2
,
Jan 11 2017
Yeah that's what I'm trying to figure out. Turns out I didn't understand js sorting correctly. Fix here: https://chromium-review.googlesource.com/426942
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/9dd66d38050dbb1f2c1cb2183061be978b967073 commit 9dd66d38050dbb1f2c1cb2183061be978b967073 Author: Aaron Gable <agable@chromium.org> Date: Wed Jan 11 19:15:57 2017 Fix revision sorting function to return ints I'd misunderstood the compareFunction parameter to sort(), and was having it return bools instead of ints. BUG= 680206 Change-Id: I2eecdd08a66243f6df878379e9b17558795a7845 [modify] https://crrev.com/9dd66d38050dbb1f2c1cb2183061be978b967073/src/main/resources/static/buildbucket.js
,
Jan 13 2017
I know the fix is in. Just wanted to update the description since so many people are running into this.
,
Jan 13 2017
,
Jan 13 2017
,
Jan 13 2017
,
Jan 13 2017
,
Jan 17 2017
The rollout containing this fix happened today.
,
Jan 31 2017
This is still happening: https://skia-review.googlesource.com/c/7130/12 Did something get rolled back?
,
Jan 31 2017
Wanted to point out that at https://skia-review.googlesource.com/c/7130/12 right now there are trybots showing up, but they're trybot runs from the wrong patch set. The original report seems to be that no bots showed up.
,
Jan 31 2017
Yes, when I go into the sources tab of the inspector on that review and look at the buildbucket.js that is running, it is definitely showing the old version of the code (using < in the sort function on line 47, instead of -). I'm not sure what's going on there.
,
Jan 31 2017
Hmm, looks like something went wrong and the CL containing the fix was never imported at all. This is concerning. I'm going to do another import of the buildbucket plugin today and will keep you updated.
,
Jan 31 2017
I was previously misinformed; the previous import and deployment missed the fix for this by one CL. The correct import is here: cl/146143061.
,
Feb 6 2017
This has now actually been deployed. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by aga...@chromium.org
, Jan 11 2017