New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680206 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Triggered trybots do not sometimes show up on PolyGerrit CLs when there are many patchsets

Project Member Reported by rmis...@google.com, Jan 11 2017

Issue description


What steps will reproduce the problem?
(1) Go to https://skia-review.googlesource.com/c/6352/12
(2) Dry run was triggered on patchset 12: https://skia-review.googlesource.com/c/6352/12#message-5dde0664ce475ded1e41276060e132ddad1ce678

What is the expected result?
Bots show up.

What happens instead?
No bots show up.

Note that it seems to work fine on some other Skia changes Eg: https://skia-review.googlesource.com/c/6881/2
 

Comment 3 by aga...@chromium.org, Jan 11 2017

Status: Started (was: Assigned)
Yeah that's what I'm trying to figure out. Turns out I didn't understand js sorting correctly. Fix here: https://chromium-review.googlesource.com/426942
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/9dd66d38050dbb1f2c1cb2183061be978b967073

commit 9dd66d38050dbb1f2c1cb2183061be978b967073
Author: Aaron Gable <agable@chromium.org>
Date: Wed Jan 11 19:15:57 2017

Fix revision sorting function to return ints

I'd misunderstood the compareFunction parameter to sort(), and
was having it return bools instead of ints.

BUG= 680206 

Change-Id: I2eecdd08a66243f6df878379e9b17558795a7845

[modify] https://crrev.com/9dd66d38050dbb1f2c1cb2183061be978b967073/src/main/resources/static/buildbucket.js

Comment 5 by rmis...@google.com, Jan 13 2017

Labels: -Pri-2 Pri-1
Summary: Triggered trybots do not show up on PolyGerrit when there are many patchsets (was: Trybots triggered via dry run do not show up on PolyGerrit change)
I know the fix is in. Just wanted to update the description since so many people are running into this.

Comment 6 by rmis...@google.com, Jan 13 2017

Summary: Triggered trybots do not sometimes show up on PolyGerrit CLs when there are many patchsets (was: Triggered trybots do not show up on PolyGerrit when there are many patchsets)

Comment 7 by aga...@chromium.org, Jan 13 2017

Cc: aga...@chromium.org machenb...@chromium.org
 Issue 674252  has been merged into this issue.

Comment 8 by aga...@chromium.org, Jan 13 2017

Cc: herb@google.com
 Issue 681144  has been merged into this issue.

Comment 9 by aga...@chromium.org, Jan 13 2017

Labels: Milestone-Fishfood
Status: Fixed (was: Started)
The rollout containing this fix happened today.

Comment 11 by rmis...@google.com, Jan 31 2017

Cc: bunge...@chromium.org
Status: Assigned (was: Fixed)
This is still happening: https://skia-review.googlesource.com/c/7130/12

Did something get rolled back?
Wanted to point out that at  https://skia-review.googlesource.com/c/7130/12 right now there are trybots showing up, but they're trybot runs from the wrong patch set. The original report seems to be that no bots showed up.
Yes, when I go into the sources tab of the inspector on that review and look at the buildbucket.js that is running, it is definitely showing the old version of the code (using < in the sort function on line 47, instead of -). I'm not sure what's going on there.
Status: Started (was: Assigned)
Hmm, looks like something went wrong and the CL containing the fix was never imported at all. This is concerning. I'm going to do another import of the buildbucket plugin today and will keep you updated.
I was previously misinformed; the previous import and deployment missed the fix for this by one CL. The correct import is here: cl/146143061.
Status: Fixed (was: Started)
This has now actually been deployed.

Sign in to add a comment