New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680201 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

http/tests/security/referrer-policy-attribute-import-no-referrer.html is failing on Site Isolation bots

Project Member Reported by alex...@chromium.org, Jan 11 2017

Issue description

This test has been failing consistently on Site Isolation bots.  First failing Linux build: 
https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/13272

Diff:
-CONSOLE MESSAGE: line 6: PASS
+CONSOLE MESSAGE: line 6: FAIL
 
yoav@yoav.ws: you added this test in https://codereview.chromium.org/2495313002.  Can you take a look at why it'd be failing with --site-per-process turned on?

You can reproduce using:

  $ third_party/WebKit/Tools/Scripts/run-webkit-tests \
      --additional-drt-flag=--site-per-process \
      -t gn -v http/tests/security/referrer-policy-attribute-import-no-referrer.html

 
Actually, this didn't repro for me locally, and I noticed that the flakiness dashboard shows this failing on a couple of other bots:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests%20(with%20patch)&tests=http%2Ftests%2Fsecurity%2Freferrer-policy-attribute-import-no-referrer.html

So maybe this isn't specific to --site-per-process and involves something else in those bot configs?
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96557bfa11c102628943935e7906cff4b3b04a74

commit 96557bfa11c102628943935e7906cff4b3b04a74
Author: alexmos <alexmos@chromium.org>
Date: Thu Jan 12 00:14:49 2017

Add expectations for three layout tests failing on Site Isolation bots.

This should hopefully get the bots back to green while individual bugs
are being investigated.

BUG= 680201 ,  661725 ,  680249 ,  680307 
NOTRY=true

Review-Url: https://codereview.chromium.org/2625233002
Cr-Commit-Position: refs/heads/master@{#443071}

[modify] https://crrev.com/96557bfa11c102628943935e7906cff4b3b04a74/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Comment 3 by y...@yoav.ws, Apr 10 2017

Failing to reproduce locally. Is this test still failing?
Cc: -lukasza@chromium.org y...@yoav.ws
Owner: lukasza@chromium.org
I also can't reproduce locally (with --additional-drt-flag=--site-per-process and with --iterations=50).  Let me try to reenable this test in https://codereview.chromium.org/2814563002 and see what linux_site_isolation trybot says.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbdb1d18c66296934a3ec0bd01b0f516030c8fd0

commit dbdb1d18c66296934a3ec0bd01b0f516030c8fd0
Author: lukasza <lukasza@chromium.org>
Date: Tue Apr 11 23:09:59 2017

OOPIFs: Enable h/t/s/referrer-policy-attribute-import-no-referrer.html test.

This test seemed to have mysteriously "healed" itself.

BUG= 680201 

Review-Url: https://codereview.chromium.org/2814563002
Cr-Commit-Position: refs/heads/master@{#463823}

[modify] https://crrev.com/dbdb1d18c66296934a3ec0bd01b0f516030c8fd0/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Let's monitor the site isolation trybots and FYI bots for a while and close this bug if http/tests/security/referrer-policy-attribute-import-no-referrer.html keeps being green.
Status: WontFix (was: Assigned)
No repro - let's close the bug.

Sign in to add a comment