New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680190 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Ship document.rootScroller origin trial

Project Member Reported by bokan@chromium.org, Jan 11 2017

Issue description

Ship document.rootScroller as an origin trial in M57 and M58
 
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a36b3b3314dd80ef22d20cc86f3146767b7e23b1

commit a36b3b3314dd80ef22d20cc86f3146767b7e23b1
Author: bokan <bokan@chromium.org>
Date: Wed Mar 01 11:36:02 2017

Revert of Make document.rootScroller into an origin trial (patchset #3 id:40001 of https://codereview.chromium.org/2628923002/ )

Reason for revert:
Origin trial has been delayed for now

Original issue's description:
> Make document.rootScroller into an origin trial
>
> Intent-to-experiment:
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/COF0YKkjZVQ
>
> BUG= 680190 
>
> Review-Url: https://codereview.chromium.org/2628923002
> Cr-Commit-Position: refs/heads/master@{#443956}
> Committed: https://chromium.googlesource.com/chromium/src/+/f2b6b4c6b17f90d48d986c3856f4a422ddbdbc2c

TBR=iclelland@chromium.org,rbyers@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 680190 

Review-Url: https://codereview.chromium.org/2707133008
Cr-Commit-Position: refs/heads/master@{#453905}

[delete] https://crrev.com/eded7142ea9f7ff109e9b3a5606cac4161aafbdb/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-script-added-expected.txt
[delete] https://crrev.com/eded7142ea9f7ff109e9b3a5606cac4161aafbdb/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-script-added.html
[delete] https://crrev.com/eded7142ea9f7ff109e9b3a5606cac4161aafbdb/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces.html
[delete] https://crrev.com/eded7142ea9f7ff109e9b3a5606cac4161aafbdb/third_party/WebKit/LayoutTests/virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-script-added-expected.txt
[modify] https://crrev.com/a36b3b3314dd80ef22d20cc86f3146767b7e23b1/third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.cpp
[modify] https://crrev.com/a36b3b3314dd80ef22d20cc86f3146767b7e23b1/third_party/WebKit/Source/core/dom/Document.idl
[modify] https://crrev.com/a36b3b3314dd80ef22d20cc86f3146767b7e23b1/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Comment 3 by bokan@chromium.org, Mar 2 2017

Cc: amineer@chromium.org
amineer@, I'd like to revert this from the M57 branch, do I need to do a merge request or can I just go ahead and revert?

Comment 4 by bokan@chromium.org, Mar 3 2017

Labels: Merge-Request-57
Labels: -Merge-Request-57 Merge-Approved-57
Merge (of revert) approved for M57 branch 2987
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 3 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/125fd6b5e329ba2c77a356a86d5b4b041395ba05

commit 125fd6b5e329ba2c77a356a86d5b4b041395ba05
Author: bokan <bokan@chromium.org>
Date: Fri Mar 03 19:06:37 2017

Revert "Make document.rootScroller into an origin trial"

This reverts commit f2b6b4c6b17f90d48d986c3856f4a422ddbdbc2c.

BUG= 680190 

Review-Url: https://codereview.chromium.org/2731763002 .
Cr-Commit-Position: refs/branch-heads/2987@{#754}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[delete] https://crrev.com/8a938a18f838db140a0ed9068ba6ac6320730599/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-expected.txt
[delete] https://crrev.com/8a938a18f838db140a0ed9068ba6ac6320730599/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-script-added-expected.txt
[delete] https://crrev.com/8a938a18f838db140a0ed9068ba6ac6320730599/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-script-added.html
[delete] https://crrev.com/8a938a18f838db140a0ed9068ba6ac6320730599/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces.html
[delete] https://crrev.com/8a938a18f838db140a0ed9068ba6ac6320730599/third_party/WebKit/LayoutTests/virtual/origin-trials-features-disabled/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-expected.txt
[delete] https://crrev.com/8a938a18f838db140a0ed9068ba6ac6320730599/third_party/WebKit/LayoutTests/virtual/origin-trials-features-disabled/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-script-added-expected.txt
[modify] https://crrev.com/125fd6b5e329ba2c77a356a86d5b4b041395ba05/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp
[modify] https://crrev.com/125fd6b5e329ba2c77a356a86d5b4b041395ba05/third_party/WebKit/Source/core/dom/Document.idl
[modify] https://crrev.com/125fd6b5e329ba2c77a356a86d5b4b041395ba05/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 7 by bokan@chromium.org, Aug 25 2017

Status: WontFix (was: Started)
Origin trial is currently not part of the plan so I'm closing this out.

Sign in to add a comment