New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680189 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Away
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Bottom bar that starts empty can't be set

Project Member Reported by sbirch@chromium.org, Jan 11 2017

Issue description

Right now if you don't have a bottom bar initially you can't have one in that session. I think update should create a bottom bar if one doesn't already exist.

Microspec:
In the case where the bottom bar is scrolled off-screen it should stay there but reappear as usual when the user scrolls up. Otherwise it should appear with the reverse of the animation we use to hide it after updating to null.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffbe56aa8a82dd68bba0912cfb6b944415ed5fd6

commit ffbe56aa8a82dd68bba0912cfb6b944415ed5fd6
Author: ianwen <ianwen@chromium.org>
Date: Thu Jan 26 21:07:22 2017

[Android] Enable Ad Hoc RemoteViews in CCT Bottom Bar

This CL makes it possible for client to add a RemoteViews bottom bar
through CustomTabsSession.

BUG= 680189 

Review-Url: https://codereview.chromium.org/2654003007
Cr-Commit-Position: refs/heads/master@{#446445}

[modify] https://crrev.com/ffbe56aa8a82dd68bba0912cfb6b944415ed5fd6/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java

Comment 2 by ian...@chromium.org, Jan 26 2017

Status: Fixed (was: Assigned)
Yay! Fixed in M58

Comment 3 by sbirch@chromium.org, Jan 26 2017

\o/

Sign in to add a comment