New issue
Advanced search Search tips

Issue 680183 link

Starred by 3 users
Status: Fixed
Owner:
aga...@chromium.org
Closed: Mar 2017
Cc:
aga...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Previous locations:
gerrit:5246


Sign in to add a comment

Linkification config on pdfium-review needs to be updated

Project Member Reported by npm@google.com, Jan 11 2017 
Affected Version:

What steps will reproduce the problem?
1. Go to https://codereview.chromium.org/2528543003/, notice BUG= is followed by a link
2. Go to https://pdfium-review.googlesource.com/c/2165/, BUG= is followed by a number without link

What is the expected output?
BUG= should behave similar as before, so I can easily go to bugs associated with CLs.

Comment 1 by andyb...@chromium.org, Jan 11 2017

Labels: -Restrict-View-Google

Comment 2 by andyb...@chromium.org, Jan 11 2017

Owner: aga...@chromium.org

Comment 3 by andyb...@chromium.org, Jan 11 2017

Project: chromium
Moved issue gerrit:5246 to now be  issue chromium:680183 .

Comment 4 by andyb...@chromium.org, Jan 11 2017

Components: Infra>Codereview>Gerrit
Labels: Milestone-Fishfood Proj-Gerrit-Migration Pri-2 Type-Feature
Status: Assigned (was: New)
Summary: Linkification config on pdfium-review needs to be updated (was: BUG links are missing)

Comment 5 by andyb...@chromium.org, Jan 11 2017

Labels: -Milestone-Fishfood Milestone-Dogfood

Comment 6 by vikt...@google.com, Jan 11 2017 

Here's linkification example for BUG= 123 ,  45 

[commentlink "bug"]
	match = (BUG=\\s*)(\\d+)
	html = $1<a href=\"http://some.url/$2\">$2</a>

[commentlink "bug1"]
	match = (BUG=\\s*\\d+\\s*,\\s*)(\\d+)
	html = $1<a href=\"http://some.url/$2\">$2</a>

Comment 7 by aga...@chromium.org, Jan 11 2017

Status: Started (was: Assigned)
cl/144224569

Comment 8 by aga...@chromium.org, Jan 12 2017 

The above CL has landed; I need to do a manual config reload to make it live.

Comment 9 by andyb...@chromium.org, Jan 12 2017

Cc: aga...@chromium.org
 Issue 678098  has been merged into this issue.

Comment 10 by aga...@chromium.org, Jan 13 2017 

config deployment tracked in b/34274281

Comment 11 by aga...@chromium.org, Mar 27 2017

Status: Fixed (was: Started)
►

Sign in to add a comment