New issue
Advanced search Search tips

Issue 680180 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Change android call UpdateServerCardBillingAddress to UpdateServerCardMetadata.

Project Member Reported by se...@chromium.org, Jan 11 2017

Issue description

This has been changed in the C++ autofill code, it needs to be changed in the android autofill code as well.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ed6d578394cf6648a30dbb8714bc22b99ab91e4

commit 0ed6d578394cf6648a30dbb8714bc22b99ab91e4
Author: sebsg <sebsg@chromium.org>
Date: Mon Jan 16 16:58:32 2017

[Payments] Update metadata instead of billing address for server cards.

Changes the function signature used in android code to update the billing_address_id of server cards. Now sends the whole card to the C++ instead of just the id and billing_address_id.

BUG= 680180 

Review-Url: https://codereview.chromium.org/2625413002
Cr-Commit-Position: refs/heads/master@{#443907}

[modify] https://crrev.com/0ed6d578394cf6648a30dbb8714bc22b99ab91e4/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/0ed6d578394cf6648a30dbb8714bc22b99ab91e4/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/0ed6d578394cf6648a30dbb8714bc22b99ab91e4/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardEditor.java
[modify] https://crrev.com/0ed6d578394cf6648a30dbb8714bc22b99ab91e4/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/0ed6d578394cf6648a30dbb8714bc22b99ab91e4/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/0ed6d578394cf6648a30dbb8714bc22b99ab91e4/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/0ed6d578394cf6648a30dbb8714bc22b99ab91e4/components/autofill/core/browser/personal_data_manager.h

Comment 2 by se...@chromium.org, Jan 18 2017

Status: Fixed (was: Assigned)

Comment 3 by se...@chromium.org, Feb 6 2017

Labels: Merge-Request-57
Labels: -Merge-Request-57 Merge-Approved-57
Merge approved for M57 branch 2987.

Comment 5 by se...@chromium.org, Feb 7 2017

Labels: -Merge-Approved-57
Cancelled merge request

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment