New issue
Advanced search Search tips

Issue 680178 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Add billing_address_id and has_converted columns to autofill_table

Project Member Reported by se...@chromium.org, Jan 11 2017 
Add a billing_address_id column in the server_card_metadata table and add has_converted column in the server_address_metadata table.

These will then be synced across chrome instances in a future CL.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e77d95a76768a00bfb8cffc4799b52e640c1ae7

commit 3e77d95a76768a00bfb8cffc4799b52e640c1ae7
Author: sebsg <sebsg@chromium.org>
Date: Wed Jan 25 04:51:24 2017

[Payments] Add billing_address_id and has_converted to autofill_table

Adds the billing_address_id column to the server_card_metadata table
and add the has_converted column to the server_address_metadata table
in autofill_table.

This CL does not modify any user noticeable behavior but is a stepping
stone towards converting Wallet addresses to Autofill profiles and
preserving the billing address relation ship.

Both fields were added to the metadata tables, because those are
intended to be read-write and used to sync this modifiable info across
Chrome instances.

BUG= 680178 

Review-Url: https://codereview.chromium.org/2626843004
Cr-Commit-Position: refs/heads/master@{#445949}

[modify] https://crrev.com/3e77d95a76768a00bfb8cffc4799b52e640c1ae7/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/3e77d95a76768a00bfb8cffc4799b52e640c1ae7/components/autofill/core/browser/webdata/autofill_table.cc
[modify] https://crrev.com/3e77d95a76768a00bfb8cffc4799b52e640c1ae7/components/autofill/core/browser/webdata/autofill_table.h
[modify] https://crrev.com/3e77d95a76768a00bfb8cffc4799b52e640c1ae7/components/autofill/core/browser/webdata/autofill_table_unittest.cc
[modify] https://crrev.com/3e77d95a76768a00bfb8cffc4799b52e640c1ae7/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/3e77d95a76768a00bfb8cffc4799b52e640c1ae7/components/autofill/core/browser/webdata/autofill_webdata.h
[modify] https://crrev.com/3e77d95a76768a00bfb8cffc4799b52e640c1ae7/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc
[modify] https://crrev.com/3e77d95a76768a00bfb8cffc4799b52e640c1ae7/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h
[modify] https://crrev.com/3e77d95a76768a00bfb8cffc4799b52e640c1ae7/components/autofill/core/browser/webdata/autofill_webdata_service.cc
[modify] https://crrev.com/3e77d95a76768a00bfb8cffc4799b52e640c1ae7/components/autofill/core/browser/webdata/autofill_webdata_service.h
[add] https://crrev.com/3e77d95a76768a00bfb8cffc4799b52e640c1ae7/components/test/data/web_database/version_70.sql
[modify] https://crrev.com/3e77d95a76768a00bfb8cffc4799b52e640c1ae7/components/webdata/common/BUILD.gn
[modify] https://crrev.com/3e77d95a76768a00bfb8cffc4799b52e640c1ae7/components/webdata/common/web_database.cc
[modify] https://crrev.com/3e77d95a76768a00bfb8cffc4799b52e640c1ae7/components/webdata/common/web_database_migration_unittest.cc

Comment 2 by se...@chromium.org, Jan 27 2017

Status: Fixed (was: Started)

Comment 3 by se...@chromium.org, Feb 3 2017

Labels: Merge-Request-57
Status: Started (was: Fixed)
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 3 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 3 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/542707dcc5ebccf4683dbf24cb27f148b5e7d824

commit 542707dcc5ebccf4683dbf24cb27f148b5e7d824
Author: sebsg <sebsg@chromium.org>
Date: Fri Feb 03 18:01:30 2017

[Payments] Add billing_address_id and has_converted to autofill_table

Adds the billing_address_id column to the server_card_metadata table
and add the has_converted column to the server_address_metadata table
in autofill_table.

This CL does not modify any user noticeable behavior but is a stepping
stone towards converting Wallet addresses to Autofill profiles and
preserving the billing address relation ship.

Both fields were added to the metadata tables, because those are
intended to be read-write and used to sync this modifiable info across
Chrome instances.

BUG= 680178 

Review-Url: https://codereview.chromium.org/2626843004
Cr-Commit-Position: refs/heads/master@{#445949}
(cherry picked from commit 3e77d95a76768a00bfb8cffc4799b52e640c1ae7)

Review-Url: https://codereview.chromium.org/2676723004 .
Cr-Commit-Position: refs/branch-heads/2987@{#290}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/542707dcc5ebccf4683dbf24cb27f148b5e7d824/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/542707dcc5ebccf4683dbf24cb27f148b5e7d824/components/autofill/core/browser/webdata/autofill_table.cc
[modify] https://crrev.com/542707dcc5ebccf4683dbf24cb27f148b5e7d824/components/autofill/core/browser/webdata/autofill_table.h
[modify] https://crrev.com/542707dcc5ebccf4683dbf24cb27f148b5e7d824/components/autofill/core/browser/webdata/autofill_table_unittest.cc
[modify] https://crrev.com/542707dcc5ebccf4683dbf24cb27f148b5e7d824/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/542707dcc5ebccf4683dbf24cb27f148b5e7d824/components/autofill/core/browser/webdata/autofill_webdata.h
[modify] https://crrev.com/542707dcc5ebccf4683dbf24cb27f148b5e7d824/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc
[modify] https://crrev.com/542707dcc5ebccf4683dbf24cb27f148b5e7d824/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h
[modify] https://crrev.com/542707dcc5ebccf4683dbf24cb27f148b5e7d824/components/autofill/core/browser/webdata/autofill_webdata_service.cc
[modify] https://crrev.com/542707dcc5ebccf4683dbf24cb27f148b5e7d824/components/autofill/core/browser/webdata/autofill_webdata_service.h
[add] https://crrev.com/542707dcc5ebccf4683dbf24cb27f148b5e7d824/components/test/data/web_database/version_70.sql
[modify] https://crrev.com/542707dcc5ebccf4683dbf24cb27f148b5e7d824/components/webdata/common/BUILD.gn
[modify] https://crrev.com/542707dcc5ebccf4683dbf24cb27f148b5e7d824/components/webdata/common/web_database.cc
[modify] https://crrev.com/542707dcc5ebccf4683dbf24cb27f148b5e7d824/components/webdata/common/web_database_migration_unittest.cc

Comment 6 by se...@chromium.org, Feb 3 2017

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cbfc336157c5b779815d95e153be12c8e9b0942

commit 6cbfc336157c5b779815d95e153be12c8e9b0942
Author: sebsg <sebsg@chromium.org>
Date: Thu Feb 16 20:36:51 2017

[Merge-57] Add billing_address_id and has_converted to autofill_table

Adds the billing_address_id column to the server_card_metadata table
and add the has_converted column to the server_address_metadata table
in autofill_table.

This CL does not modify any user noticeable behavior but is a stepping
stone towards converting Wallet addresses to Autofill profiles and
preserving the billing address relation ship.

Both fields were added to the metadata tables, because those are
intended to be read-write and used to sync this modifiable info across
Chrome instances.

BUG= 680178 

Review-Url: https://codereview.chromium.org/2626843004
Cr-Commit-Position: refs/heads/master@{#445949}
(cherry picked from commit 3e77d95a76768a00bfb8cffc4799b52e640c1ae7)

Review-Url: https://codereview.chromium.org/2703673002 .
Cr-Commit-Position: refs/branch-heads/2987@{#556}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/6cbfc336157c5b779815d95e153be12c8e9b0942/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/6cbfc336157c5b779815d95e153be12c8e9b0942/components/autofill/core/browser/webdata/autofill_table.cc
[modify] https://crrev.com/6cbfc336157c5b779815d95e153be12c8e9b0942/components/autofill/core/browser/webdata/autofill_table.h
[modify] https://crrev.com/6cbfc336157c5b779815d95e153be12c8e9b0942/components/autofill/core/browser/webdata/autofill_table_unittest.cc
[modify] https://crrev.com/6cbfc336157c5b779815d95e153be12c8e9b0942/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/6cbfc336157c5b779815d95e153be12c8e9b0942/components/autofill/core/browser/webdata/autofill_webdata.h
[modify] https://crrev.com/6cbfc336157c5b779815d95e153be12c8e9b0942/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc
[modify] https://crrev.com/6cbfc336157c5b779815d95e153be12c8e9b0942/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h
[modify] https://crrev.com/6cbfc336157c5b779815d95e153be12c8e9b0942/components/autofill/core/browser/webdata/autofill_webdata_service.cc
[modify] https://crrev.com/6cbfc336157c5b779815d95e153be12c8e9b0942/components/autofill/core/browser/webdata/autofill_webdata_service.h
[add] https://crrev.com/6cbfc336157c5b779815d95e153be12c8e9b0942/components/test/data/web_database/version_70.sql
[modify] https://crrev.com/6cbfc336157c5b779815d95e153be12c8e9b0942/components/webdata/common/BUILD.gn
[modify] https://crrev.com/6cbfc336157c5b779815d95e153be12c8e9b0942/components/webdata/common/web_database.cc
[modify] https://crrev.com/6cbfc336157c5b779815d95e153be12c8e9b0942/components/webdata/common/web_database_migration_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 16 2017

Labels: merge-merged-2987_54
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56a50cec1146dd19c8b32a013623c4f6678f3404

commit 56a50cec1146dd19c8b32a013623c4f6678f3404
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Feb 16 22:46:15 2017

[Payments] Add billing_address_id and has_converted to autofill_table

Adds the billing_address_id column to the server_card_metadata table
and add the has_converted column to the server_address_metadata table
in autofill_table.

This CL does not modify any user noticeable behavior but is a stepping
stone towards converting Wallet addresses to Autofill profiles and
preserving the billing address relation ship.

Both fields were added to the metadata tables, because those are
intended to be read-write and used to sync this modifiable info across
Chrome instances.

BUG= 680178 

Review-Url: https://codereview.chromium.org/2626843004
Cr-Commit-Position: refs/heads/master@{#445949}
(cherry picked from commit 3e77d95a76768a00bfb8cffc4799b52e640c1ae7)

Review-Url: https://codereview.chromium.org/2701783002 .
Cr-Commit-Position: refs/branch-heads/2987_54@{#2}
Cr-Branched-From: e483b047ce7b13ffee6f490358cc7973a12599de-refs/branch-heads/2987@{#516}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/56a50cec1146dd19c8b32a013623c4f6678f3404/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/56a50cec1146dd19c8b32a013623c4f6678f3404/components/autofill/core/browser/webdata/autofill_table.cc
[modify] https://crrev.com/56a50cec1146dd19c8b32a013623c4f6678f3404/components/autofill/core/browser/webdata/autofill_table.h
[modify] https://crrev.com/56a50cec1146dd19c8b32a013623c4f6678f3404/components/autofill/core/browser/webdata/autofill_table_unittest.cc
[modify] https://crrev.com/56a50cec1146dd19c8b32a013623c4f6678f3404/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/56a50cec1146dd19c8b32a013623c4f6678f3404/components/autofill/core/browser/webdata/autofill_webdata.h
[modify] https://crrev.com/56a50cec1146dd19c8b32a013623c4f6678f3404/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc
[modify] https://crrev.com/56a50cec1146dd19c8b32a013623c4f6678f3404/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h
[modify] https://crrev.com/56a50cec1146dd19c8b32a013623c4f6678f3404/components/autofill/core/browser/webdata/autofill_webdata_service.cc
[modify] https://crrev.com/56a50cec1146dd19c8b32a013623c4f6678f3404/components/autofill/core/browser/webdata/autofill_webdata_service.h
[add] https://crrev.com/56a50cec1146dd19c8b32a013623c4f6678f3404/components/test/data/web_database/version_70.sql
[modify] https://crrev.com/56a50cec1146dd19c8b32a013623c4f6678f3404/components/webdata/common/BUILD.gn
[modify] https://crrev.com/56a50cec1146dd19c8b32a013623c4f6678f3404/components/webdata/common/web_database.cc
[modify] https://crrev.com/56a50cec1146dd19c8b32a013623c4f6678f3404/components/webdata/common/web_database_migration_unittest.cc

Comment 9 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment