New issue
Advanced search Search tips

Issue 680167 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Switch to using the minibar rather than opening Chrome on out-of-scope navigations

Project Member Reported by sbirch@chromium.org, Jan 11 2017

Issue description

Per the discussion yesterday in the weekly; the minibar UI is more consistent with the long-term plan.
 
Owner: pkotw...@chromium.org
Status: Started (was: Available)
MINE!!!!
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9096f1be81426d51cefb1c2d839f5df9ae92192

commit b9096f1be81426d51cefb1c2d839f5df9ae92192
Author: pkotwicz <pkotwicz@chromium.org>
Date: Thu Jan 19 03:09:39 2017

[WebAPKs] Show minibar when WebAPK navigates outside scope specified in Web Manifest

This CL changes the behavior when a user taps a link in the WebAPK which
navigates out of the scope specified by the Web Manifest. Currently, the
navigation creates a new Chrome tab. The new behavior is to stay within the
WebAPK but to show a header with the page origin. The header is shown whenever
the WebAPK is on a page outside of the Web Manifest scope.

In the near future we will launch a Chrome custom tab  https://crbug.com/624236 
when a WebAPK navigates outside of the Web Manifest scope. Unfortunately this
is not possible for Chrome 57.

BUG= 680167 
TEST=ExternalNavigationHandlerTest.*, WebappVisibilityTest.*

Review-Url: https://codereview.chromium.org/2636103002
Cr-Commit-Position: refs/heads/master@{#444619}

[modify] https://crrev.com/b9096f1be81426d51cefb1c2d839f5df9ae92192/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
[modify] https://crrev.com/b9096f1be81426d51cefb1c2d839f5df9ae92192/chrome/android/java/src/org/chromium/chrome/browser/util/UrlUtilities.java
[modify] https://crrev.com/b9096f1be81426d51cefb1c2d839f5df9ae92192/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
[add] https://crrev.com/b9096f1be81426d51cefb1c2d839f5df9ae92192/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkBrowserControlsDelegate.java
[add] https://crrev.com/b9096f1be81426d51cefb1c2d839f5df9ae92192/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappBrowserControlsDelegate.java
[modify] https://crrev.com/b9096f1be81426d51cefb1c2d839f5df9ae92192/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDelegateFactory.java
[modify] https://crrev.com/b9096f1be81426d51cefb1c2d839f5df9ae92192/chrome/android/java_sources.gni
[modify] https://crrev.com/b9096f1be81426d51cefb1c2d839f5df9ae92192/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
[modify] https://crrev.com/b9096f1be81426d51cefb1c2d839f5df9ae92192/chrome/android/javatests/src/org/chromium/chrome/browser/util/UrlUtilitiesTest.java
[modify] https://crrev.com/b9096f1be81426d51cefb1c2d839f5df9ae92192/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java
[modify] https://crrev.com/b9096f1be81426d51cefb1c2d839f5df9ae92192/chrome/browser/android/url_utilities.cc

Status: Fixed (was: Started)
Repro steps:
1) Install WebAPK for tests.peter.sh/notification-generator/ via the add-to-homescreen menu item
2) Launch the WebAPK
3) Verify that the web page is full screen
4) Tap on the "public domain" link at the bottom of the page
5) Check that there is a grey bar at the top of the window which says "creativecommons.org"

Sign in to add a comment