New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680166 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Enable silent auth flow by default.

Project Member Reported by khmel@chromium.org, Jan 11 2017

Issue description

Recent finch experiment shows that silent auth flow does not cause any regression. There is no error caused by iteration with GAIA server. If error exists, it comes from preparation of HTTP context, which is common step for LSO and silent auth flows. Now we can enable silent workflow by default and merge it to M56 beta. If something goes wrong we can apply server configuration to change default enabled state to disabled.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e17519010f463724f7c81bc9b470ba142c9ec3a5

commit e17519010f463724f7c81bc9b470ba142c9ec3a5
Author: khmel <khmel@chromium.org>
Date: Thu Jan 19 17:08:23 2017

arc: Enable silent auth flow by default.

BUG=b/34219301
BUG= 680166 
TEST=Manually

Review-Url: https://codereview.chromium.org/2627093002
Cr-Commit-Position: refs/heads/master@{#444769}

[modify] https://crrev.com/e17519010f463724f7c81bc9b470ba142c9ec3a5/components/arc/arc_features.cc

Comment 2 by khmel@chromium.org, Jan 25 2017

Status: Fixed (was: Started)
Cc: gkihumba@chromium.org
Labels: Merge-Request-56
@gkihumba: this is the bug for issue 682377 I showed you earlier, this one is where the CL description is

Comment 4 by gkihumba@google.com, Feb 16 2017

Labels: Merge-Approved-56
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 16 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71458966cfac90f5c86f1396af1f88722ada1f96

commit 71458966cfac90f5c86f1396af1f88722ada1f96
Author: khmel <khmel@chromium.org>
Date: Thu Feb 16 00:21:08 2017

[Merge M56] arc: Enable silent auth flow by default.

BUG=b/34219301
BUG= 680166 
TEST=Manually
TBR=elijahtaylor@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2627093002
Cr-Commit-Position: refs/heads/master@{#444769}
(cherry picked from commit e17519010f463724f7c81bc9b470ba142c9ec3a5)

Review-Url: https://codereview.chromium.org/2695363002
Cr-Commit-Position: refs/branch-heads/2924@{#919}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/71458966cfac90f5c86f1396af1f88722ada1f96/components/arc/arc_features.cc

Comment 6 by khmel@chromium.org, Feb 16 2017

Labels: -Merge-Request-56 Merge-Merged
Status: Verified (was: Fixed)

Sign in to add a comment