New issue
Advanced search Search tips

Issue 680162 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Remove Kasko from Chrome

Project Member Reported by sebmarchand@chromium.org, Jan 11 2017

Issue description

Kasko is not needed anymore (replaced by Crashpad) and should be removed from Chrome.
 
I just saw a few entries in a DEPS file and was thinking we should do that. Thanks!
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f39bc2fdcbd42e8dc12ff14e609b05135c04f467

commit f39bc2fdcbd42e8dc12ff14e609b05135c04f467
Author: sebmarchand <sebmarchand@chromium.org>
Date: Thu Feb 02 01:42:37 2017

Remove Kasko!

Kasko isn't needed (or used) anymore and so there's no reason to keep
this code anymore.

BUG= 680162 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2621363002
Cr-Commit-Position: refs/heads/master@{#447677}

[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/.gitignore
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/.gn
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/DEPS
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/app/DEPS
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/app/version_assembly/version_assembly_manifest.template
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/browser/BUILD.gn
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/browser/DEPS
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/browser/chrome_browser_main_win.h
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/chrome.isolate
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/chrome_watcher/BUILD.gn
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/chrome_watcher/DEPS
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/chrome_watcher/chrome_watcher_main.cc
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/chrome_watcher/chrome_watcher_main_api.cc
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/chrome_watcher/chrome_watcher_main_api.h
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/common/BUILD.gn
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/common/DEPS
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/common/crash_keys.cc
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/common/crash_keys.h
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/installer/mini_installer/chrome.release
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/test/BUILD.gn
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/chrome/test/kasko/OWNERS
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/chrome/test/kasko/hang_watcher_integration_test.py
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/chrome/test/kasko/kasko_integration_test.py
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/chrome/test/kasko/py/kasko/__init__.py
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/chrome/test/kasko/py/kasko/config.py
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/chrome/test/kasko/py/kasko/crash_server.py
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/chrome/test/kasko/py/kasko/exceptions.py
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/chrome/test/kasko/py/kasko/integration_test.py
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/chrome/test/kasko/py/kasko/json_logging_handler.py
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/chrome/test/kasko/py/kasko/process.py
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/chrome/test/kasko/py/kasko/report.py
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/chrome/test/kasko/py/kasko/util.py
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/chrome/test/kasko/syzyasan_integration_test.py
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/chrome/tools/build/win/FILES.cfg
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/components/crash/DEPS
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/components/crash/content/app/BUILD.gn
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/components/crash/content/app/DEPS
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/content/browser/BUILD.gn
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/content/browser/frame_host/DEPS
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/content/browser/frame_host/debug_urls.cc
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/testing/scripts/kasko_integration_tests.py
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/testing/scripts/syzyasan_integration_tests.py
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/third_party/kasko/BUILD.gn
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/third_party/kasko/OWNERS
[delete] https://crrev.com/7df3c119b83d5b30eb201c7310141e4f87a326d1/third_party/kasko/kasko.gni
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/tools/licenses.py
[modify] https://crrev.com/f39bc2fdcbd42e8dc12ff14e609b05135c04f467/tools/metrics/histograms/histograms.xml

Woohoo! Quick, mark it fixed before it gets reverted.
Status: Fixed (was: Assigned)
Fixed!

Sign in to add a comment