New issue
Advanced search Search tips

Issue 680151 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 680153



Sign in to add a comment

Support unified builds with chromeos-ec

Project Member Reported by sjg@chromium.org, Jan 11 2017

Issue description

Add support for building the EC binary for multiple models (using reef).

This involves updating the EC ebuild to build for all models supported by the board, when USE=uniboard is enabled.

 

Comment 1 by sjg@chromium.org, Jan 11 2017

Owner: sjg@chromium.org
Status: Available (was: Untriaged)

Comment 2 by sjg@chromium.org, Jan 11 2017

Blocking: 680153

Comment 3 by sjg@chromium.org, Jan 11 2017

Components: Infra>Client>ChromeOS

Comment 4 by sjg@chromium.org, Jan 12 2017

Status: Started (was: Available)
CLs are in review
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bb988e6bf470702c5098020e1ca530566fadd640

commit bb988e6bf470702c5098020e1ca530566fadd640
Author: Simon Glass <sjg@chromium.org>
Date: Thu Jan 12 00:35:08 2017

chromeos-ec: Support unified builds

Support building the EC for multiple models in a single board. This uses
the unified build approach. The list of models to build is defined by the
EC_FIRMWARE_UNIBUILD and EC_FIRMWARE_EXTRA_UNIBUILD variables.

BUG= chromium:680151 
BRANCH=none
TEST=USE="quiet unibuild" emerge-reef chromeos-ec
Look in build/reef/firmware/ and see that firmware exists for reef, pyro,
snappy. So far it is untested (until I get some more hardware).

Change-Id: Ifce063859442fd32955daabf8e7d919c0af056e7
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/427381
Tested-by: Simon Glass <sjg@google.com>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[modify] https://crrev.com/bb988e6bf470702c5098020e1ca530566fadd640/eclass/cros-ec-board.eclass

Comment 7 by sjg@chromium.org, Jan 19 2017

Status: Fixed (was: Started)

Comment 8 by sjg@chromium.org, Jan 19 2017

Blockedon: 682781

Comment 9 by sjg@chromium.org, Jan 20 2017

Blockedon: -682781
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 24 2017

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 17 2017

Comment 12 by sjg@chromium.org, Mar 2 2017

Components: -Infra>Client>ChromeOS OS>Firmware>EC
Status: Started (was: Fixed)
This generates extra files at present, so I'm reopening this bug.
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2aa497754310562414a48c26b47b93c784a7a4f0

commit 2aa497754310562414a48c26b47b93c784a7a4f0
Author: Simon Glass <sjg@chromium.org>
Date: Fri Mar 03 07:46:16 2017

chromeos-ec: Display the target we are building for

This just helps to see what is happening for long multi-target builds.

BUG= chromium:680151 
TEST=emerge-reef chromeos-ec; see the messages

Change-Id: I7462beb453bccc598645788345dfb407ab9e20ad
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/448253
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[modify] https://crrev.com/2aa497754310562414a48c26b47b93c784a7a4f0/chromeos-base/chromeos-ec/chromeos-ec-9999.ebuild

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c10291503710a24f00620bd178ff20ff6a0175c7

commit c10291503710a24f00620bd178ff20ff6a0175c7
Author: Simon Glass <sjg@chromium.org>
Date: Fri Mar 03 07:46:16 2017

chromeos-ec: Don't install the 'main EC' with unified builds

There is no 'main EC' with unified builds. We just have the various
targets needed by each model. Update the install method to deal with this.
This avoids installing superfluous files in /build/firmware.

BUG= chromium:680151 
TEST=emerge-reef chromeos-ec
See there are no EC files in /build/reef/firmware
Signed-off-by: Simon Glass <sjg@chromium.org>

Change-Id: I839997e5b31f20d00e755cf1d832bd93ed9e6f49
Reviewed-on: https://chromium-review.googlesource.com/448254
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[modify] https://crrev.com/c10291503710a24f00620bd178ff20ff6a0175c7/chromeos-base/chromeos-ec/chromeos-ec-9999.ebuild

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bb8095665b8f7330665662acf0fb10021d332678

commit bb8095665b8f7330665662acf0fb10021d332678
Author: Simon Glass <sjg@chromium.org>
Date: Sat Mar 04 01:11:32 2017

coreboot: Pick up the correct EC for the current model

At present we collect the EC from the /firmware directory. But with
unified builds we must look in the model directory instead. Fix this.

BUG= chromium:680151 
TEST=emerge-reef coreboot
See that it succeeds and places the Pyro EC binary in the Pyro image, not
the Reef EC.
Signed-off-by: Simon Glass <sjg@chromium.org>

Change-Id: Iec7c1edfabb502bcf9309841e52d90a53873cf25
Reviewed-on: https://chromium-review.googlesource.com/448255
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

[modify] https://crrev.com/bb8095665b8f7330665662acf0fb10021d332678/sys-boot/coreboot/coreboot-9999.ebuild

Comment 16 by sjg@chromium.org, Mar 14 2017

Status: Fixed (was: Started)
OK this seems to work correctly now.

Sign in to add a comment