New issue
Advanced search Search tips

Issue 680150 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VrShell crashes due to bad chunk sizes in the gpu FencedAllocator

Project Member Reported by mthiesse@chromium.org, Jan 11 2017

Issue description

https://codereview.chromium.org/2615793003/ removed DeviceDisplayInfo usage from CompositorImpl, causing CompositorImpl to look at our actual display sizes.

Arbitrary display sizes can lead to texture size not aligning with chunk boundaries in the gpu FencedAllocator, causing CHECK failures like "[FATAL:mapped_memory.h(142)] Check failed: multiple % FencedAllocator::kAllocAlignment == 0."
 
Summary: VrShell crashes due to bad chunk sizes in the gpu FencedAllocator (was: VrShell crashes due to bad chunk sizes in the)
Labels: VR-FF M-57 Proj-VR-Shell
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7225c311f5be2450e84dc6f8e0548a699787bb3

commit e7225c311f5be2450e84dc6f8e0548a699787bb3
Author: mthiesse <mthiesse@chromium.org>
Date: Fri Jan 13 01:28:31 2017

CompositorImplAndroid sets a texture size that may not be aligned FencedAllocator allocation size.

This CL ensures chunk size is aligned with the FencedAllocator allocation size.

BUG= 680150 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2623223002
Cr-Commit-Position: refs/heads/master@{#443435}

[modify] https://crrev.com/e7225c311f5be2450e84dc6f8e0548a699787bb3/gpu/command_buffer/client/gles2_implementation.cc

Status: Fixed (was: Started)

Sign in to add a comment