New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680136 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add buildbot step link for the results dashboard upload

Project Member Reported by eyaich@chromium.org, Jan 11 2017

Issue description

We would like to add a link in the recipe directly to the results dashboard, similar to how the old perf recipe used to.  

This link currently exists in the stdio of the <test_suite_name> Dashboard Upload, but we would like to pull that out and add a link directly from the buildbot status page.
 
Cc: martiniss@chromium.org
Components: Speed>Benchmarks>Waterfall
Labels: -Performance-BotHealth
Owner: eyaich@chromium.org
Stephen is swarmed with other task. Reassign this back to Emily.
I have ideas about how to do this. Basically, the script is manually emitting annotations, which is strongly discouraged now. It should be dumping some data into a file, which the recipe then uses to emit annotations.

The perf dashboard upload code is used in enough places I'm not really confident that I can make this change quickly and easily. I might get around to this later.... Maybe.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/bd1e94f1663c6f8ca0d2063b3e5c1e64b45c689d

commit bd1e94f1663c6f8ca0d2063b3e5c1e64b45c689d
Author: Mike Case <mikecase@google.com>
Date: Tue Jul 18 20:55:19 2017

Add Results Dashboard link to dashboard upload step.

Currently, you can find the link by hunting through the stdout
for the upload step, but there is no link directly on the buildbot
status page. Adding link.

Change-Id: I1d88e3c47e232340ed2e8b9cf1a9c497ba8b9162
Bug: 680136
Reviewed-on: https://chromium-review.googlesource.com/576226
Commit-Queue: Michael Case <mikecase@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/bd1e94f1663c6f8ca0d2063b3e5c1e64b45c689d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_perf_test_ignore_task_failure.json
[modify] https://crrev.com/bd1e94f1663c6f8ca0d2063b3e5c1e64b45c689d/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_ignore_task_failure.json
[modify] https://crrev.com/bd1e94f1663c6f8ca0d2063b3e5c1e64b45c689d/scripts/slave/README.recipes.md
[modify] https://crrev.com/bd1e94f1663c6f8ca0d2063b3e5c1e64b45c689d/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson.json
[modify] https://crrev.com/bd1e94f1663c6f8ca0d2063b3e5c1e64b45c689d/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/bd1e94f1663c6f8ca0d2063b3e5c1e64b45c689d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test.json
[modify] https://crrev.com/bd1e94f1663c6f8ca0d2063b3e5c1e64b45c689d/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.py

Owner: mikec...@chromium.org
Status: Started (was: Untriaged)
Seems like dashboard expects mastername ChromiumPerf and not chromium.perf.

Going to quick change impl to what Stephen suggested. Just have the dashboard script return a simple Json file with the dashboard link. Should be very easy change, and will basically guarantee that we have right link.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2a78f892f17ab7884ad722e96e3cdd872536902d

commit 2a78f892f17ab7884ad722e96e3cdd872536902d
Author: Mike Case <mikecase@google.com>
Date: Thu Jul 20 17:04:11 2017

Correct Results Dashboard link for perf bots.

Changing implementation. Instead of constructing the dashboard link
ourselves, adding new arguement to upload_perf_dashboard_results.py
which returns the link in a super simple JSON file.

Bug:680136
Change-Id: I0801768c69e27f2da8be304005c08e8125b5e3fb
Reviewed-on: https://chromium-review.googlesource.com/578320
Commit-Queue: Michael Case <mikecase@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/2a78f892f17ab7884ad722e96e3cdd872536902d/scripts/slave/unittests/results_dashboard_test.py
[modify] https://crrev.com/2a78f892f17ab7884ad722e96e3cdd872536902d/scripts/slave/upload_perf_dashboard_results.py
[modify] https://crrev.com/2a78f892f17ab7884ad722e96e3cdd872536902d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_perf_test_ignore_task_failure.json
[modify] https://crrev.com/2a78f892f17ab7884ad722e96e3cdd872536902d/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_ignore_task_failure.json
[modify] https://crrev.com/2a78f892f17ab7884ad722e96e3cdd872536902d/scripts/slave/results_dashboard.py
[modify] https://crrev.com/2a78f892f17ab7884ad722e96e3cdd872536902d/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson.json
[modify] https://crrev.com/2a78f892f17ab7884ad722e96e3cdd872536902d/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/2a78f892f17ab7884ad722e96e3cdd872536902d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test.json

Sign in to add a comment