Issue metadata
Sign in to add a comment
|
App crashes on deleting an account from any google app and relaunching chrome dev. |
||||||||||||||||||||||
Issue descriptionApp Version: 56.0.2924.58 dev iOS Version: 9.3.5, iOS 10 Device: iPhone,iPad Precondition : 1.Have 2 to 3 accounts saved Steps to reproduce: 1. Launch chrome 2. Tap on Menu > Settings > Sign in to chrome. 3. Send the app to background in the account list screen. 4. Launch any google app (say : chrome canary) and sign in to chrome. 5. Delete any account from the list in canary build. 6. Relaunch chrome dev. 7. Tap on the deleted account or scroll the screen Observed results: App crashes. Expected results: App should not crash Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: NA Bug reproducible on current stable build (App Version, iOS Version): No in M55.0.2883.79 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes in 56.0.2924.58 dev Link to Video : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpNXc2allOY2NWMzQ/view?usp=sharing Stack trace : https://crash.corp.google.com/browse?stbtiq=6043c9a580000000 Console log : Thread 0 CRASHED [EXC_SOFTWARE / UNCAUGHT_NS_EXCEPTION @ 0x000000018cf4e1c0 ] MAGIC SIGNATURE THREAD Stack Quality81%Show frame trust levels 0x000000018cf4e1c0 (CoreFoundation + 0x0012f1c0 ) __exceptionPreprocess 0x000000018b988558 (libobjc.A.dylib + 0x00008558 ) objc_exception_throw 0x000000018ce2a4a8 (CoreFoundation + 0x0000b4a8 ) -[__NSArrayM objectAtIndex:] 0x0000000100270c1c (Chrome -collection_view_model.mm:134 ) -[CollectionViewModel itemTypeForIndexPath:] 0x0000000100355dec (Chrome -signin_account_selector_view_controller.mm:323 ) -[SigninAccountSelectorViewController collectionView:hidesInkViewAtIndexPath:] 0x00000001000c29c4 (Chrome -MDCCollectionViewController.m:336 ) -[MDCCollectionViewController collectionView:shouldHighlightItemAtIndexPath:] 0x0000000192fbfdfc (UIKit + 0x00226dfc ) -[UICollectionView _highlightItemAtIndexPath:animated:scrollPosition:notifyDelegate:] 0x0000000192fbf8a4 (UIKit + 0x002268a4 ) -[UICollectionView touchesBegan:withEvent:] 0x0000000192f3ce80 (UIKit + 0x001a3e80 ) forwardTouchMethod 0x0000000192f3cd1c (UIKit + 0x001a3d1c ) -[UIResponder touchesBegan:withEvent:] 0x0000000192f3ce80 (UIKit + 0x001a3e80 ) forwardTouchMethod 0x0000000192f3cd1c (UIKit + 0x001a3d1c ) -[UIResponder touchesBegan:withEvent:] 0x000000019336ec8c (UIKit + 0x005d5c8c ) _UIGestureEnvironmentSortAndSendDelayedTouches 0x000000019336ad24 (UIKit + 0x005d1d24 ) _UIGestureEnvironmentUpdate 0x000000019336a844 (UIKit + 0x005d1844 ) -[UIGestureEnvironment _deliverEvent:toGestureRecognizers:usingBlock:] 0x0000000193369b00 (UIKit + 0x005d0b00 ) -[UIGestureEnvironment _updateGesturesForEvent:window:] 0x0000000192dd8a40 (UIKit + 0x0003fa40 ) -[UIWindow sendEvent:] 0x0000000192da9528 (UIKit + 0x00010528 ) -[UIApplication sendEvent:] 0x0000000193596a50 (UIKit + 0x007fda50 ) __dispatchPreprocessedEventFromEventQueue 0x00000001935904b8 (UIKit + 0x007f74b8 ) __handleEventQueue 0x000000018cefc274 (CoreFoundation + 0x000dd274 ) __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 0x000000018cefbbbc (CoreFoundation + 0x000dcbbc ) __CFRunLoopDoSources0 0x000000018cef97bc (CoreFoundation + 0x000da7bc ) __CFRunLoopRun 0x000000018ce28044 (CoreFoundation + 0x00009044 ) CFRunLoopRunSpecific 0x000000018e8ae194 (GraphicsServices + 0x0000c194 ) GSEventRunModal 0x0000000192e142f8 (UIKit + 0x0007b2f8 ) -[UIApplication _run] 0x0000000192e0f030 (UIKit + 0x00076030 ) UIApplicationMain 0x000000010006da34 (Chrome -chrome_exe_main.mm:79 ) main 0x000000018be0c5b4 (libdyld.dylib + 0x000045b4 ) start
,
Jan 12 2017
Hmm, it appears we're correctly reloading the model but not its associated collection view. This should be an easy fix.
,
Jan 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bba0e6692f70aa800b78bedcba9bc3d8ae6fff26 commit bba0e6692f70aa800b78bedcba9bc3d8ae6fff26 Author: bzanotti <bzanotti@chromium.org> Date: Thu Jan 12 15:53:52 2017 [Signin iOS] Reload the Account Selector screen when identities change The model was already being reloaded but not the the collection view, this could cause crashes as the collection view and its model were not in sync anymore. The collection view is now reloaded as well. BUG= 680098 Review-Url: https://codereview.chromium.org/2622103005 Cr-Commit-Position: refs/heads/master@{#443243} [modify] https://crrev.com/bba0e6692f70aa800b78bedcba9bc3d8ae6fff26/ios/chrome/browser/ui/authentication/signin_account_selector_view_controller.mm
,
Jan 12 2017
,
Jan 12 2017
This bug requires manual review: Less than 2 weeks to go before AppStore submit on M56 Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 12 2017
pmadalla@ please verify this in the next canary.
,
Jan 13 2017
Verified on latest chrome canary version 57.0.2980.0 on iPhone 7 plus with iOS 10.2, following the steps mentioned in comment #0. No crashes observed. Looks good.
,
Jan 13 2017
,
Jan 16 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/d0503f78e3db26e1b7a17b3be27126187d94412e commit d0503f78e3db26e1b7a17b3be27126187d94412e Author: Benoit Zanotti <bzanotti@google.com> Date: Mon Jan 16 13:20:29 2017
,
Jan 18 2017
Verified on latest chrome beta version 56.0.2924.66 on iPhone 6 plus with iOS 10.2.1 and iPad Air with iOS 10.1.1, following the steps mentioned in comment #0. No crashes observed. Looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by justincohen@chromium.org
, Jan 11 2017Owner: bzanotti@chromium.org
Status: Assigned (was: Untriaged)