Regression: Unnecessary 'chrome://welcome/?variant=everywhere' page gets open by default in supervised user.
Reported by
rk...@etouch.net,
Jan 11 2017
|
|||||||||||
Issue descriptionChrome Version: 57.0.2978.0 Revision e2867aed46b3f00f3735d310144d6ef638f8be1a-refs/heads/master@{#442756} OS: Windows (7,8,10), Linux (14.04 LTS) Precondition: Sign in to chrome with valid credentials. What steps will reproduce the problem? (1) Launch chrome, go to ‘chrome://settings', from ‘People’ section add a Supervised user. (2) Switch to supervised user,and observe. Actual: Unnecessary chrome://welcome/?variant=everywhere page gets open by default in supervised user(as we can not sign in into supervised user). Expected: chrome://welcome/?variant=everywhere page should not open in supervised user. This is a regression issue, broken in 'M-57', will soon update the other info: Good Build: 57.0.2977.0 Bad Build: 57.0.2978.0
,
Jan 11 2017
The changelist is making small UI changes to ios-only code. It is unrelated to this issue.
,
Jan 11 2017
With respect to comment 2: Suspecting: r442547 ? @weisert: Please help me to reassign this issue, if your change is not cause for it.
,
Jan 11 2017
rkote: I don't see how this relates to me.
,
Jan 11 2017
The "variant=everywhere" seems to come from startup_tab_provider, which was touched by tmartino in r442712.
,
Jan 11 2017
This is related to my change. Investigating.
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a27abc1cedbf0f585c5e2830beadebf1cc2b52cb commit a27abc1cedbf0f585c5e2830beadebf1cc2b52cb Author: tmartino <tmartino@chromium.org> Date: Fri Jan 13 00:48:57 2017 Adding check to ensure onboarding content is not shown to supervised users. BUG= 680076 Review-Url: https://codereview.chromium.org/2623253002 Cr-Commit-Position: refs/heads/master@{#443420} [modify] https://crrev.com/a27abc1cedbf0f585c5e2830beadebf1cc2b52cb/chrome/browser/ui/startup/startup_tab_provider.cc [modify] https://crrev.com/a27abc1cedbf0f585c5e2830beadebf1cc2b52cb/chrome/browser/ui/startup/startup_tab_provider.h [modify] https://crrev.com/a27abc1cedbf0f585c5e2830beadebf1cc2b52cb/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
,
Jan 17 2017
Verified on Mac OS 10.12.2 ,ubuntu 14.04 and windows 7 using chrome dev M57 #57.0.2984.0 and issue is fixed. chrome://welcome/?variant=everywhere page is not opened in supervised user. Attached screencast for reference. Adding TE-Verified Labels. Thanks!
,
Jan 17 2017
Adding blocker label, since this was a recent regression.
,
Jan 17 2017
Requesting merge to M56. This fix is verified.
,
Jan 17 2017
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL to branch 2924 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 18 2017
Unable to merge for M56. Moving back to M57. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by rk...@etouch.net
, Jan 11 2017Owner: lod@chromium.org
Status: Assigned (was: Unconfirmed)