New issue
Advanced search Search tips

Issue 680056 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Uninitialized scalar fields in hpack code

Reported by tmora...@akamai.com, Jan 11 2017

Issue description

Chrome Version       : 55.0.2880.2 (present in master too)

A couple of class members are not initialized in several classes in net/spdy/hpack code. Attaching a patch.
 
hpack.patch
2.1 KB Download
Components: Internals>Network>HTTP2
Status: Untriaged (was: Unconfirmed)
Similar to  Issue 680052 , we'll need a CLA before we can take the patch.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a73f729a9a20ca911ced2e9896bf3c5aad95fe27

commit a73f729a9a20ca911ced2e9896bf3c5aad95fe27
Author: bnc <bnc@chromium.org>
Date: Mon Feb 27 21:17:17 2017

Format HpackEntry initializer lists.

This is a follow-up to https://crrev.com/2663203002.  While
https://crrev.com/2663203002 is properly formatted, it turns out that the
internally used clang-format is stricter.  This CL changes formatting to a style
that is accepted by both Chromium's clang-format and the internal one.

BUG=680056

Review-Url: https://codereview.chromium.org/2718093002
Cr-Commit-Position: refs/heads/master@{#453340}

[modify] https://crrev.com/a73f729a9a20ca911ced2e9896bf3c5aad95fe27/net/spdy/hpack/hpack_decoder.cc
[modify] https://crrev.com/a73f729a9a20ca911ced2e9896bf3c5aad95fe27/net/spdy/hpack/hpack_entry.cc

Sign in to add a comment