Uninitialized scalar fields in hpack code
Reported by
tmora...@akamai.com,
Jan 11 2017
|
|
Issue descriptionChrome Version : 55.0.2880.2 (present in master too) A couple of class members are not initialized in several classes in net/spdy/hpack code. Attaching a patch.
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55427df29775cad74aa35dec95c6a6a39c22bf38 commit 55427df29775cad74aa35dec95c6a6a39c22bf38 Author: tmoravec <tmoravec@akamai.com> Date: Fri Feb 24 22:26:41 2017 Fix uninitialized fields in hpack code. Author added to AUTHORS file in Rietveld issue 2669443003 BUG=680056 R=rch@chromium.org Review-Url: https://codereview.chromium.org/2663203002 Cr-Commit-Position: refs/heads/master@{#452955} [modify] https://crrev.com/55427df29775cad74aa35dec95c6a6a39c22bf38/net/spdy/hpack/hpack_decoder.cc [modify] https://crrev.com/55427df29775cad74aa35dec95c6a6a39c22bf38/net/spdy/hpack/hpack_entry.cc [modify] https://crrev.com/55427df29775cad74aa35dec95c6a6a39c22bf38/net/spdy/hpack/hpack_huffman_table.cc
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a73f729a9a20ca911ced2e9896bf3c5aad95fe27 commit a73f729a9a20ca911ced2e9896bf3c5aad95fe27 Author: bnc <bnc@chromium.org> Date: Mon Feb 27 21:17:17 2017 Format HpackEntry initializer lists. This is a follow-up to https://crrev.com/2663203002. While https://crrev.com/2663203002 is properly formatted, it turns out that the internally used clang-format is stricter. This CL changes formatting to a style that is accepted by both Chromium's clang-format and the internal one. BUG=680056 Review-Url: https://codereview.chromium.org/2718093002 Cr-Commit-Position: refs/heads/master@{#453340} [modify] https://crrev.com/a73f729a9a20ca911ced2e9896bf3c5aad95fe27/net/spdy/hpack/hpack_decoder.cc [modify] https://crrev.com/a73f729a9a20ca911ced2e9896bf3c5aad95fe27/net/spdy/hpack/hpack_entry.cc |
|
►
Sign in to add a comment |
|
Comment 1 by rsleevi@chromium.org
, Jan 13 2017Status: Untriaged (was: Unconfirmed)