New issue
Advanced search Search tips

Issue 680055 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Unitialized field in spdy_headers_block_parser.cc

Reported by tmora...@akamai.com, Jan 11 2017

Issue description

Chrome Version       : 55.0.2880.2 (present in master too)

Class member next_field_length_ is not initialized in spdy_headers_block_parser.cc. Attaching a patch.
 
spdy_headers_block_parser.cc
515 bytes View Download
Components: Internals>Network
Status: Untriaged (was: Unconfirmed)

Comment 2 by mmenke@chromium.org, Jan 11 2017

Components: -Internals>Network Internals>Network>HTTP2

Comment 3 by b...@chromium.org, Jan 12 2017

Cc: b...@chromium.org
Why is this an issue?  The state machine guarantees that ParseFieldLength() is called, setting next_field_lenght_, before its value is used.

Comment 4 by b...@chromium.org, Jan 12 2017

Labels: Needs-Feedback

Comment 5 by mmenke@chromium.org, Jan 12 2017

The preferred style is to initialize everything in the constructor (Even variables that won't be used immediately).  It doesn't look like it's in the current Google style guide (Not sure if it was there at one point or not), but still tends to be preferred style.

Comment 6 by b...@chromium.org, Jan 13 2017

Re #5: I understand.  Then let's do this.

Re OP: Please follow steps at https://www.chromium.org/developers/contributing-code, as mentioned at  issue 680052 .  Thank you.

Comment 7 by tmora...@akamai.com, Jan 31 2017

spdy_headers_block_parser.cc doesn't exist in master anymore, so this issue is meaningless now. We can close it now.

Comment 8 by b...@chromium.org, Jan 31 2017

Status: WontFix (was: Untriaged)

Sign in to add a comment