Unitialized field in spdy_headers_block_parser.cc
Reported by
tmora...@akamai.com,
Jan 11 2017
|
|||||
Issue descriptionChrome Version : 55.0.2880.2 (present in master too) Class member next_field_length_ is not initialized in spdy_headers_block_parser.cc. Attaching a patch.
,
Jan 11 2017
,
Jan 12 2017
Why is this an issue? The state machine guarantees that ParseFieldLength() is called, setting next_field_lenght_, before its value is used.
,
Jan 12 2017
,
Jan 12 2017
The preferred style is to initialize everything in the constructor (Even variables that won't be used immediately). It doesn't look like it's in the current Google style guide (Not sure if it was there at one point or not), but still tends to be preferred style.
,
Jan 13 2017
Re #5: I understand. Then let's do this. Re OP: Please follow steps at https://www.chromium.org/developers/contributing-code, as mentioned at issue 680052 . Thank you.
,
Jan 31 2017
spdy_headers_block_parser.cc doesn't exist in master anymore, so this issue is meaningless now. We can close it now.
,
Jan 31 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dglazkov@chromium.org
, Jan 11 2017Status: Untriaged (was: Unconfirmed)