New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680054 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : in devtools, Auditing process does not get completed when running an Audit for the first time.

Reported by yfulgaon...@etouch.net, Jan 11 2017

Issue description

Chrome Version : 57.0.2978.0 (Official Build) e2867aed46b3f00f3735d310144d6ef638f8be1a-refs/heads/master@{#442756} 32/64 bit
OS : Mac(10.12.1, 10.11.6, 10.12), Windows(7,8,10), Linux 14.04

Pre-condition : Freshly install chrome.

Test URL : www.google.com

What steps will reproduce the problem?
1. Launch chrome, navigate to above URL, open devtools and click on ’Toggle device toolbar’ button.
2. In devtools, navigate to ‘Audits’ tab and click on ‘Run’ button, observe.

Actual : ‘Audit’ progress bar get stuck and auditing process does not get completed.
Expected : ‘Audit’ process should run as expected and it should not get stuck while running an audit.

This is a regression issue broken in ‘M-57’, below is the Manual Regression range and will soon update other info.
Good build : 57.0.2977.0
Bad build : 57.0.2978.0

Note : Issue is also reproducible on chrome://settings page.
 
Actual_devtool_Audits.mov
6.1 MB Download
Expected_devtools_Audits.mov
5.9 MB Download
Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: allada@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 57.0.2977.0,  Revision Range -442447
Bad build  : 57.0.2978.0,  Revision Range -442756

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/41afe676df04303cb9b0f67e4765b150969d3899..8a062852968b7a329e313ab789bc69856ad8af29


The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/8a062852968b7a329e313ab789bc69856ad8af29

From the above CL suspecting the below change
---------------------------
Review-Url: https://codereview.chromium.org/2626553002

allada@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Gentle Ping !!

As it is marked as ReleaseBlock-Stable, could we get any update on this issue.

Thanks..
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b078604227b8dd8864657954161097abc3091ee

commit 5b078604227b8dd8864657954161097abc3091ee
Author: allada <allada@chromium.org>
Date: Fri Jan 20 03:05:47 2017

[Devtools] Fixed url in Audits

This patch fixes areas where NetworkRequest.url conversion was missed
because file lacked doctype.

R=dgozman,luoe
BUG= 680054 

Review-Url: https://codereview.chromium.org/2627073003
Cr-Commit-Position: refs/heads/master@{#444962}

[modify] https://crrev.com/5b078604227b8dd8864657954161097abc3091ee/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js

Comment 5 by allada@chromium.org, Jan 20 2017

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.

Comment 7 by gov...@chromium.org, Jan 23 2017

Labels: -Merge-TBD Merge-Request-57
Cl listed at #4 is {#444962} and M57 is branched Chromium at revision {#444943}, so merge is needed to M57. Hence, adding Merge-Request-57 label.
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 23 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by gov...@chromium.org, Jan 23 2017

Please merge your change to M57 branch 2987 ASAP. So we can pick it for Dev release on Tuesday (02/24).
Labels: -Merge-Approved-57 merge-merged-2987
Labels: TE-Verified-M57 TE-Verified-57.0.2987.8
Tested the issue on Latest Dev# 57.0.2987.8 using Windows, Mac and Linux and is not reproducible.
Able to record the audits successfully. Hence adding TE-Verified labels.
Note: Adding screencast for reference.
Thank You.
680054.mov
2.0 MB Download

Comment 13 by kayce@google.com, Jan 26 2017

Labels: DevTools-Release-Notes-Bug

Comment 14 by kayce@google.com, Feb 7 2017

Labels: -DevTools-Release-Notes-Bug

Sign in to add a comment