Unchecked return value and uninitialized field in quic_framer.cc
Reported by
tmora...@akamai.com,
Jan 11 2017
|
||||||
Issue descriptionChrome Version : 55.0.2880.2 (present in master too) Return values from writer->Write* are always checked, except for one case in quic_framer.cc. Given that we mostly check it, I assume these functions can fail and we should always do it. There's also a minor issue that last_version_tag_ is not initialized in the constructor. We might fix it both at once. Attaching a patch.
,
Feb 2 2017
Archiving due to lack of activity. Feel free to reopen once you are ready to submit the patch according to the instructions in comment #1.
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67b01e166dce06ce927303403034b6a228d7481d commit 67b01e166dce06ce927303403034b6a228d7481d Author: tmoravec <tmoravec@akamai.com> Date: Fri Feb 24 21:28:09 2017 Fix unchecked return value and uninitialized field. BUG= 680052 R=rch@chromium.org Review-Url: https://codereview.chromium.org/2669443003 Cr-Commit-Position: refs/heads/master@{#452928} [modify] https://crrev.com/67b01e166dce06ce927303403034b6a228d7481d/AUTHORS [modify] https://crrev.com/67b01e166dce06ce927303403034b6a228d7481d/net/quic/core/quic_framer.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rsleevi@chromium.org
, Jan 13 2017Components: Internals>Network>QUIC
Labels: Needs-Feedback
Status: Untriaged (was: Unconfirmed)