New issue
Advanced search Search tips

Issue 680049 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 631966



Sign in to add a comment

Add histograms to resource_prefetch_predictor

Project Member Reported by alexilin@chromium.org, Jan 11 2017

Issue description

Tracking bug for adding histograms to resource_prefetch_predictor. It needs to be done before finch trial launch.
 
Cc: pasko@chromium.org lizeb@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27032ce5253ef29711946ce32a68f3ce0ab6298f

commit 27032ce5253ef29711946ce32a68f3ce0ab6298f
Author: alexilin <alexilin@chromium.org>
Date: Fri Jan 13 09:26:43 2017

predictors: Add ResourcePrefetchPredictor database readiness histogram.

Predictor needs time to learn about user favorites pages. Special age metric is
introduced to show that the predictor database is large enough. Metric is
"large" when most users have learned about most of their pages, and "small"
otherwise.

BUG= 680049 

Review-Url: https://codereview.chromium.org/2625063002
Cr-Commit-Position: refs/heads/master@{#443521}

[modify] https://crrev.com/27032ce5253ef29711946ce32a68f3ce0ab6298f/chrome/browser/predictors/resource_prefetch_predictor.cc
[modify] https://crrev.com/27032ce5253ef29711946ce32a68f3ce0ab6298f/chrome/browser/predictors/resource_prefetch_predictor.h
[modify] https://crrev.com/27032ce5253ef29711946ce32a68f3ce0ab6298f/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5c04a333854a4e7f36dd9cdf8d8b2ac2b083672

commit f5c04a333854a4e7f36dd9cdf8d8b2ac2b083672
Author: lizeb <lizeb@chromium.org>
Date: Mon Jan 23 11:30:06 2017

predictors: Add precision / recall histograms for speculative prefetch.

When the prefetch predictor is learning, log the ratios of resources
correctly predicted compared to the predicted and actual resources. This
is to assess the effectiveness of learning in the wild.

BUG= 680049 

Review-Url: https://codereview.chromium.org/2640343002
Cr-Commit-Position: refs/heads/master@{#445354}

[modify] https://crrev.com/f5c04a333854a4e7f36dd9cdf8d8b2ac2b083672/chrome/browser/predictors/resource_prefetch_predictor.cc
[modify] https://crrev.com/f5c04a333854a4e7f36dd9cdf8d8b2ac2b083672/chrome/browser/predictors/resource_prefetch_predictor.h
[modify] https://crrev.com/f5c04a333854a4e7f36dd9cdf8d8b2ac2b083672/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
[modify] https://crrev.com/f5c04a333854a4e7f36dd9cdf8d8b2ac2b083672/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/666d5ac67f9172f965581c314de225737ba95d7d

commit 666d5ac67f9172f965581c314de225737ba95d7d
Author: alexilin <alexilin@chromium.org>
Date: Tue Jan 24 14:39:48 2017

predictors: Collect page load metrics for ResourcePrefetchPredictor.

This CL adds ResourcePrefetchPredictorPageLoadMetricsObserver that allows to
collect page load metrics only for prefetchable pages.
For now, the page is considered prefetchable if it has resources in the
predictor DB that could be used for prefetching. This is subject to change
depending on triggering selection for the trial.

BUG= 680049 

Review-Url: https://codereview.chromium.org/2632503005
Cr-Commit-Position: refs/heads/master@{#445723}

[modify] https://crrev.com/666d5ac67f9172f965581c314de225737ba95d7d/chrome/browser/BUILD.gn
[add] https://crrev.com/666d5ac67f9172f965581c314de225737ba95d7d/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc
[add] https://crrev.com/666d5ac67f9172f965581c314de225737ba95d7d/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h
[add] https://crrev.com/666d5ac67f9172f965581c314de225737ba95d7d/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/666d5ac67f9172f965581c314de225737ba95d7d/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
[modify] https://crrev.com/666d5ac67f9172f965581c314de225737ba95d7d/chrome/browser/predictors/resource_prefetch_predictor.cc
[modify] https://crrev.com/666d5ac67f9172f965581c314de225737ba95d7d/chrome/browser/predictors/resource_prefetch_predictor.h
[modify] https://crrev.com/666d5ac67f9172f965581c314de225737ba95d7d/chrome/test/BUILD.gn
[modify] https://crrev.com/666d5ac67f9172f965581c314de225737ba95d7d/tools/metrics/histograms/histograms.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/075c5d682d0b00fb8e311a23990082567c8b98e3

commit 075c5d682d0b00fb8e311a23990082567c8b98e3
Author: alexilin <alexilin@chromium.org>
Date: Thu Jan 26 12:44:11 2017

predictors: Add prefetcher histograms for speculative prefetch.

Prefetching is most useful when a prefetched resource isn't in cache or needs
to be revalidated. This CL adds a histogram that allows us to estimate how
often the predictor prefetches resources from the network and how often from
the cache. This CL also adds histograms for a single prefetcher instance:
count of prefeched resources and amount of consumed KB.

BUG= 680049 

Review-Url: https://codereview.chromium.org/2654913004
Cr-Commit-Position: refs/heads/master@{#446309}

[modify] https://crrev.com/075c5d682d0b00fb8e311a23990082567c8b98e3/chrome/browser/predictors/resource_prefetcher.cc
[modify] https://crrev.com/075c5d682d0b00fb8e311a23990082567c8b98e3/chrome/browser/predictors/resource_prefetcher.h
[modify] https://crrev.com/075c5d682d0b00fb8e311a23990082567c8b98e3/chrome/browser/predictors/resource_prefetcher_unittest.cc
[modify] https://crrev.com/075c5d682d0b00fb8e311a23990082567c8b98e3/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c374785047c1c350a944dc1836cc254c27cc0329

commit c374785047c1c350a944dc1836cc254c27cc0329
Author: alexilin <alexilin@chromium.org>
Date: Thu Feb 09 17:18:16 2017

predictors: Add subresources count and prefetching duration histograms.

This CL adds two more histograms for ResourcePrefetchPredictor trial.
ResourcePrefetchPredictor.LearningCount shows how many useful subresources are
contained in the database during prefetch predictor learning.
ResourcePrefetchPredictor.PrefetchingDuration allows to estimate time window
available for prefetching.

BUG= 680049 

Review-Url: https://codereview.chromium.org/2683633004
Cr-Commit-Position: refs/heads/master@{#449331}

[modify] https://crrev.com/c374785047c1c350a944dc1836cc254c27cc0329/chrome/browser/predictors/resource_prefetch_predictor.cc
[modify] https://crrev.com/c374785047c1c350a944dc1836cc254c27cc0329/chrome/browser/predictors/resource_prefetch_predictor.h
[modify] https://crrev.com/c374785047c1c350a944dc1836cc254c27cc0329/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
[modify] https://crrev.com/c374785047c1c350a944dc1836cc254c27cc0329/tools/metrics/histograms/histograms.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e4491eac73425489384c1428b17415e7dcec8e2

commit 2e4491eac73425489384c1428b17415e7dcec8e2
Author: lizeb <lizeb@chromium.org>
Date: Thu Feb 16 11:46:48 2017

predictors: Add prefetching hit/miss histograms.

When the resource_prefetch_predictor triggers a prefetch, record how
many resources were used / not used (hits and misses), and the pattern
of these (in cache, or not in cache). For the resources that are not in
the cache, record the amount of data prefetched and wasted.

This also assumes that a prefetch older than 5 minutes is wasted.

BUG= 680049 

Review-Url: https://codereview.chromium.org/2688633002
Cr-Commit-Position: refs/heads/master@{#450935}

[modify] https://crrev.com/2e4491eac73425489384c1428b17415e7dcec8e2/chrome/browser/predictors/resource_prefetch_predictor.cc
[modify] https://crrev.com/2e4491eac73425489384c1428b17415e7dcec8e2/chrome/browser/predictors/resource_prefetch_predictor.h
[modify] https://crrev.com/2e4491eac73425489384c1428b17415e7dcec8e2/chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc
[modify] https://crrev.com/2e4491eac73425489384c1428b17415e7dcec8e2/chrome/browser/predictors/resource_prefetcher.cc
[modify] https://crrev.com/2e4491eac73425489384c1428b17415e7dcec8e2/chrome/browser/predictors/resource_prefetcher.h
[modify] https://crrev.com/2e4491eac73425489384c1428b17415e7dcec8e2/chrome/browser/predictors/resource_prefetcher_manager.cc
[modify] https://crrev.com/2e4491eac73425489384c1428b17415e7dcec8e2/chrome/browser/predictors/resource_prefetcher_manager.h
[modify] https://crrev.com/2e4491eac73425489384c1428b17415e7dcec8e2/chrome/browser/predictors/resource_prefetcher_unittest.cc
[modify] https://crrev.com/2e4491eac73425489384c1428b17415e7dcec8e2/tools/metrics/histograms/histograms.xml

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f82a5a8d7a819348f63dfd94e08901a5808645f1

commit f82a5a8d7a819348f63dfd94e08901a5808645f1
Author: alexilin <alexilin@chromium.org>
Date: Mon Feb 27 13:15:50 2017

predictors: Add RedirectStatus histogram + fix redirects related bug.

This CL adds a new enumeration histogram that allows to keep track of success of
redirect predictions in the ResourcePrefetchPredictor.
Also it fixes a bug with incorrect reporting prefetch and prediction accuracy
histograms in presence of redirect. ResourcePrefetchPredictor uses the first url
in the redirect chain to trigger prefetch so it has to use the same url when it
reports accuracy histograms.

BUG= 680049 

Review-Url: https://codereview.chromium.org/2719533002
Cr-Commit-Position: refs/heads/master@{#453197}

[modify] https://crrev.com/f82a5a8d7a819348f63dfd94e08901a5808645f1/chrome/browser/predictors/resource_prefetch_predictor.cc
[modify] https://crrev.com/f82a5a8d7a819348f63dfd94e08901a5808645f1/chrome/browser/predictors/resource_prefetch_predictor.h
[modify] https://crrev.com/f82a5a8d7a819348f63dfd94e08901a5808645f1/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
[modify] https://crrev.com/f82a5a8d7a819348f63dfd94e08901a5808645f1/tools/metrics/histograms/histograms.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e19c9d4d1268cf7f9048ac14825fe0ac4785740

commit 1e19c9d4d1268cf7f9048ac14825fe0ac4785740
Author: alexilin <alexilin@chromium.org>
Date: Tue Mar 21 15:50:40 2017

predictors: Fix incorrect page load metrics histogram name.

s/ParseTiming/PaintTiming
histograms.xml contains correct (PaintTiming) name.

BUG= 680049 

Review-Url: https://codereview.chromium.org/2761223003
Cr-Commit-Position: refs/heads/master@{#458426}

[modify] https://crrev.com/1e19c9d4d1268cf7f9048ac14825fe0ac4785740/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e19c9d4d1268cf7f9048ac14825fe0ac4785740

commit 1e19c9d4d1268cf7f9048ac14825fe0ac4785740
Author: alexilin <alexilin@chromium.org>
Date: Tue Mar 21 15:50:40 2017

predictors: Fix incorrect page load metrics histogram name.

s/ParseTiming/PaintTiming
histograms.xml contains correct (PaintTiming) name.

BUG= 680049 

Review-Url: https://codereview.chromium.org/2761223003
Cr-Commit-Position: refs/heads/master@{#458426}

[modify] https://crrev.com/1e19c9d4d1268cf7f9048ac14825fe0ac4785740/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc

Labels: Merge-Request-58
Requesting a merge to M58.
Rationale: incorrect histogram name causes troubles in finch experiment.
Project Member

Comment 12 by sheriffbot@chromium.org, Mar 22 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 22 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed352688a6ed24c81afe8528ed491bf541d615c9

commit ed352688a6ed24c81afe8528ed491bf541d615c9
Author: alexilin <alexilin@chromium.org>
Date: Wed Mar 22 17:50:00 2017

predictors: Fix incorrect page load metrics histogram name.

s/ParseTiming/PaintTiming
histograms.xml contains correct (PaintTiming) name.

BUG= 680049 
TBR=lizeb@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2761223003
Cr-Commit-Position: refs/heads/master@{#458426}
(cherry picked from commit 1e19c9d4d1268cf7f9048ac14825fe0ac4785740)

Review-Url: https://codereview.chromium.org/2764393003
Cr-Commit-Position: refs/branch-heads/3029@{#362}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/ed352688a6ed24c81afe8528ed491bf541d615c9/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60ae8b467eae2696d4df9f87616b381dcaaf02b8

commit 60ae8b467eae2696d4df9f87616b381dcaaf02b8
Author: alexilin <alexilin@chromium.org>
Date: Mon Mar 27 15:03:30 2017

predictors: Fix incorrect histogram name.

Add Experimental suffix for FirstMeaningfulPaint histogram.
histograms.xml already contains correct name.

BUG= 680049 

Review-Url: https://codereview.chromium.org/2775243002
Cr-Commit-Position: refs/heads/master@{#459783}

[modify] https://crrev.com/60ae8b467eae2696d4df9f87616b381dcaaf02b8/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc

Labels: -Hotlist-Merge-Approved -merge-merged-3029 Merge-Request-58
Requesting one more merge to M58.
Rationale: incorrect histogram name causes troubles in finch experiment. Sorry, it wasn't fixed completely the first time.
Project Member

Comment 16 by sheriffbot@chromium.org, Mar 28 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 28 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eadc96ac27f781e1be1e9efc5b4aa9ac19fd3e9a

commit eadc96ac27f781e1be1e9efc5b4aa9ac19fd3e9a
Author: alexilin <alexilin@chromium.org>
Date: Tue Mar 28 16:36:09 2017

predictors: Fix incorrect histogram name.

Add Experimental suffix for FirstMeaningfulPaint histogram.
histograms.xml already contains correct name.

BUG= 680049 
TBR=lizeb@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2775243002
Cr-Commit-Position: refs/heads/master@{#459783}
(cherry picked from commit 60ae8b467eae2696d4df9f87616b381dcaaf02b8)

Review-Url: https://codereview.chromium.org/2779933003
Cr-Commit-Position: refs/branch-heads/3029@{#451}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/eadc96ac27f781e1be1e9efc5b4aa9ac19fd3e9a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc

Status: Archived (was: Assigned)

Sign in to add a comment