New issue
Advanced search Search tips
Starred by 16 users
Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 788593



Sign in to add a comment
Implement "module" workers
Project Member Reported by nhiroki@chromium.org, Jan 11 2017 Back to list
Specs of Dedicated/Shared/ServiceWorkers define "module" type.

  let worker = new Worker("worker.js", { type: "module" });

In this type, worker scripts are loaded as ES6 modules and import statement is available on the worker contexts. If the second parameter is omitted, worker scripts are loaded as plain scripts as usual ("classic" type).

Spec of Dedicated/SharedWorkers:
https://html.spec.whatwg.org/multipage/workers.html#module-worker-example

Spec of ServiceWorkers (see "type" in the section):
https://w3c.github.io/ServiceWorker/#service-worker-concept
 
 issue 627945  is for worklets.
Comment 2 by neis@chromium.org, May 26 2017
Cc: neis@chromium.org
 Issue 739764  has been merged into this issue.
Cc: tzik@chromium.org
Relevant spec discussion:
"How can we use SW module link in backward-compatible manner?"
https://github.com/w3c/ServiceWorker/issues/1186
Project Member Comment 5 by bugdroid1@chromium.org, Oct 4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/251d15052fedb579c071e9fe9b3d971b35c52214

commit 251d15052fedb579c071e9fe9b3d971b35c52214
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Wed Oct 04 08:46:29 2017

Worker: Clean up DedicatedWorker initialization

This is just a cleanup and doesn't change behavior.

The main change is to resolve a script URL before creating a DedicatedWorker
instance so that the instance doesn't take care of the case where the URL
resolution fails and the code path becomes simpler.

Bug: 680046
Change-Id: I439716e7cf562a1e71aafd453a76071179c9194c
Reviewed-on: https://chromium-review.googlesource.com/700094
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506339}
[modify] https://crrev.com/251d15052fedb579c071e9fe9b3d971b35c52214/third_party/WebKit/Source/core/workers/AbstractWorker.cpp
[modify] https://crrev.com/251d15052fedb579c071e9fe9b3d971b35c52214/third_party/WebKit/Source/core/workers/AbstractWorker.h
[modify] https://crrev.com/251d15052fedb579c071e9fe9b3d971b35c52214/third_party/WebKit/Source/core/workers/DedicatedWorker.cpp
[modify] https://crrev.com/251d15052fedb579c071e9fe9b3d971b35c52214/third_party/WebKit/Source/core/workers/DedicatedWorker.h
[modify] https://crrev.com/251d15052fedb579c071e9fe9b3d971b35c52214/third_party/WebKit/Source/core/workers/SharedWorker.cpp

Owner: nhiroki@chromium.org
Status: Started
Project Member Comment 7 by bugdroid1@chromium.org, Oct 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4404c2f93e2d2ccacf15b07c834bff8051ddb63

commit e4404c2f93e2d2ccacf15b07c834bff8051ddb63
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Oct 05 07:08:46 2017

ServiceWorker: Move InstalledScriptsManager access from WorkerThread to SWGlobalScope

For cleanup, this CL moves InstalledScriptsManager access from
WorkerThread::InitializeOnWorkerThread() to
ServiceWorkerGlobalScope::EvaluateClassicScript() because only ServiceWorker
needs to access the manager and placing it in EvaluateClassicScript() looks more
natural like importScripts().

<Motivation>

My final goal is to remove script evaluation code from WorkerThread and leave it
up to each owner of WorkerThread so that WorkerThead is no longer concerned with
how to evaluate scripts (i.e., "classic", "module", lazy eval for worklets).

For example, for DedicatedWorker, DedicatedWorkerMessagingProxy may post a task
to call WorkerGlobalScope::EvaluateClassicScript() or
WorkerGlobalScope::ImportModuleScript() (to be added later) based on
"WorkerType"[1] after initializing DedicatedWorkerThread.

[1] https://html.spec.whatwg.org/multipage/workers.html#workertype

Bug: 680046, 753350,  755054 
Change-Id: I546cbda16f09da66c3f94c319e498055e1f9d05b
Reviewed-on: https://chromium-review.googlesource.com/701854
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506670}
[modify] https://crrev.com/e4404c2f93e2d2ccacf15b07c834bff8051ddb63/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/e4404c2f93e2d2ccacf15b07c834bff8051ddb63/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/e4404c2f93e2d2ccacf15b07c834bff8051ddb63/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
[modify] https://crrev.com/e4404c2f93e2d2ccacf15b07c834bff8051ddb63/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
[modify] https://crrev.com/e4404c2f93e2d2ccacf15b07c834bff8051ddb63/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/e4404c2f93e2d2ccacf15b07c834bff8051ddb63/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp
[modify] https://crrev.com/e4404c2f93e2d2ccacf15b07c834bff8051ddb63/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h

Blocking: 788593
Project Member Comment 9 by bugdroid1@chromium.org, Dec 1
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7ea91203b8c29c7327355f8289107026fb63418

commit e7ea91203b8c29c7327355f8289107026fb63418
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Dec 01 08:01:11 2017

Worker: Reject dynamic import() on WorkerGlobalScope with informative message

This CL makes dynamic import() on (Dedicated/Shared/Service)WorkerGlobalScope
reject the promise with an informative message for developers.

Notes:
- ES6 Modules for workers are now being implemented, and dynamic import() will
  be available on WorkerGlobaScope once the implementation is completed.
- The promise was rejected even before this CL but its error message was not
  useful.

Bug: 680046,  788593 
Change-Id: I270ed9d1d5a9dedaff5dc777ccf78ed99cf887f2
Reviewed-on: https://chromium-review.googlesource.com/799536
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520882}
[add] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/LayoutTests/fast/workers/resources/shared-worker-dynamic-import.js
[add] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/LayoutTests/fast/workers/resources/worker-dynamic-import.js
[add] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/LayoutTests/fast/workers/shared-worker-dynamic-import.html
[add] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/LayoutTests/fast/workers/worker-dynamic-import.html
[add] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/dynamic-import.html
[add] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/dynamic-import-worker.js
[modify] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/Source/core/dom/Modulator.cpp
[modify] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/Source/core/dom/ModulatorImplBase.h
[add] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/Source/core/dom/WorkerModulatorImpl.cpp
[add] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/Source/core/dom/WorkerModulatorImpl.h
[modify] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
[modify] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h
[modify] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
[modify] https://crrev.com/e7ea91203b8c29c7327355f8289107026fb63418/third_party/WebKit/Source/core/workers/WorkletGlobalScope.h

ES6 Modules for workers are now being implemented?

according to https://bugs.chromium.org/p/chromium/issues/detail?id=788593#c8

I test on chromium 65.0.3285.0(x86) failed.

Console display error: "Uncaught SyntaxError: Unexpected identifier"
c#10: It's now under development and not ready to test it.
Project Member Comment 12 by bugdroid1@chromium.org, Dec 6
Labels: merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64bba80353f39bcb14adabfb75c60cca56b2758d

commit 64bba80353f39bcb14adabfb75c60cca56b2758d
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Wed Dec 06 01:36:47 2017

[Merge to M64] Worker: Reject dynamic import() on WorkerGlobalScope with informative message

This CL makes dynamic import() on (Dedicated/Shared/Service)WorkerGlobalScope
reject the promise with an informative message for developers.

Notes:
- ES6 Modules for workers are now being implemented, and dynamic import() will
  be available on WorkerGlobaScope once the implementation is completed.
- The promise was rejected even before this CL but its error message was not
  useful.

Bug: 680046,  788593 
Change-Id: I270ed9d1d5a9dedaff5dc777ccf78ed99cf887f2
Reviewed-on: https://chromium-review.googlesource.com/799536
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#520882}(cherry picked from commit e7ea91203b8c29c7327355f8289107026fb63418)
Reviewed-on: https://chromium-review.googlesource.com/809990
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#48}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[add] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/LayoutTests/fast/workers/resources/shared-worker-dynamic-import.js
[add] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/LayoutTests/fast/workers/resources/worker-dynamic-import.js
[add] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/LayoutTests/fast/workers/shared-worker-dynamic-import.html
[add] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/LayoutTests/fast/workers/worker-dynamic-import.html
[add] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/dynamic-import.html
[add] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/dynamic-import-worker.js
[modify] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/Source/core/dom/Modulator.cpp
[modify] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/Source/core/dom/ModulatorImplBase.h
[add] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/Source/core/dom/WorkerModulatorImpl.cpp
[add] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/Source/core/dom/WorkerModulatorImpl.h
[modify] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
[modify] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h
[modify] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
[modify] https://crrev.com/64bba80353f39bcb14adabfb75c60cca56b2758d/third_party/WebKit/Source/core/workers/WorkletGlobalScope.h

Project Member Comment 13 by bugdroid1@chromium.org, Dec 8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eba64719f5e950ff9ef335e0392f2b6f7c45adc

commit 6eba64719f5e950ff9ef335e0392f2b6f7c45adc
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Dec 08 03:09:36 2017

Worker: Exclude source_code from GlobalScopeCreationParams for cleanup

For cleanup, this CL excludes |source_code| and |cached_meta_data| from
GlobalScopeCreationParams and passes them as separate arguments to functions.
This is because these fields are not used for creating a global scope but for
evaluating a worker script.

Also, this change simplifies worklets implementation and helps to implement
module worker because they don't need to pass |source_code| and
|cached_meta_data| from the main thread.

Bug: 680046, 710364
Change-Id: Icdf978ec136cb316c391a47e8306ba454e9b9876
Reviewed-on: https://chromium-review.googlesource.com/813454
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522692}
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderTest.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/workers/GlobalScopeCreationParams.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/workers/GlobalScopeCreationParams.h
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/workers/WorkerThread.h
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletGlobalScopeTest.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletThreadTest.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScopeProxy.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp
[modify] https://crrev.com/6eba64719f5e950ff9ef335e0392f2b6f7c45adc/third_party/WebKit/Source/modules/webaudio/AudioWorkletThreadTest.cpp

Project Member Comment 14 by bugdroid1@chromium.org, Dec 13 (2 days ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d17e158c4ddc0259e32fa13ad9c5a67876d50fd

commit 6d17e158c4ddc0259e32fa13ad9c5a67876d50fd
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Wed Dec 13 08:34:20 2017

Worker: Remove ThreadedMessagingProxyBase::WorkerThreadCreated() for cleanup

ThreadedMessagingProxyBase::WorkerThreadCreated() is provided as a virtual
function for DedicatedWorkerMessagingProxy to post queued tasks to the worker
after thread creation. However, DedicatedWorkerMessagingProxy itself initiates
the thread creation in StartWorkerGlobalScope() and can know when it's
available, so such the virtual function is not necessary.

For cleanup, this CL removes WorkerThreadCreated() and inlines posting the
queued tasks in StartWorkerGlobalScope().

Bug: 680046
Change-Id: I5248c78d381e0820461e167249ce89bac93e44a5
Reviewed-on: https://chromium-review.googlesource.com/823052
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523719}
[modify] https://crrev.com/6d17e158c4ddc0259e32fa13ad9c5a67876d50fd/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.cpp
[modify] https://crrev.com/6d17e158c4ddc0259e32fa13ad9c5a67876d50fd/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.h
[modify] https://crrev.com/6d17e158c4ddc0259e32fa13ad9c5a67876d50fd/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp
[modify] https://crrev.com/6d17e158c4ddc0259e32fa13ad9c5a67876d50fd/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h

Project Member Comment 15 by bugdroid1@chromium.org, Today (7 hours ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90a9b1a33ff4056792f6c3d3100b97ba5d52f080

commit 90a9b1a33ff4056792f6c3d3100b97ba5d52f080
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Dec 15 14:30:55 2017

Worker: Introduce WorkerOptions for module workers

This CL introduces WorkerOptions for module workers. This is not exposed on the
ctor of any workers yet to avoid making developers confused about unimplemented
features.

This also passes the option from DedicatedWorker::Create() to
DedicatedWorkerMessagingProxy::StartWorkerGlobalScope(). Following CLs will
implement the remaining parts and add tests.

This CL doesn't change the existing behavior.

Rough design doc about module workers:
https://docs.google.com/a/chromium.org/document/d/1IMGWAK7Wq37mLehwkbysNRBBnhQBo3z2MbYyMkViEnY/edit?usp=sharing

Bug: 680046
Change-Id: I571e8f540d842bb06878e13d4b383eddc2df42f1
Reviewed-on: https://chromium-review.googlesource.com/813314
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524377}
[modify] https://crrev.com/90a9b1a33ff4056792f6c3d3100b97ba5d52f080/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/90a9b1a33ff4056792f6c3d3100b97ba5d52f080/third_party/WebKit/Source/core/workers/DedicatedWorker.cpp
[modify] https://crrev.com/90a9b1a33ff4056792f6c3d3100b97ba5d52f080/third_party/WebKit/Source/core/workers/DedicatedWorker.h
[modify] https://crrev.com/90a9b1a33ff4056792f6c3d3100b97ba5d52f080/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.cpp
[modify] https://crrev.com/90a9b1a33ff4056792f6c3d3100b97ba5d52f080/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.h
[add] https://crrev.com/90a9b1a33ff4056792f6c3d3100b97ba5d52f080/third_party/WebKit/Source/core/workers/RequestCredentials.idl
[modify] https://crrev.com/90a9b1a33ff4056792f6c3d3100b97ba5d52f080/third_party/WebKit/Source/core/workers/Worker.idl
[add] https://crrev.com/90a9b1a33ff4056792f6c3d3100b97ba5d52f080/third_party/WebKit/Source/core/workers/WorkerOptions.idl
[modify] https://crrev.com/90a9b1a33ff4056792f6c3d3100b97ba5d52f080/third_party/WebKit/Source/core/workers/WorkletOptions.idl

Sign in to add a comment