New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680043 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 606766



Sign in to add a comment

ambient-light-sensor.html is flaky

Project Member Reported by foolip@chromium.org, Jan 11 2017

Issue description

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=sensor%2Fambient-light-sensor.html

It is occasionally failing on many platforms. Failures look like this:

CONSOLE INFO: line 30: Frequency is limited to 60 Hz.
CONSOLE INFO: line 53: Frequency is limited to 60 Hz.
This is a testharness.js-based test.
PASS Test that negative frequency causes exception from constructor. 
PASS Test that "onerror" is send when sensor is not supported. 
PASS Test that "onerror" is send when start() call has failed. 
PASS Test that frequency is capped to 60.0 Hz. 
PASS Test that frequency is capped to the maximum supported from frequency. 
PASS Test that sensor can be successfully created if sensor is supported. 
PASS Test that sensor can be constructed with default configuration. 
PASS Test that addConfiguration and removeConfiguration is called. 
PASS Test that onChange is called and sensor reading is valid (onchange reporting). 
PASS Test that onChange is called and sensor reading is valid (continuous reporting). 
PASS Test that sensor receives suspend / resume notifications when page visibility changes. 
PASS Test that sensor reading is correct. 
PASS Test that frequency hint works (onchange reporting). 
FAIL Test that frequency hint works (continuous reporting). promise_test: Unhandled rejection with value: undefined
Harness: the test ran to completion.

In other words, the last test occasionally fails.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf29e966c750e8fbdef01f7436b94d57ab6ebfe8

commit cf29e966c750e8fbdef01f7436b94d57ab6ebfe8
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Wed Jan 11 09:45:22 2017

Mark sensor/ambient-light-sensor.html as flaky on all platforms

BUG= 680043 
TBR=mikhail.pozdnyakov@intel.com

Review-Url: https://codereview.chromium.org/2622183003 .
Cr-Commit-Position: refs/heads/master@{#442833}

[modify] https://crrev.com/cf29e966c750e8fbdef01f7436b94d57ab6ebfe8/third_party/WebKit/LayoutTests/TestExpectations

Components: -Blink Tests>Flaky
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7ee7cd5fa8bd44d54fa9307634a350724c2d044

commit d7ee7cd5fa8bd44d54fa9307634a350724c2d044
Author: mikhail.pozdnyakov <mikhail.pozdnyakov@intel.com>
Date: Mon Jan 30 12:41:21 2017

[Sensors] Improve error logging in sensors layout tests

This patch improves error logging if an exception is raised in a callback.
Before: "promise_test: Unhandled rejection with value: undefined"
After: "assert_equals: expected 3 but got 2"

BUG= 680043 

Review-Url: https://codereview.chromium.org/2660563003
Cr-Commit-Position: refs/heads/master@{#446974}

[modify] https://crrev.com/d7ee7cd5fa8bd44d54fa9307634a350724c2d044/third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf0871ef36416a7ac4bafba5bea3bdd8ad733f0c

commit bf0871ef36416a7ac4bafba5bea3bdd8ad733f0c
Author: mikhail.pozdnyakov <mikhail.pozdnyakov@intel.com>
Date: Tue Jan 31 11:57:40 2017

Fix sensors layout tests flakiness

Before the change frequency hint tests were flaky with the following error message:

FAIL Test that frequency hint works (onchange reporting). assert_equals: expected 3 but got 2.

The reason apparently was that notification on Blink side sometimes gets slightly delayed (which is possible behavior since it is bound to AF)

BUG= 680043 

Review-Url: https://codereview.chromium.org/2668443002
Cr-Commit-Position: refs/heads/master@{#447218}

[modify] https://crrev.com/bf0871ef36416a7ac4bafba5bea3bdd8ad733f0c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/bf0871ef36416a7ac4bafba5bea3bdd8ad733f0c/third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js

Status: Fixed (was: Assigned)

Sign in to add a comment