New issue
Advanced search Search tips

Issue 680030 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Jan 2017
Cc:
mfo...@chromium.org
ligim...@chromium.org
alex...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[Missing Tests]: Remove workaround for GetLastCommittedOrigin with non-current RFHs.

Project Member Reported by durga.behera@chromium.org, Jan 11 2017 
alexmos@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions.

Commit: https://codereview.chromium.org/2583943002

Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=663740

Thank you!

Comment 1 by alex...@chromium.org, Jan 12 2017

Cc: alex...@chromium.org
Owner: mfo...@chromium.org
My CL was removing a workaround that was added by mfoltz@ in 
r436399, which was no longer necessary after my earlier change in r437660.  r437660 did add a test, RenderFrameHostManagerTest.LastCommittedOrigin, that calls GetLastCommittedOrigin() on a pending delete RFH, which was the root cause of the crash in issue 663740.  I don't know if it's worth also adding a media router test for this; my sense is no, but I'll let mfoltz@ make the call, since I'm not familiar enough with media router to add such a test anyway.

Comment 2 by ligim...@chromium.org, Jan 12 2017

Labels: Pri-2
***Bulk Edit***

Considering Missing tests are P2, but please prioritize and add them asap.

Comment 3 by mfo...@chromium.org, Jan 12 2017

Cc: mfo...@chromium.org
Owner: ----
The commit above is actually removing code.  I don't think you can test code that is no longer there :)

Comment 4 by creis@chromium.org, Jan 12 2017

Status: WontFix (was: Assigned)
►

Sign in to add a comment