New issue
Advanced search Search tips

Issue 680019 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[Missing Tests]: Fix form validation bubble positioning at hidpi

Project Member Reported by kavvaru@chromium.org, Jan 11 2017

Issue description

bsep@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions.

Commit: https://codereview.chromium.org/2491113002

Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=660840

Thanks,
 
 

Comment 1 by bsep@chromium.org, Jan 11 2017

While I support backfilling tests I don't understand why this is pri 1.

Plus adding tests for that bugfix is non-trivial, as there's no existing suite for ValidationMessageBubble or for its subclasses. So I probably won't get to this for a while.
Labels: -Pri-1 Pri-3
Thanks for the update. Not a P1 bug, reduced the priority.

Please add the test suite when you get a chance.TE's main goal here is to maximize the automation test coverage.

Labels: Pri-2
***Bulk Edit***

Considering Missing tests are P2, but please prioritize and add them asap.

Comment 5 by bsep@chromium.org, May 17 2017

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d77878b9c9f4f4db96a21e0974843a7e8cd77b24

commit d77878b9c9f4f4db96a21e0974843a7e8cd77b24
Author: bsep <bsep@chromium.org>
Date: Wed May 17 20:40:13 2017

Revert of Backfill some UI tests. (patchset #9 id:160001 of https://codereview.chromium.org/2861533003/ )

Reason for revert:
Caused compile failure

Original issue's description:
> Backfill some UI tests.
>
> * Added a test for DialogClientView's button layout.
> * Added a test for non client hit results in BubbleFrameView.
> * Added a test for ValidationMessageBubbleView's anchor rect at HighDPI.
>
> BUG=702196, 680019 
>
> Review-Url: https://codereview.chromium.org/2861533003
> Cr-Commit-Position: refs/heads/master@{#472550}
> Committed: https://chromium.googlesource.com/chromium/src/+/819580022f1d2c8dc1eaa4d8614e765a55f95a4b

TBR=sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=702196, 680019 

Review-Url: https://codereview.chromium.org/2891803002
Cr-Commit-Position: refs/heads/master@{#472554}

[delete] https://crrev.com/525974cdba654d1611d169a34397304334797175/chrome/browser/ui/views/validation_message_bubble_view_unittest.cc
[modify] https://crrev.com/d77878b9c9f4f4db96a21e0974843a7e8cd77b24/chrome/test/BUILD.gn
[modify] https://crrev.com/d77878b9c9f4f4db96a21e0974843a7e8cd77b24/content/test/test_render_view_host.cc
[modify] https://crrev.com/d77878b9c9f4f4db96a21e0974843a7e8cd77b24/content/test/test_render_view_host.h
[modify] https://crrev.com/d77878b9c9f4f4db96a21e0974843a7e8cd77b24/ui/views/window/dialog_client_view_unittest.cc
[modify] https://crrev.com/d77878b9c9f4f4db96a21e0974843a7e8cd77b24/ui/views/window/dialog_delegate_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, May 18 2017

Sign in to add a comment