New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680018 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add Quick View metric: If it's opened with Space key or context menu.

Project Member Reported by oka@chromium.org, Jan 11 2017

Issue description

Context menu / Space key.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d80af48c3cd0c301ca3f2e5ba0eab568b36ccc9

commit 3d80af48c3cd0c301ca3f2e5ba0eab568b36ccc9
Author: oka <oka@chromium.org>
Date: Mon Jan 16 03:22:28 2017

Quick View UMA: export how quick view was opened.

There are two ways to open quick view: from context menu or with space
key. This change exports in which way quick view was opened with name
'FileBrowser.QuickView.WayToOpen'.

TEST=try & manually checked the UMA were exported in
     chrome://histograms as expected.
BUG= 680018 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2628833002
Cr-Commit-Position: refs/heads/master@{#443839}

[modify] https://crrev.com/3d80af48c3cd0c301ca3f2e5ba0eab568b36ccc9/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/3d80af48c3cd0c301ca3f2e5ba0eab568b36ccc9/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
[modify] https://crrev.com/3d80af48c3cd0c301ca3f2e5ba0eab568b36ccc9/ui/file_manager/file_manager/foreground/js/quick_view_uma.js

Comment 2 by oka@chromium.org, Jan 16 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment