New issue
Advanced search Search tips

Issue 679986 link

Starred by 1 user
Status: Fixed
Owner:
tikuta@chromium.org
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"postprocess_for_goma.stop cloudtail" step should not be purple when "compile" step failed due to goma

Project Member Reported by shinyak@chromium.org, Jan 11 2017 
Example: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/325402

"postprocess_for_goma.stop cloudtail" succeeded but its color is purple.

it has 
"""
@@@STEP_EXCEPTION@@@
@@@SET_BUILD_PROPERTY@extra_result_code@["GOMA_BUILD_ERROR"]@@@
"""

this is because "compile (with patch)" step failed due to network connection error.

When "postprocess_for_goma.stop cloudtail" is purple, I think cloudtail has some problem, however, its not.

Maybe we should have another step to check compile step sanity in postprocess_for_goma ?

Comment 1 by shinyak@chromium.org, Mar 23 2017

Labels: -Pri-3 Pri-2
I now feel this is really harmful to find failure cause.
Let me bump the priority up.

Comment 2 by shinyak@chromium.org, Mar 23 2017 

Note: now we have 2 pain points:
(1) the parent step of the failed nested step is not marked as failure.
(2) the last step in the nested steps is wrongly marked as failure instead of the failure step itself.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6

commit f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6
Author: Takuto Ikuta <tikuta@google.com>
Date: Thu Apr 20 01:50:37 2017

Show status of nested steps in goma module

Mark nested step as exception if exception occurs inside it.

BUG= 679986 

Change-Id: If2bf2f79da7fdc1d8ab283f4af545ffa2fb256cf
Reviewed-on: https://chromium-review.googlesource.com/458359
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@google.com>

[add] https://crrev.com/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6/scripts/slave/recipe_modules/goma/example.expected/linux_start_goma_failed.json
[modify] https://crrev.com/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6/scripts/slave/recipe_modules/goma/api.py
[modify] https://crrev.com/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_ping_failure.json
[modify] https://crrev.com/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6/scripts/slave/recipe_modules/chromium/api.py
[modify] https://crrev.com/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6/scripts/slave/recipes/findit/chromium/test.expected/record_infra_failure.json
[modify] https://crrev.com/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6/scripts/slave/recipes/chromium_trybot.expected/compile_failure_infra.json
[modify] https://crrev.com/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_build_error.json
[add] https://crrev.com/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6/scripts/slave/recipe_modules/goma/example.expected/linux_stop_goma_failed.json
[modify] https://crrev.com/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_setup_failure.json
[modify] https://crrev.com/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6/scripts/slave/recipe_modules/goma/example.py
[modify] https://crrev.com/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_goma_module_build_failure.json
[modify] https://crrev.com/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6/scripts/slave/recipes/findit/chromium/flake.expected/record_infra_failure.json
[modify] https://crrev.com/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_goma_module_start_failure.json
[modify] https://crrev.com/f7d053a108ee3ef3fe639bd72ce4aeca3ffe80c6/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_goma_module_ping_failure.json

Comment 4 by tikuta@chromium.org, Apr 21 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment