There are a bunch of goodies in src/apps we'd like to use in app_shell, but they depend on src/chrome. The first part I'd like to make generic is the ability to provide apps with files they've declared handlers for.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2e0703838bc7140c4129c491085a1da55cacbbf commit b2e0703838bc7140c4129c491085a1da55cacbbf Author: michaelpg <michaelpg@chromium.org> Date: Thu Jan 12 17:56:39 2017 Move CustomLauncherPageContents from apps to c/b/ui/app_list This is the most Chrome-dependent part of //apps, and is only used for the app list in Chrome, so why not move it to chrome/browser/ui/app_list? This enables us to make the rest of the //apps code independent of Chrome so it can be used for app_shell. Alternatively, we could make custom_launcher_page_contents.cc not depend on Chrome (it's mostly for extensions::ChromeExtensionWebContentsObserver), but that's probably better off being lumped into a larger task to move app_list out of chrome if that should become a goal. BUG= 679971 R=benwells@chromium.org Review-Url: https://codereview.chromium.org/2628883002 Cr-Commit-Position: refs/heads/master@{#443286} [modify] https://crrev.com/b2e0703838bc7140c4129c491085a1da55cacbbf/apps/BUILD.gn [modify] https://crrev.com/b2e0703838bc7140c4129c491085a1da55cacbbf/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/b2e0703838bc7140c4129c491085a1da55cacbbf/chrome/browser/ui/app_list/app_list_view_delegate.cc [modify] https://crrev.com/b2e0703838bc7140c4129c491085a1da55cacbbf/chrome/browser/ui/app_list/app_list_view_delegate.h [rename] https://crrev.com/b2e0703838bc7140c4129c491085a1da55cacbbf/chrome/browser/ui/app_list/custom_launcher_page_contents.cc [rename] https://crrev.com/b2e0703838bc7140c4129c491085a1da55cacbbf/chrome/browser/ui/app_list/custom_launcher_page_contents.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fc6af94465bf4c86d723bab970f37f29ee3f944 commit 2fc6af94465bf4c86d723bab970f37f29ee3f944 Author: michaelpg <michaelpg@chromium.org> Date: Fri Jan 13 19:54:18 2017 Move Chrome terminating notification out of //apps Part of removing the chrome dependency from //apps. Make the embedder (chrome) extension system notify the app restore service when it will terminate, instead of relying on a Chrome notification via NotificationService. This builds on https://codereview.chromium.org/425303002 to some extent. It would be nicer not to use the Chrome notification at all, but I'm not sure how to do that -- at least this way, the responsibility is in c/b/extensions rather than elsewhere in Chrome. R=benwells@chromium.org BUG= 679971 Review-Url: https://codereview.chromium.org/2623273011 Cr-Commit-Position: refs/heads/master@{#443643} [modify] https://crrev.com/2fc6af94465bf4c86d723bab970f37f29ee3f944/apps/app_lifetime_monitor.cc [modify] https://crrev.com/2fc6af94465bf4c86d723bab970f37f29ee3f944/apps/app_lifetime_monitor.h [modify] https://crrev.com/2fc6af94465bf4c86d723bab970f37f29ee3f944/apps/app_restore_service.cc [modify] https://crrev.com/2fc6af94465bf4c86d723bab970f37f29ee3f944/apps/app_restore_service.h [modify] https://crrev.com/2fc6af94465bf4c86d723bab970f37f29ee3f944/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc [modify] https://crrev.com/2fc6af94465bf4c86d723bab970f37f29ee3f944/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h [modify] https://crrev.com/2fc6af94465bf4c86d723bab970f37f29ee3f944/chrome/browser/extensions/DEPS [modify] https://crrev.com/2fc6af94465bf4c86d723bab970f37f29ee3f944/chrome/browser/extensions/extension_system_impl.cc [modify] https://crrev.com/2fc6af94465bf4c86d723bab970f37f29ee3f944/chrome/browser/extensions/extension_system_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0145e6a749a559b1c50ecf2176f9ef0fce68c09 commit c0145e6a749a559b1c50ecf2176f9ef0fce68c09 Author: michaelpg <michaelpg@chromium.org> Date: Sat Mar 18 03:00:15 2017 Add PreloadCheck class for extension pre-install checks PreloadCheck is an abstract preload check for an extension that may be asynchronous. The idea is to de-duplicate ad-hoc checks into PreloadCheck subclasses, then use these classes from places like ExtensionInstallChecker, CrxInstaller, and ManagementAPI. This will enable some of these classes to be moved into //extensions, because we would be able to pick and choose which checks to run. E.g., AppShell would only use checks from //extensions, while Chrome would also add checks from //chrome like BlacklistCheck. See go/loading-extensions-in-appshell for more details on how this relates to AppShell and launching apps/extensions. BUG= 679971 Review-Url: https://codereview.chromium.org/2693373003 Cr-Commit-Position: refs/heads/master@{#457943} [modify] https://crrev.com/c0145e6a749a559b1c50ecf2176f9ef0fce68c09/chrome/browser/extensions/BUILD.gn [add] https://crrev.com/c0145e6a749a559b1c50ecf2176f9ef0fce68c09/chrome/browser/extensions/blacklist_check.cc [add] https://crrev.com/c0145e6a749a559b1c50ecf2176f9ef0fce68c09/chrome/browser/extensions/blacklist_check.h [add] https://crrev.com/c0145e6a749a559b1c50ecf2176f9ef0fce68c09/chrome/browser/extensions/blacklist_check_unittest.cc [modify] https://crrev.com/c0145e6a749a559b1c50ecf2176f9ef0fce68c09/chrome/test/BUILD.gn [modify] https://crrev.com/c0145e6a749a559b1c50ecf2176f9ef0fce68c09/extensions/browser/BUILD.gn [add] https://crrev.com/c0145e6a749a559b1c50ecf2176f9ef0fce68c09/extensions/browser/policy_check.cc [add] https://crrev.com/c0145e6a749a559b1c50ecf2176f9ef0fce68c09/extensions/browser/policy_check.h [add] https://crrev.com/c0145e6a749a559b1c50ecf2176f9ef0fce68c09/extensions/browser/policy_check_unittest.cc [add] https://crrev.com/c0145e6a749a559b1c50ecf2176f9ef0fce68c09/extensions/browser/preload_check.cc [add] https://crrev.com/c0145e6a749a559b1c50ecf2176f9ef0fce68c09/extensions/browser/preload_check.h [add] https://crrev.com/c0145e6a749a559b1c50ecf2176f9ef0fce68c09/extensions/browser/preload_check_test_util.cc [add] https://crrev.com/c0145e6a749a559b1c50ecf2176f9ef0fce68c09/extensions/browser/preload_check_test_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2eb513ed005d6b23489f457d997d944b6fa089d8 commit 2eb513ed005d6b23489f457d997d944b6fa089d8 Author: michaelpg <michaelpg@chromium.org> Date: Sat Mar 25 02:02:38 2017 Update ExtensionInstallChecker to use PreloadCheck classes Replaces some ad-hoc checks with their encapsulated equivalents. Later, the individual OnFooCheckDone methods will be eliminated too. BUG= 679971 R=rdevlin.cronin@chromium.org Review-Url: https://codereview.chromium.org/2768723002 Cr-Commit-Position: refs/heads/master@{#459621} [modify] https://crrev.com/2eb513ed005d6b23489f457d997d944b6fa089d8/chrome/browser/extensions/crx_installer.cc [modify] https://crrev.com/2eb513ed005d6b23489f457d997d944b6fa089d8/chrome/browser/extensions/crx_installer.h [modify] https://crrev.com/2eb513ed005d6b23489f457d997d944b6fa089d8/chrome/browser/extensions/extension_install_checker.cc [modify] https://crrev.com/2eb513ed005d6b23489f457d997d944b6fa089d8/chrome/browser/extensions/extension_install_checker.h [modify] https://crrev.com/2eb513ed005d6b23489f457d997d944b6fa089d8/chrome/browser/extensions/extension_install_checker_unittest.cc [modify] https://crrev.com/2eb513ed005d6b23489f457d997d944b6fa089d8/extensions/browser/preload_check_test_util.cc [modify] https://crrev.com/2eb513ed005d6b23489f457d997d944b6fa089d8/extensions/browser/preload_check_test_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d80e56ccda893a12d9ef7c27547b7586ce582cf commit 4d80e56ccda893a12d9ef7c27547b7586ce582cf Author: michaelpg <michaelpg@chromium.org> Date: Tue Apr 04 01:48:14 2017 Remove Profile usage from //apps Excludes tests. BUG= 679971 R=benwells@chromium.org,xiyuan@chromium.org TBR=sky@chromium.org # chrome/browser/ui/startup rename Review-Url: https://codereview.chromium.org/2729503007 Cr-Commit-Position: refs/heads/master@{#461609} [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/DEPS [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/app_lifetime_monitor.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/app_lifetime_monitor.h [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/app_lifetime_monitor_factory.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/app_lifetime_monitor_factory.h [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/app_load_service.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/app_load_service.h [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/app_load_service_factory.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/app_load_service_factory.h [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/app_restore_service.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/app_restore_service.h [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/app_restore_service_browsertest.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/app_restore_service_factory.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/app_restore_service_factory.h [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/launcher.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/launcher.h [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/saved_files_service.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/saved_files_service.h [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/saved_files_service_factory.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/apps/saved_files_service_factory.h [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/chrome/browser/apps/app_shim/extension_app_shim_handler_mac_unittest.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/chrome/browser/apps/app_shim/test/app_shim_host_manager_test_api_mac.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/chrome/browser/chromeos/login/easy_unlock/short_lived_user_context.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/chrome/browser/chromeos/login/easy_unlock/short_lived_user_context.h [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/chrome/browser/chromeos/note_taking_helper.h [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/chrome/browser/chromeos/note_taking_helper_unittest.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/chrome/browser/extensions/extension_system_impl.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/chrome/browser/signin/easy_unlock_service.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/chrome/browser/signin/easy_unlock_service_regular.cc [modify] https://crrev.com/4d80e56ccda893a12d9ef7c27547b7586ce582cf/chrome/browser/ui/startup/startup_browser_creator_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90 commit dbdcdcc7eb02d34200dca4a21f8528a7332f7d90 Author: michaelpg <michaelpg@chromium.org> Date: Thu Apr 06 01:40:56 2017 Add chrome/browser/apps/BUILD.gn and move Chrome-specific code there This moves references to c/b/apps from their awkward place in c/b/extensions to a standalone source_set in c/b/apps/BUILD.gn. Now, c/b/apps explicitly depends on c/b/extensions, and c/b/extensions need not explicitlty depend on c/b/apps. (Some circular includes are still required, e.g. for app-specific API calls within c/b/extensions.) Apart from BUILD.gn files, the structural changes are: * moving {apps => chrome/browser/apps}/app_load_service.cc * adding chrome/browser/apps/browser_context_keyed_service_factories.* to handle startup/shutdown tasks The following gn checks now pass: * //apps (used to fail) * //chrome/browser/apps (newly added) The following gn checks used to pass, and still do: * //chrome/browser/extensions * //chrome/browser/ui The following gn checks still fail, but with fewer errors: * //chrome/browser BUG= 679971 , 159366 TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/2789253003 Cr-Commit-Position: refs/heads/master@{#462314} [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/apps/BUILD.gn [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/apps/DEPS [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/apps/browser_context_keyed_service_factories.cc [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/apps/browser_context_keyed_service_factories.h [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/apps/saved_files_service.cc [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/apps/saved_files_service.h [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/apps/saved_files_service_factory.cc [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/apps/saved_files_service_factory.h [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/BUILD.gn [add] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/apps/BUILD.gn [rename] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/apps/app_load_service.cc [rename] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/apps/app_load_service.h [rename] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/apps/app_load_service_factory.cc [rename] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/apps/app_load_service_factory.h [add] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/apps/browser_context_keyed_service_factories.cc [add] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/apps/browser_context_keyed_service_factories.h [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/background/background_contents_service.cc [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/extensions/BUILD.gn [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.cc [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/extensions/extension_system_impl.cc [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/ui/startup/startup_browser_creator.cc [modify] https://crrev.com/dbdcdcc7eb02d34200dca4a21f8528a7332f7d90/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4 commit a8ea037e3ee7b0f25d694801bd4accb8f22b46c4 Author: michaelpg <michaelpg@chromium.org> Date: Thu Apr 06 20:41:35 2017 Move ChromeRequirementsChecker to //extensions as a PreloadCheck Remove the "Chrome" from ChromeRequirementsChecker. Make it implement PreloadCheck and simplify its async logic a bit. Transform RequirementsCheckerBrowserTest to a unit test. This lets AppShell and other modules use RequirementsChecker. (This wasn't possible until GPUFeatureChecker was moved to //content in http://crrev.com/2666243002.) BUG= 679971 R=rdevlin.cronin@chromium.org TBR=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2783813002 Cr-Commit-Position: refs/heads/master@{#462607} [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/app/generated_resources.grd [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/browser/content_settings/content_settings_internal_extension_provider.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/browser/extensions/BUILD.gn [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/browser/extensions/api/management/chrome_management_api_delegate.h [delete] https://crrev.com/64fa0be168f6c59bceeef35c5bce6b9cf85c1ef8/chrome/browser/extensions/chrome_requirements_checker.cc [delete] https://crrev.com/64fa0be168f6c59bceeef35c5bce6b9cf85c1ef8/chrome/browser/extensions/chrome_requirements_checker.h [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/browser/extensions/crx_installer.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/browser/extensions/extension_install_checker.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/browser/extensions/extension_install_checker.h [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/browser/extensions/extension_install_checker_unittest.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/browser/extensions/extension_service.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/browser/extensions/extension_service_unittest.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/browser/extensions/plugin_manager.cc [delete] https://crrev.com/64fa0be168f6c59bceeef35c5bce6b9cf85c1ef8/chrome/browser/extensions/requirements_checker_browsertest.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/browser/extensions/unpacked_installer.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/common/BUILD.gn [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/common/extensions/chrome_manifest_handlers.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/common/extensions/sync_helper.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/common/extensions/sync_type_unittest.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/chrome/test/BUILD.gn [delete] https://crrev.com/64fa0be168f6c59bceeef35c5bce6b9cf85c1ef8/chrome/test/data/requirements_checker/no_requirements/manifest.json [delete] https://crrev.com/64fa0be168f6c59bceeef35c5bce6b9cf85c1ef8/chrome/test/data/requirements_checker/require_3d/manifest.json [delete] https://crrev.com/64fa0be168f6c59bceeef35c5bce6b9cf85c1ef8/chrome/test/data/requirements_checker/require_npapi/manifest.json [delete] https://crrev.com/64fa0be168f6c59bceeef35c5bce6b9cf85c1ef8/chrome/test/data/requirements_checker/require_window_shape/manifest.json [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/extensions/browser/BUILD.gn [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/extensions/browser/DEPS [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/extensions/browser/api/management/management_api.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/extensions/browser/api/management/management_api.h [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/extensions/browser/api/management/management_api_delegate.h [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/extensions/browser/preload_check.h [add] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/extensions/browser/requirements_checker.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/extensions/browser/requirements_checker.h [add] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/extensions/browser/requirements_checker_unittest.cc [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/extensions/common/BUILD.gn [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/extensions/common/common_manifest_handlers.cc [rename] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/extensions/common/manifest_handlers/plugins_handler.cc [rename] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/extensions/common/manifest_handlers/plugins_handler.h [modify] https://crrev.com/a8ea037e3ee7b0f25d694801bd4accb8f22b46c4/extensions/strings/extensions_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a4874fd53dccf53b7e5dc6f31275245dd4573bc commit 6a4874fd53dccf53b7e5dc6f31275245dd4573bc Author: michaelpg <michaelpg@chromium.org> Date: Thu Apr 13 20:41:33 2017 Replace ExtensionInstallChecker with generic PreloadCheckGroup Use the PreloadCheck interface for a PreloadCheckGroup check that runs a set of checks in parallel. Use this directly in CrxInstaller and UnpackedInstaller; remove ExtensionInstallChecker, along with its mildly arcane interface and its smattering of tests (the individual checks and the Installers are already tested individually). This generic "group" check can be provided with Chrome-specific checks, but doesn't have to depend on Chrome itself, so it could be used in non-Chrome code, e.g. //apps and //extensions. BUG= 679971 R=rdevlin.cronin@chromium.org Review-Url: https://codereview.chromium.org/2783143005 Cr-Commit-Position: refs/heads/master@{#464533} [modify] https://crrev.com/6a4874fd53dccf53b7e5dc6f31275245dd4573bc/chrome/browser/extensions/BUILD.gn [modify] https://crrev.com/6a4874fd53dccf53b7e5dc6f31275245dd4573bc/chrome/browser/extensions/crx_installer.cc [modify] https://crrev.com/6a4874fd53dccf53b7e5dc6f31275245dd4573bc/chrome/browser/extensions/crx_installer.h [delete] https://crrev.com/a78996284e826673ba36113865a623743c7ef048/chrome/browser/extensions/extension_install_checker.cc [delete] https://crrev.com/a78996284e826673ba36113865a623743c7ef048/chrome/browser/extensions/extension_install_checker.h [delete] https://crrev.com/a78996284e826673ba36113865a623743c7ef048/chrome/browser/extensions/extension_install_checker_unittest.cc [modify] https://crrev.com/6a4874fd53dccf53b7e5dc6f31275245dd4573bc/chrome/browser/extensions/unpacked_installer.cc [modify] https://crrev.com/6a4874fd53dccf53b7e5dc6f31275245dd4573bc/chrome/browser/extensions/unpacked_installer.h [modify] https://crrev.com/6a4874fd53dccf53b7e5dc6f31275245dd4573bc/chrome/test/BUILD.gn [modify] https://crrev.com/6a4874fd53dccf53b7e5dc6f31275245dd4573bc/extensions/browser/BUILD.gn [add] https://crrev.com/6a4874fd53dccf53b7e5dc6f31275245dd4573bc/extensions/browser/preload_check_group.cc [add] https://crrev.com/6a4874fd53dccf53b7e5dc6f31275245dd4573bc/extensions/browser/preload_check_group.h [add] https://crrev.com/6a4874fd53dccf53b7e5dc6f31275245dd4573bc/extensions/browser/preload_check_group_unittest.cc [modify] https://crrev.com/6a4874fd53dccf53b7e5dc6f31275245dd4573bc/extensions/browser/preload_check_test_util.cc [modify] https://crrev.com/6a4874fd53dccf53b7e5dc6f31275245dd4573bc/extensions/browser/preload_check_test_util.h [modify] https://crrev.com/6a4874fd53dccf53b7e5dc6f31275245dd4573bc/extensions/browser/requirements_checker_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d0b3151c08b8056637938953c936719e583dc54 commit 6d0b3151c08b8056637938953c936719e583dc54 Author: michaelpg <michaelpg@chromium.org> Date: Fri May 05 00:36:43 2017 Create separate BUILD.gn for //apps/ui/views This moves the views-related dependencies (including chrome/app/theme) out of the top-level //apps static library. Some DEPS includes were dropped entirely as they are no longer used in //apps. BUG= 679971 R=benwells@chromium.org Review-Url: https://codereview.chromium.org/2820563004 Cr-Commit-Position: refs/heads/master@{#469549} [modify] https://crrev.com/6d0b3151c08b8056637938953c936719e583dc54/apps/BUILD.gn [modify] https://crrev.com/6d0b3151c08b8056637938953c936719e583dc54/apps/DEPS [add] https://crrev.com/6d0b3151c08b8056637938953c936719e583dc54/apps/ui/views/BUILD.gn [modify] https://crrev.com/6d0b3151c08b8056637938953c936719e583dc54/apps/ui/views/DEPS [modify] https://crrev.com/6d0b3151c08b8056637938953c936719e583dc54/chrome/browser/ui/BUILD.gn
this is pretty much done, I just suck at updating bugs I've fixed
Comment 1 by bugdroid1@chromium.org
, Jan 12 2017