Preconnect and Orphaned HTTP_STREAM_JOB netlog entries do not have start event |
|||
Issue descriptionWhen an HttpStreamFactoryImpl::Job is created for preconnects or is orphaned, HttpStreamFactoryImpl::Job::DoStart() does not log the start event (because JobController::GetNetLog() returns nullptr). This causes netlog to only have HTTP_STREAM_JOB end events. This behavior was discovered in Issue 678327. Having unclosed HTTP_STREAM_JOB entries makes reading netlogs hard and I think we should fix it.
,
Jan 11 2017
,
Jan 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/532c355644c454315fd4d4ab879a34840e3677d5 commit 532c355644c454315fd4d4ab879a34840e3677d5 Author: rch <rch@chromium.org> Date: Thu Jan 12 03:02:35 2017 End the QUIC_SESSION net-log event at the end of the QuicChromiumClientSession destructor, instead of in the middle of a loop(?!) in the destructor. BUG= 679968 Review-Url: https://codereview.chromium.org/2625813004 Cr-Commit-Position: refs/heads/master@{#443136} [modify] https://crrev.com/532c355644c454315fd4d4ab879a34840e3677d5/net/quic/chromium/quic_chromium_client_session.cc
,
Jan 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9255195315efa671012f0bd0da1afe685d70b2f6 commit 9255195315efa671012f0bd0da1afe685d70b2f6 Author: xunjieli <xunjieli@chromium.org> Date: Mon Jan 30 15:33:17 2017 Improve HttpStreamFactory NetLog events This CL introduces a SourceType for JobController to better account for orphaned and preconnect jobs: (1) For orphaned job, it will be correctly closed when the job completes. (2) For preconnect job, it will now appear in net-internals because we take NetLog from HttpNetworkSession and log events there. Before this CL, because preconnects do not have an associated stream request, their events are not logged and it is hard to see whether a socket is created due to preconnects. BUG= 679968 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2621983004 Cr-Commit-Position: refs/heads/master@{#446985} [modify] https://crrev.com/9255195315efa671012f0bd0da1afe685d70b2f6/chrome/browser/resources/net_internals/source_entry.js [modify] https://crrev.com/9255195315efa671012f0bd0da1afe685d70b2f6/net/http/http_stream_factory_impl.cc [modify] https://crrev.com/9255195315efa671012f0bd0da1afe685d70b2f6/net/http/http_stream_factory_impl.h [modify] https://crrev.com/9255195315efa671012f0bd0da1afe685d70b2f6/net/http/http_stream_factory_impl_job_controller.cc [modify] https://crrev.com/9255195315efa671012f0bd0da1afe685d70b2f6/net/http/http_stream_factory_impl_job_controller.h [modify] https://crrev.com/9255195315efa671012f0bd0da1afe685d70b2f6/net/http/http_stream_factory_impl_job_controller_unittest.cc [modify] https://crrev.com/9255195315efa671012f0bd0da1afe685d70b2f6/net/http/http_stream_factory_impl_request_unittest.cc [modify] https://crrev.com/9255195315efa671012f0bd0da1afe685d70b2f6/net/log/net_log_event_type_list.h [modify] https://crrev.com/9255195315efa671012f0bd0da1afe685d70b2f6/net/log/net_log_source_type_list.h [modify] https://crrev.com/9255195315efa671012f0bd0da1afe685d70b2f6/net/quic/chromium/quic_network_transaction_unittest.cc [modify] https://crrev.com/9255195315efa671012f0bd0da1afe685d70b2f6/net/spdy/spdy_network_transaction_unittest.cc
,
Jan 30 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by xunji...@chromium.org
, Jan 11 2017