New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679958 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 688433



Sign in to add a comment

Make Feedback e-mail address non-editable

Project Member Reported by kuscher@chromium.org, Jan 11 2017

Issue description

Can we make the e-mail address field in feedback not editable. This would allow better analysis of the feedback. It also seems odd that I can submit feedback and effectively impersonate somebody else. Actions I assume needed here:

1) Make e-mail field not editable
2) Add checkbox so users can uncheck sending their e-mail

@Alberto, let's talk in person about this bug too
 
@Albert, can we find somebody to help us with this?
Blocking: 688433
Owner: afakhry@chromium.org
Status: Assigned (was: Unconfirmed)
@kuscher: Did you want to put the checkbox next to the "Email" title, or with the other checkboxes below?
Selection_105.png
49.1 KB View Download

Comment 5 by kotah@chromium.org, Feb 7 2017

Cc: kotah@chromium.org
Labels: -M-57 M-58
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6795dfa80c19f7e44dc58c37f594b403dab9326e

commit 6795dfa80c19f7e44dc58c37f594b403dab9326e
Author: afakhry <afakhry@chromium.org>
Date: Thu Mar 02 22:06:46 2017

Make email field in Feedback app uneditable

Change the text field to a drop down with an option to let users report
anonymously.
Also make the minimize and close buttons recognizable by ChromeVox

SCREEN_SHOT=https://screenshot.googleplex.com/5nmVg5dyUdG.png
BUG= 679958 
TEST=browser_tests --gtest_filter=FeedbackTest.AnonymousUser
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2728773003
Cr-Commit-Position: refs/heads/master@{#454396}

[modify] https://crrev.com/6795dfa80c19f7e44dc58c37f594b403dab9326e/chrome/app/generated_resources.grd
[modify] https://crrev.com/6795dfa80c19f7e44dc58c37f594b403dab9326e/chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc
[modify] https://crrev.com/6795dfa80c19f7e44dc58c37f594b403dab9326e/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
[modify] https://crrev.com/6795dfa80c19f7e44dc58c37f594b403dab9326e/chrome/browser/resources/feedback/css/feedback.css
[modify] https://crrev.com/6795dfa80c19f7e44dc58c37f594b403dab9326e/chrome/browser/resources/feedback/html/default.html
[modify] https://crrev.com/6795dfa80c19f7e44dc58c37f594b403dab9326e/chrome/browser/resources/feedback/js/feedback.js

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
9334.23.0 / 58.0.3029.39

Sign in to add a comment