New issue
Advanced search Search tips

Issue 679955 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[WPT Export] Move WPT fetch out of LocalWPT constructor

Project Member Reported by jeffcarp@chromium.org, Jan 11 2017

Issue description

Currently the constructor will fetch the WPT. This should be a separate method.
 
Labels: Hotlist-CodeHealth
Probably not blocking  bug 657117 , since this is a refactoring change.

This would be a change at https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py&l=21; when this is done, the related unit test methods should be renamed too :-)

This reminds me of the comment at https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py?l=1008 -- the TestExpectations constructor also does a lot of work.
Blocking: -657117
Good point (I just put everything as blocking  bug 657117  by default to keep track, but maybe that's not the right way to do that).

I'm conflicted though. LocalWPT has a 'fat' constructor because the class is unusable without it. But the expectation is that constructors shouldn't be making network calls or anything with high latency. So I'm still in favor of doing this for LocalWPT and TestExpectations, as you mentioned.
Cc: jeffcarp@chromium.org
Owner: qyears...@chromium.org
Status: Fixed (was: Assigned)
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability

Sign in to add a comment