[WPT Export] Move WPT fetch out of LocalWPT constructor |
|||||
Issue descriptionCurrently the constructor will fetch the WPT. This should be a separate method.
,
Jan 11 2017
Good point (I just put everything as blocking bug 657117 by default to keep track, but maybe that's not the right way to do that). I'm conflicted though. LocalWPT has a 'fat' constructor because the class is unusable without it. But the expectation is that constructors shouldn't be making network calls or anything with high latency. So I'm still in favor of doing this for LocalWPT and TestExpectations, as you mentioned.
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1af3b5587d608b0417f3784703f8d389742cded0 commit 1af3b5587d608b0417f3784703f8d389742cded0 Author: qyearsley <qyearsley@chromium.org> Date: Wed Jan 18 22:44:08 2017 Move WPT fetch out of the LocalWPT constructor. BUG= 679955 Review-Url: https://codereview.chromium.org/2627323008 Cr-Commit-Position: refs/heads/master@{#444522} [modify] https://crrev.com/1af3b5587d608b0417f3784703f8d389742cded0/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py [modify] https://crrev.com/1af3b5587d608b0417f3784703f8d389742cded0/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py [modify] https://crrev.com/1af3b5587d608b0417f3784703f8d389742cded0/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py
,
Jan 18 2017
,
Jul 3 2017
,
Jul 3 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by qyears...@chromium.org
, Jan 11 2017