"org.chromium.chrome.browser.banners.AppBannerManagerTest#testBannerAppearsThenDoesNotAppearAgainForCustomTime" is flaky |
||||||
Issue description"org.chromium.chrome.browser.banners.AppBannerManagerTest#testBannerAppearsThenDoesNotAppearAgainForCustomTime" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyeAsSBUZsYWtlIm1vcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuYmFubmVycy5BcHBCYW5uZXJNYW5hZ2VyVGVzdCN0ZXN0QmFubmVyQXBwZWFyc1RoZW5Eb2VzTm90QXBwZWFyQWdhaW5Gb3JDdXN0b21UaW1lDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jan 11 2017
The latest failure looks like this: org.chromium.chrome.browser.banners.AppBannerManagerTest#testBannerAppearsThenDoesNotAppearAgainForCustomTime (run #1): junit.framework.AssertionFailedError: Criteria not met in allotted time. at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79) at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:117) at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:138) at org.chromium.chrome.browser.banners.AppBannerManagerTest.waitUntilAppBannerInfoBarAppears(AppBannerManagerTest.java:243) at org.chromium.chrome.browser.banners.AppBannerManagerTest.testBannerAppearsThenDoesNotAppearAgainForCustomTime(AppBannerManagerTest.java:437) at java.lang.reflect.Method.invokeNative(Native Method) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:752) at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09a3924243cd62fd49cc091b6948f1455963f851 commit 09a3924243cd62fd49cc091b6948f1455963f851 Author: Philip Jägenstedt <foolip@chromium.org> Date: Wed Jan 11 16:04:39 2017 Disable testBannerAppearsThenDoesNotAppearAgainForCustomTime (flaky) BUG= 679949 TBR=dominickn@chromium.org Review-Url: https://codereview.chromium.org/2627973002 . Cr-Commit-Position: refs/heads/master@{#442913} [modify] https://crrev.com/09a3924243cd62fd49cc091b6948f1455963f851/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
,
Jan 11 2017
,
Jan 11 2017
ianwen@: could https://chromium.googlesource.com/chromium/src/+/7a609035f046b007eb1b0d8302776aeae3b2e174 have caused these flakes? Otherwise, this test has been green for a long time in the flakiness dashboard.
,
Jan 11 2017
For context, this test is failing because an infobar isn't being detected as showing.
,
Jan 26 2017
,
Jan 26 2017
ianwen, before you escape: any thoughts about #5?
,
Jan 30 2017
ianwen's culprit CL was reverted: https://codereview.chromium.org/2665663003/. I'm going to re-enable this test.
,
Jan 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c336037815019df68c431a22870ce4c122a8ddca commit c336037815019df68c431a22870ce4c122a8ddca Author: dominickn <dominickn@chromium.org> Date: Mon Jan 30 19:14:53 2017 Revert of Disable testBannerAppearsThenDoesNotAppearAgainForCustomTime (flaky) (patchset #1 id:1 of https://codereview.chromium.org/2627973002/ ) Reason for revert: Suspect CL causing failures has been reverted (https://codereview.chromium.org/2665663003/) Original issue's description: > Disable testBannerAppearsThenDoesNotAppearAgainForCustomTime (flaky) > > BUG= 679949 > TBR=dominickn@chromium.org > > Review-Url: https://codereview.chromium.org/2627973002 . > Cr-Commit-Position: refs/heads/master@{#442913} > Committed: https://chromium.googlesource.com/chromium/src/+/09a3924243cd62fd49cc091b6948f1455963f851 TBR=foolip@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 679949 Review-Url: https://codereview.chromium.org/2667643002 Cr-Commit-Position: refs/heads/master@{#447028} [modify] https://crrev.com/c336037815019df68c431a22870ce4c122a8ddca/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
,
Jan 31 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by foolip@chromium.org
, Jan 11 2017Status: Assigned (was: Untriaged)