New issue
Advanced search Search tips

Issue 679945 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix getDeviceStates API to return unique interface types

Project Member Reported by harpreet@chromium.org, Jan 11 2017

Issue description

https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/cros/networking/chrome_testing/network_test_ext/background.js?l=45

"getEnabledNetworkDevices" (getDeviceStates vs. getEnabledNetworkTypes) returns an extra 'ethernet' value. See below:


==========================
AFTER CHANGE (returns 'ethernet' twice)
==========================
01/06 14:48:45.326 DEBUG|inspector_websocke:0097| sent [{
  "id": 9,
  "method": "Runtime.evaluate",
  "params": {
    "expression": "chromeTesting.networking.callStatus.getEnabledNetworkDevices",
    "returnByValue": true
  }
}]
01/06 14:48:45.326 DEBUG|inspector_websocke:0164| got [{
  "id": 9,
  "result": {
    "result": {
      "type": "object",
      "value": {
        "error": null,
        "result": [
          "Ethernet",
          "WiFi",
          "Ethernet"
        ],
        "status": "chrome-test-call-status-success"
      }
    }
  }
}]
01/06 14:48:45.326 INFO |chrome_networking_:0059| Enabled Network Devices: [u'Ethernet', u'WiFi', u'Ethernet']
==========================
BEFORE CHANGE
==========================
01/06 14:57:58.249 DEBUG|inspector_websocke:0097| sent [{
  "id": 9,
  "method": "Runtime.evaluate",
  "params": {
    "expression": "chromeTesting.networking.callStatus.getEnabledNetworkDevices",
    "returnByValue": true
  }
}]
01/06 14:57:58.250 DEBUG|inspector_websocke:0164| got [{
  "id": 9,
  "result": {
    "result": {
      "type": "object",
      "value": {
        "error": null,
        "result": [
          "Ethernet",
          "WiFi"
        ],
        "status": "chrome-test-call-status-success"
      }
    }
  }
}]
01/06 14:57:58.250 INFO |chrome_networking_:0059| Enabled Network Devices: [u'Ethernet', u'WiFi']
 
What change are you referring to?
Change of API. We switched from using getEnabledNetworkTypes to getDeviceStates.
Status: Assigned (was: Untriaged)
Untriaged bug with OWNER -> Assigned
untriaged w/ owner -> assigned
Labels: -Pri-3 M-59 Pri-2
Labels: -M-59 M-60
Labels: Hotlist-MD-Settings-Internet-Config
Labels: -M-60 M-61
Labels: -M-61 M-63
Labels: -M-63
Labels: Pri-3

Sign in to add a comment