New issue
Advanced search Search tips

Issue 679941 link

Starred by 1 user
Status: Fixed
Owner:
pwnall@chromium.org
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Implement a local SQLite VFS for sql/ connections.

Project Member Reported by sh...@chromium.org, Jan 11 2017 
Issue 25959 landed a fork to Chromium's SQLite to propagate time-machine exclusions from database files to journals.  Using a SQLite VFS could move this code into sql/ and remove the custom code from SQLite.

Additionally,  issue 537742  has resulted in a long tail of crashes, mostly invalid "disk lost" cases on Windows (see comment 98 and others).  If Chromium had a custom VFS, then the xFetch implementation could use a structured exception handler to catch those crashes (maybe).

[Yes, I admit those two bugs are completely unrelated except by implementation strategy.  And yet it doesn't seem big enough to warrant a blocking bug and two blocked bugs.]
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f2c344add2637d85bcf0370fe5eb882249d77f3

commit 5f2c344add2637d85bcf0370fe5eb882249d77f3
Author: shess <shess@chromium.org>
Date: Tue Jan 24 02:15:10 2017

[sql] Move time-machine support from third_party/sqlite to sql/

Chromium's SQLite was modified to propagate OSX Time-Machine exclusions
from the main database file to any associated journal files.
Re-implement this using a VFS which wraps the default VFS and makes the
check when opening journal files.

BUG= 679941 

Review-Url: https://codereview.chromium.org/2623083002
Cr-Commit-Position: refs/heads/master@{#445601}

[modify] https://crrev.com/5f2c344add2637d85bcf0370fe5eb882249d77f3/sql/BUILD.gn
[modify] https://crrev.com/5f2c344add2637d85bcf0370fe5eb882249d77f3/sql/connection.cc
[modify] https://crrev.com/5f2c344add2637d85bcf0370fe5eb882249d77f3/sql/sqlite_features_unittest.cc
[add] https://crrev.com/5f2c344add2637d85bcf0370fe5eb882249d77f3/sql/vfs_wrapper.cc
[add] https://crrev.com/5f2c344add2637d85bcf0370fe5eb882249d77f3/sql/vfs_wrapper.h
[modify] https://crrev.com/5f2c344add2637d85bcf0370fe5eb882249d77f3/third_party/sqlite/amalgamation/sqlite3.c
[delete] https://crrev.com/b11b7e7c8ade6d7ac945e772dc5776b2fe663bf8/third_party/sqlite/patches/0003-Exclude-journal-file-from-Time-Machine-if-database-i.patch
[modify] https://crrev.com/5f2c344add2637d85bcf0370fe5eb882249d77f3/third_party/sqlite/src/Makefile.linux-gcc
[modify] https://crrev.com/5f2c344add2637d85bcf0370fe5eb882249d77f3/third_party/sqlite/src/ext/fts3/fts3_porter.c
[modify] https://crrev.com/5f2c344add2637d85bcf0370fe5eb882249d77f3/third_party/sqlite/src/main.mk
[modify] https://crrev.com/5f2c344add2637d85bcf0370fe5eb882249d77f3/third_party/sqlite/src/src/pager.c
[modify] https://crrev.com/5f2c344add2637d85bcf0370fe5eb882249d77f3/third_party/sqlite/src/src/sqliteInt.h

Comment 2 by sh...@chromium.org, Jun 21 2017

Labels: ShessReview

Comment 3 by jrobb...@google.com, Sep 21 2017

Owner: pwnall@chromium.org

Comment 4 by pwnall@chromium.org, Feb 6 2018

Status: Fixed (was: Started)
Seems like shess@ fixed this in https://crrev.com/2623083002 before leaving.
►

Sign in to add a comment